mirror of
https://github.com/openai/codex.git
synced 2026-11-16 22:00:36 +00:00
## What changed - Detect visible HTTP(S) URLs in the composer and attach the complete OSC 8 destination to every wrapped fragment, including when part of the URL is scrolled offscreen. - Cache hyperlink metadata with the textarea wrap state while leaving masked input and destinations larger than 8 KiB unannotated. - Make shared hyperlink mapping grapheme-aware, recognize Unicode whitespace boundaries, and scan URLs and trailing delimiters incrementally for large inputs. ## Testing - Add coverage for wrapped and scrolled URLs, joined emoji, Unicode whitespace, preserved highlighting, masked input, cache invalidation, oversized destinations, and drafts containing many URLs. GitOrigin-RevId: 40facdf2fe79438c91c82bff2d849c342f1ab28a
67 lines
2.2 KiB
Rust
67 lines
2.2 KiB
Rust
use super::*;
|
|
use pretty_assertions::assert_eq;
|
|
|
|
#[test]
|
|
fn oversized_destinations_remain_plain_text() {
|
|
let prefix = "https://example.com/";
|
|
let destination = format!(
|
|
"{prefix}{}",
|
|
"a".repeat(MAX_HYPERLINK_DESTINATION_BYTES - prefix.len())
|
|
);
|
|
assert_eq!(web_destination(&destination), Some(destination.clone()));
|
|
let oversized = format!("{destination}é");
|
|
assert_eq!(web_destination(&oversized), None);
|
|
assert_eq!(osc8_hyperlink(&oversized, "visible"), "visible");
|
|
|
|
// Explicit Markdown links can reach the cell marker without bare-URL detection.
|
|
let line = HyperlinkLine {
|
|
line: Line::from("visible"),
|
|
hyperlinks: vec![TerminalHyperlink::web(/*columns*/ 0..7, oversized)],
|
|
};
|
|
let mut buf = Buffer::with_lines(["visible"]);
|
|
let expected = buf.clone();
|
|
let area = buf.area;
|
|
mark_buffer_hyperlinks(&mut buf, area, &[line], /*scroll_rows*/ 0);
|
|
assert_eq!(buf, expected);
|
|
}
|
|
|
|
#[test]
|
|
fn discovers_many_web_urls_with_incremental_columns() {
|
|
let destination = "https://x.io";
|
|
let token = format!("👩💻 ({destination}).\u{2003}");
|
|
let text = token.repeat(/*n*/ 50_000);
|
|
let expected = (0..50_000)
|
|
.map(|index| {
|
|
let start = index * display_width(&token) + 4;
|
|
TerminalHyperlink::web(start..start + destination.len(), destination.to_string())
|
|
})
|
|
.collect::<Vec<_>>();
|
|
assert_eq!(web_links_in_text(&text), expected);
|
|
}
|
|
|
|
#[test]
|
|
fn trims_long_runs_of_unmatched_closing_delimiters() {
|
|
let destination = "https://example.com/a_(b)[c]{d}<e>";
|
|
let text = format!("{destination}{}", ")]}>".repeat(/*n*/ 50_000));
|
|
assert_eq!(
|
|
web_links_in_text(&text),
|
|
vec![TerminalHyperlink::web(
|
|
/*columns*/ 0..destination.len(),
|
|
destination.to_string(),
|
|
)]
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn decorated_hyperlinks_preserve_joined_emoji_columns() {
|
|
let destination = "https://example.test/👩💻/path";
|
|
let line = annotate_web_urls_in_line(Line::from(format!("👩💻 {destination} tail")));
|
|
assert_eq!(
|
|
decorate_spans(&line),
|
|
vec![Span::from(format!(
|
|
"👩💻 {} tail",
|
|
osc8_hyperlink(destination, destination)
|
|
))]
|
|
);
|
|
}
|