taohong-oai 7c997fe2de Attribute approval waits to tool critical-path timing (#57207) ...

## Why

Automatic reviews and user prompts previously invalidated critical-path captures even when their owning tool invocation was known.

## What changed

Record automatic review time as `auto_review` and waits for approvals, permission requests, and user input as `user_wait` when `CriticalPathTiming` is enabled. Bind timing to the owning invocation before asynchronous work begins, and use the triggering tool's identity for network approvals. Continue invalidating captures when a wait cannot be attributed.

## Testing

Add coverage for cancellation, reused call IDs, network ownership, and disabled capture. Update the automatic review integration test to verify attributed review duration.

GitOrigin-RevId: 0a1f5feebd0c4f5ed67dc058e832ec5f8818db02

2026-10-26 19:28:51 +00:00

..

code_mode

Preserve the tool dispatch span across runtime futures (#57202)

2026-10-26 19:20:44 +00:00

executed_tool_calls

Box session metadata and compaction payloads in RolloutItem (#55733)

2026-10-21 02:41:05 +00:00

handlers

Preserve command cwd in permission and post-tool hooks (#57203)

2026-10-26 19:21:08 +00:00

runtimes

Run environment hooks on their owning executors (#56343)

2026-10-23 04:01:39 +00:00

approvals_tests.rs

Preserve command cwd in permission and post-tool hooks (#57203)

2026-10-26 19:21:08 +00:00

approvals.rs

Attribute approval waits to tool critical-path timing (#57207)

2026-10-26 19:28:51 +00:00

call_trace.rs

Add turn, tool, and skill attribution to traces (#56524)

2026-10-23 16:55:32 +00:00

context_tests.rs

Preserve command cwd in permission and post-tool hooks (#57203)

2026-10-26 19:21:08 +00:00

context.rs

Preserve command cwd in permission and post-tool hooks (#57203)

2026-10-26 19:21:08 +00:00

control_tool_analytics.rs

Track history, notes, and async messages as control tools (#40496)

2026-08-24 23:19:03 +00:00

events.rs

Consolidate command execution output into aggregated_output (#50402)

2026-10-02 18:48:49 +00:00

executed_tool_calls_direct_tests.rs

Preserve large arguments in executed tool call metadata (#52268)

2026-10-08 20:40:47 +00:00

executed_tool_calls.rs

Upgrade the Rust toolchain to 1.99.1 (#55677)

2026-10-20 21:28:45 +00:00

hook_names.rs

Default function tools into tool hooks (#23757)

2026-05-23 00:56:58 +00:00

hosted_spec_tests.rs

Use the image generation extension by default (#31596)

2026-07-09 12:25:19 +09:00

hosted_spec.rs

Use the image generation extension by default (#31596)

2026-07-09 12:25:19 +09:00

lifecycle.rs

Run environment hooks on their owning executors (#56343)

2026-10-23 04:01:39 +00:00

metadata_metrics_tests.rs

Preserve live tool-call metadata across request windows (#49401)

2026-09-29 23:24:37 +00:00

metadata_metrics.rs

Preserve live tool-call metadata across request windows (#49401)

2026-09-29 23:24:37 +00:00

mod.rs

Apply model catalog overrides to history, notes, and context tools (#56313)

2026-10-23 00:46:28 +00:00

multi_agent_tool.rs

Apply model catalog overrides to history, notes, and context tools (#56313)

2026-10-23 00:46:28 +00:00

network_approval_tests.rs

Tie network approval reviews to their originating execution (#44575)

2026-09-10 16:17:49 +00:00

network_approval.rs

Run environment hooks on their owning executors (#56343)

2026-10-23 04:01:39 +00:00

orchestrator.rs

Require fresh Guardian approval for escalated tool retries (#54263)

2026-10-15 11:16:13 +00:00

parallel_observation_tests.rs

Expose tool dispatch and timing observations to extensions (#47662)

2026-09-23 20:49:48 +00:00

parallel_trace_tests.rs

Preserve tracing context throughout tool dispatch (#56514)

2026-10-23 16:07:55 +00:00

parallel.rs

Preserve the tool dispatch span across runtime futures (#57202)

2026-10-26 19:20:44 +00:00

registry_tests.rs

Preserve command cwd in permission and post-tool hooks (#57203)

2026-10-26 19:21:08 +00:00

registry.rs

Preserve command cwd in permission and post-tool hooks (#57203)

2026-10-26 19:21:08 +00:00

router_tests.rs

Add opt-in output token replay for OpenAI requests (#52742)

2026-10-10 01:25:00 +00:00

router.rs

Run environment hooks on their owning executors (#56343)

2026-10-23 04:01:39 +00:00

sandboxing_tests.rs

Preserve command cwd in permission and post-tool hooks (#57203)

2026-10-26 19:21:08 +00:00

sandboxing.rs

Preserve command cwd in permission and post-tool hooks (#57203)

2026-10-26 19:21:08 +00:00

spec_plan_strict_third_party_tests.rs

Isolate tracing in the strict third-party tool deferral test (#50977)

2026-10-04 23:07:12 +00:00

spec_plan_tests.rs

Apply model catalog overrides to history, notes, and context tools (#56313)

2026-10-23 00:46:28 +00:00

spec_plan.rs

Apply model catalog overrides to history, notes, and context tools (#56313)

2026-10-23 00:46:28 +00:00

tool_dispatch_trace_tests.rs

Run environment hooks on their owning executors (#56343)

2026-10-23 04:01:39 +00:00

tool_dispatch_trace.rs

Canonicalize default tools under the functions namespace (#37022)

2026-08-05 04:07:59 +00:00

tool_namespaces_info.rs

Include tool namespace inventory in turn metadata (#37492)

2026-08-07 19:32:15 +00:00

user_messaging_tests.rs

Preserve command cwd in permission and post-tool hooks (#57203)

2026-10-26 19:21:08 +00:00

user_messaging.rs

Retain confirmed Code Mode messages for Guardian reviews (#48725)

2026-09-27 15:03:38 +00:00