Files
codex/codex-rs/thread-store
Charlie Marsh b8cbdbfeff Preserve SQLite row metadata in thread listings (#61866)
## Why

Direct SQLite listings already contain thread titles and section ordering metadata. Converting those rows to rollout summaries and fetching metadata again discards the original per-row values.

## What changed

Build thread listings directly from the collected SQLite rows, retaining their titles, section positions, and section entry times. Preserve row order and each occurrence's metadata when a thread appears more than once during pagination refill. Continue resolving legacy names from the session index with the existing title precedence.

Keep rollout listings and search name enrichment best effort, and avoid redundant metadata queries for direct SQLite listings.

## Testing

Add coverage for repeated legacy rows retaining indexed names and distinct timestamps and section positions. Extend listing tests to check SQLite titles and section metadata in recent-thread results.

GitOrigin-RevId: 838036250d38e6ca1b403741de3e6dd3eafdd04b
2026-11-16 19:30:11 +00:00
..
2026-04-14 13:51:00 -07:00

Thread Store

codex-thread-store is the storage boundary for Codex threads. It defines the ThreadStore trait plus local and in-memory implementations. Other storage implementations may live outside this repository.

Responsibilities

  • ThreadStore::append_items is the raw canonical history append API. It does not infer metadata from item contents.
  • ThreadStore::update_thread_metadata is the only thread metadata write API. It accepts a single literal metadata patch shape, regardless of whether the caller is applying a user/API mutation or facts derived above the store from appended history.
  • LiveThread is the preferred API for active session persistence. It owns a per-thread metadata sync helper, applies the rollout persistence policy, appends canonical history, and then sends metadata patches through ThreadStore::update_thread_metadata.
  • ThreadManager routes metadata mutations for loaded and cold threads through one entrypoint. Loaded threads use their LiveThread; cold threads go directly to the store.
  • LocalThreadStore persists history through codex-rollout JSONL files and persists queryable metadata through the SQLite state database when available. Local explicit metadata mutations also maintain JSONL/name-index compatibility so reading old or SQLite-less local storage keeps working.
  • RolloutRecorder is the local JSONL writer. It writes already-canonical items for ThreadStore::append_items; it no longer decides metadata updates for live thread-store appends.
  • core/session creates or resumes LiveThread handles and does not need to know whether persistence is backed by local files or another store.

Direction

New metadata observation semantics should live above ThreadStore. Stores persist explicit metadata fields, but raw history appends remain history-only.