mirror of
https://github.com/openai/codex.git
synced 2026-10-19 17:28:46 +00:00
Eric Traut
785ecd7452
## Why When the app server reports a misalignment policy violation, the TUI must stop the affected chat rather than allow more work to continue in it. ## What changed - Finalize the active turn, clear queued and draft input, disable the composer, and reject further operations and interactive requests for the stopped chat. - Interrupt an active side conversation when its parent reports the violation, and prevent queued turns, forks, approvals, or goal resumption from restarting work. - Show a non-dismissible precaution view that directs users to start a new chat or resume another one, with agent command center navigation for remote sessions. ## Testing Added coverage for stopped-chat behavior, parent/side-thread handling, blocked goal resumption, navigation actions, and narrow and remote-session rendering. GitOrigin-RevId: 0268c46a19294a17765ea4099f389f15ffaaf030
84 lines
3.0 KiB
Rust
84 lines
3.0 KiB
Rust
//! Terminal precaution UI for misalignment policy violations.
|
||
|
||
use super::*;
|
||
|
||
const MISALIGNMENT_POLICY_TITLE: &str = "Chat stopped as a precaution";
|
||
const MISALIGNMENT_POLICY_DESCRIPTION: &str = "We couldn’t confirm the agent was acting safely and following your instructions. To continue working, start or resume another chat.";
|
||
|
||
impl ChatWidget {
|
||
pub(crate) fn has_misalignment_policy_violation(&self) -> bool {
|
||
self.misalignment_policy_violation
|
||
}
|
||
|
||
pub(crate) fn rejects_misalignment_policy_op(&self, op: &AppCommand) -> bool {
|
||
self.misalignment_policy_violation
|
||
&& !matches!(
|
||
op,
|
||
AppCommand::Interrupt
|
||
| AppCommand::CleanBackgroundTerminals
|
||
| AppCommand::OverrideTurnContext { .. }
|
||
| AppCommand::ReloadUserConfig
|
||
| AppCommand::ListSkills { .. }
|
||
| AppCommand::SetThreadName { .. }
|
||
)
|
||
}
|
||
|
||
pub(crate) fn on_misalignment_policy_violation(&mut self) {
|
||
if self.misalignment_policy_violation {
|
||
return;
|
||
}
|
||
|
||
self.misalignment_policy_violation = true;
|
||
self.input_queue.clear();
|
||
self.finalize_turn();
|
||
self.refresh_pending_input_preview();
|
||
self.bottom_pane.drain_pending_submission_state();
|
||
self.bottom_pane
|
||
.set_composer_text(String::new(), Vec::new(), Vec::new());
|
||
self.bottom_pane.set_composer_input_enabled(
|
||
/*enabled*/ false,
|
||
Some(MISALIGNMENT_POLICY_TITLE.to_string()),
|
||
);
|
||
|
||
self.show_misalignment_policy_precaution();
|
||
}
|
||
|
||
pub(crate) fn show_misalignment_policy_precaution(&mut self) {
|
||
let mut items = vec![
|
||
SelectionItem {
|
||
name: "New chat".to_string(),
|
||
actions: vec![Box::new(|tx| tx.send(AppEvent::NewSession { name: None }))],
|
||
dismiss_on_select: true,
|
||
..Default::default()
|
||
},
|
||
SelectionItem {
|
||
name: "Resume another chat".to_string(),
|
||
actions: vec![Box::new(|tx| tx.send(AppEvent::OpenResumePicker))],
|
||
..Default::default()
|
||
},
|
||
];
|
||
if self.remote_connection.is_some() {
|
||
items.insert(
|
||
1,
|
||
SelectionItem {
|
||
name: "Agent command center".to_string(),
|
||
actions: vec![Box::new(|tx| tx.send(AppEvent::OpenAgentsOverview))],
|
||
..Default::default()
|
||
},
|
||
);
|
||
}
|
||
self.bottom_pane.show_selection_view(SelectionViewParams {
|
||
header: Box::new(
|
||
Paragraph::new(vec![
|
||
Line::from(MISALIGNMENT_POLICY_TITLE).bold(),
|
||
Line::from(MISALIGNMENT_POLICY_DESCRIPTION).dim(),
|
||
])
|
||
.wrap(Wrap { trim: false }),
|
||
),
|
||
items,
|
||
allow_cancel: false,
|
||
..Default::default()
|
||
});
|
||
}
|
||
}
|