mirror of
https://github.com/openai/codex.git
synced 2026-11-16 22:00:36 +00:00
## Why The app-server and exec-server expose separate JSON-RPC APIs, but exec-server currently sources its serialized protocol and envelope types through app-server-oriented code. Giving each API an explicit owner makes the crate boundary legible without introducing shared generic envelopes. ## What changed - Added `codex-exec-server-protocol` to own exec DTOs, process IDs, and JSON-RPC envelopes. - Updated exec-server clients, transports, handlers, and tests to use the new crate. - Exposed app-server's existing JSON-RPC types through a public `rpc` module while retaining root re-exports. - Preserved existing wire shapes, including exec `PathUri` behavior. ## Stack This is PR 1 of 6. Next: [PR #29721](https://github.com/openai/codex/pull/29721), which moves auth mode below the app wire boundary. ## Validation - Exec-server protocol and server coverage passed in the focused protocol test runs. - App-server protocol schema fixtures passed.
53 lines
1.6 KiB
Rust
53 lines
1.6 KiB
Rust
use codex_exec_server_protocol::JSONRPCMessage;
|
|
use codex_exec_server_protocol::JSONRPCNotification;
|
|
use pretty_assertions::assert_eq;
|
|
|
|
use super::JsonRpcMessageDecoder;
|
|
use super::MAX_NOISE_JSONRPC_MESSAGE_LEN;
|
|
use super::NOISE_RECORD_PLAINTEXT_LEN;
|
|
use super::frame_jsonrpc_message;
|
|
use crate::ExecServerError;
|
|
|
|
#[test]
|
|
fn fragments_and_reassembles_large_jsonrpc_message() {
|
|
let message = JSONRPCMessage::Notification(JSONRPCNotification {
|
|
method: "large/test".to_string(),
|
|
params: Some(serde_json::json!({
|
|
"data": "x".repeat(128 * 1024),
|
|
})),
|
|
});
|
|
let framed = frame_jsonrpc_message(&message).unwrap();
|
|
assert!(framed.len() > 128 * 1024);
|
|
|
|
let mut decoder = JsonRpcMessageDecoder::default();
|
|
let mut decoded = Vec::new();
|
|
for record in framed.chunks(NOISE_RECORD_PLAINTEXT_LEN) {
|
|
decoded.extend(decoder.push(record).unwrap());
|
|
}
|
|
|
|
assert_eq!(decoded, vec![message]);
|
|
}
|
|
|
|
#[test]
|
|
fn rejects_declared_message_length_above_limit_without_payload() {
|
|
let mut decoder = JsonRpcMessageDecoder::default();
|
|
let declared_len = (MAX_NOISE_JSONRPC_MESSAGE_LEN as u32 + 1).to_be_bytes();
|
|
|
|
assert!(matches!(
|
|
decoder.push(&declared_len),
|
|
Err(ExecServerError::Protocol(message))
|
|
if message == "Noise relay JSON-RPC message has invalid length"
|
|
));
|
|
}
|
|
|
|
#[test]
|
|
fn rejects_oversized_plaintext_record() {
|
|
let mut decoder = JsonRpcMessageDecoder::default();
|
|
|
|
assert!(matches!(
|
|
decoder.push(&vec![0; NOISE_RECORD_PLAINTEXT_LEN + 1]),
|
|
Err(ExecServerError::Protocol(message))
|
|
if message == "Noise relay plaintext record exceeds maximum length"
|
|
));
|
|
}
|