mirror of
https://github.com/openai/codex.git
synced 2026-10-23 18:08:45 +00:00
Tom Wiltzius
737f4fe3aa
Make the ThreadStore contract coherent: append_items is now a raw canonical history append, and update_thread_metadata is the single metadata write API. ThreadStore implementations no longer infer metadata by inspecting appended rollout items. LiveThread now owns the live append flow. It applies the rollout persistence policy before writing JSONL history, observes the canonical items with a small ThreadMetadataSync helper, and sends the derived facts back through update_thread_metadata. ThreadManager becomes the single app-facing metadata entrypoint, routing loaded threads through LiveThread and cold threads directly to the store. LocalThreadStore preserves the local compatibility requirements inside the local implementation. SQLite, when available, receives explicit metadata updates. JSONL and name-index compatibility are still maintained for explicit metadata mutations such as rename, memory-mode, and git changes, so old rollout files and SQLite-less local storage remain readable. RolloutRecorder is reduced to local JSONL writing for thread-store appends. The shared rollout persistence policy remains in codex-rollout, but recorder no longer owns live metadata synthesis. The added thread-store README captures the new ownership boundaries for future remote and local implementations.
1.8 KiB
1.8 KiB
Thread Store
codex-thread-store is the storage boundary for Codex threads. It defines the
ThreadStore trait plus local and in-memory implementations. Other storage
implementations may live outside this repository.
Responsibilities
ThreadStore::append_itemsis the raw canonical history append API. It does not infer metadata from item contents.ThreadStore::update_thread_metadatais the only thread metadata write API. It accepts a single literal metadata patch shape, regardless of whether the caller is applying a user/API mutation or facts derived above the store from appended history.LiveThreadis the preferred API for active session persistence. It owns a per-thread metadata sync helper, applies the rollout persistence policy, appends canonical history, and then sends metadata patches throughThreadStore::update_thread_metadata.ThreadManagerroutes metadata mutations for loaded and cold threads through one entrypoint. Loaded threads use theirLiveThread; cold threads go directly to the store.LocalThreadStorepersists history throughcodex-rolloutJSONL files and persists queryable metadata through the SQLite state database when available. Local explicit metadata mutations also maintain JSONL/name-index compatibility so reading old or SQLite-less local storage keeps working.RolloutRecorderis the local JSONL writer. It writes already-canonical items forThreadStore::append_items; it no longer decides metadata updates for live thread-store appends.core/sessioncreates or resumesLiveThreadhandles and does not need to know whether persistence is backed by local files or another store.
Direction
New metadata observation semantics should live above ThreadStore. Stores
persist explicit metadata fields, but raw history appends remain history-only.