canvrno-oai 679f63ba06 Fix clippy warnings in external agent config migration (#17884) ...

Fix clippy warnings in external agent config migration

```
error: this expression creates a reference which is immediately dereferenced by the compiler
   --> core/src/external_agent_config.rs:188:55
    |
188 |             let migrated = build_config_from_external(&settings)?;
    |                                                       ^^^^^^^^^ help: change this to: `settings`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
    = note: requested on the command line with `-D clippy::needless-borrow`

error: useless conversion to the same type: `codex_utils_absolute_path::AbsolutePathBuf`
   --> core/src/external_agent_config.rs:355:27
    |
355 |                       match AbsolutePathBuf::try_from(
    |  ___________________________^
356 | |                         add_marketplace_outcome
357 | |                             .installed_root
358 | |                             .join(INSTALLED_MARKETPLACE_MANIFEST_RELATIVE_PATH),
359 | |                     ) {
    | |_____________________^
    |
    = help: consider removing `AbsolutePathBuf::try_from()`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

error: aborting due to 2 previous errors
```

2026-04-14 20:36:48 -07:00

..

agent

Make skill loading filesystem-aware (#17720)

2026-04-14 15:40:40 -07:00

apps

[codex] reduce module visibility (#16978)

2026-04-07 08:03:35 -07:00

bin

Refactor config types into a separate crate (#16962)

2026-04-07 00:32:41 +00:00

codex

[codex-analytics] add protocol-native turn timestamps (#16638)

2026-04-06 16:22:59 -07:00

config

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

config_loader

Update guardian output schema (#17061)

2026-04-08 15:47:29 -07:00

context_manager

feat(guardian): send only transcript deltas on guardian followups (#17269)

2026-04-10 07:48:44 -07:00

guardian

Disable hooks in guardian review sessions (#17872)

2026-04-14 19:47:50 -07:00

instructions

[codex] reduce module visibility (#16978)

2026-04-07 08:03:35 -07:00

memories

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

plugins

[codex] Support local marketplace sources (#17756)

2026-04-14 15:58:14 -07:00

sandboxing

Build remote exec env from exec-server policy (#17216)

2026-04-13 09:59:08 +01:00

snapshots

[codex] Defer fork context injection until first turn (#15699)

2026-03-24 18:34:44 -07:00

state

[codex-analytics] feature plumbing and emittance (#16640)

2026-04-13 23:11:49 -07:00

tasks

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

tools

Adjust default tool search result caps (#17684)

2026-04-14 14:57:19 -07:00

unified_exec

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

utils

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

apply_patch_tests.rs

[codex] Migrate apply_patch to executor filesystem (#17027)

2026-04-07 21:20:22 +00:00

apply_patch.rs

Route apply_patch through the environment filesystem (#17674)

2026-04-14 12:49:02 -07:00

arc_monitor_tests.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

arc_monitor.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

client_common_tests.rs

fix(app-server) revert null instructions changes (#17047)

2026-04-07 15:18:34 -07:00

client_common.rs

fix(app-server) revert null instructions changes (#17047)

2026-04-07 15:18:34 -07:00

client_tests.rs

feat(analytics): generate an installation_id and pass it in responsesapi client_metadata (#16912)

2026-04-07 09:52:17 -07:00

client.rs

Attach WebRTC realtime starts to sideband websocket (#17057)

2026-04-08 15:25:42 -07:00

codex_delegate_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

codex_delegate.rs

Fix for CI Tests failing from stack overflow (#17846)

2026-04-14 18:04:35 -07:00

codex_tests_guardian.rs

[codex-analytics] feature plumbing and emittance (#16640)

2026-04-13 23:11:49 -07:00

codex_tests.rs

Make skill loading filesystem-aware (#17720)

2026-04-14 15:40:40 -07:00

codex_thread.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

codex.rs

Make skill loading filesystem-aware (#17720)

2026-04-14 15:40:40 -07:00

command_canonicalization_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

command_canonicalization.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

commit_attribution_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

commit_attribution.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

compact_remote.rs

[codex-analytics] add compaction analytics event (#17155)

2026-04-10 13:03:54 -07:00

compact_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

compact.rs

[codex-analytics] feature plumbing and emittance (#16640)

2026-04-13 23:11:49 -07:00

connectors_tests.rs

Refactor plugin loading to async (#17747)

2026-04-13 21:52:56 -07:00

connectors.rs

Refactor plugin loading to async (#17747)

2026-04-13 21:52:56 -07:00

consequential_tool_message_templates.json

[elicitation] User-friendly tool call messages. (#14403)

2026-03-12 00:35:21 -07:00

contextual_user_message_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

contextual_user_message.rs

Extract codex-instructions crate (#15744)

2026-03-25 10:43:49 -07:00

environment_context_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

environment_context.rs

chore: refactor network permissions to use explicit domain and unix socket rule maps (#15120)

2026-03-27 06:17:59 +00:00

event_mapping_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

event_mapping.rs

Trim pre-turn context updates during rollback (#15577)

2026-03-24 12:43:53 -07:00

exec_env_tests.rs

fix: preserve platform-specific core shell env vars (#16707)

2026-04-03 12:07:07 -07:00

exec_env.rs

Build remote exec env from exec-server policy (#17216)

2026-04-13 09:59:08 +01:00

exec_policy_tests.rs

feat(requirements): support allowed_approval_reviewers (#16701)

2026-04-06 11:11:44 -07:00

exec_policy.rs

[codex] Make AbsolutePathBuf joins infallible (#16981)

2026-04-07 10:52:08 -07:00

exec_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

exec.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

external_agent_config_tests.rs

support plugins in external agent config migration (#17855)

2026-04-14 19:39:10 -07:00

external_agent_config.rs

Fix clippy warnings in external agent config migration (#17884)

2026-04-14 20:36:48 -07:00

file_watcher_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

file_watcher.rs

Make skill loading filesystem-aware (#17720)

2026-04-14 15:40:40 -07:00

flags.rs

chore: drop unused values from env_flags (#4188)

2025-09-24 14:29:51 -07:00

function_tool.rs

nit: drop unused function call error (#8903)

2026-01-08 15:07:30 +00:00

git_info_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

hook_runtime.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

installation_id.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

landlock.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

lib.rs

Revert "Option to Notify Workspace Owner When Usage Limit is Reached" (#17391)

2026-04-10 23:33:13 +00:00

mcp_openai_file.rs

feat: add Codex Apps sediment file remapping (#15197)

2026-04-09 14:10:44 -04:00

mcp_skill_dependencies.rs

Refactor plugin loading to async (#17747)

2026-04-13 21:52:56 -07:00

mcp_tool_approval_templates.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

mcp_tool_call_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

mcp_tool_call.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

mcp_tool_exposure.rs

[mcp] Expand tool search to custom MCPs. (#16944)

2026-04-09 13:34:52 -07:00

mcp.rs

Refactor plugin loading to async (#17747)

2026-04-13 21:52:56 -07:00

memory_trace_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

memory_trace.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

mention_syntax.rs

Extract codex-utils-plugins crate (#15746)

2026-03-25 11:05:35 -07:00

message_history_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

message_history.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

network_policy_decision_tests.rs

extract models manager and related ownership from core (#16508)

2026-04-02 23:00:02 -07:00

network_policy_decision.rs

refactor(proxy): clarify sandbox block messages (#17168)

2026-04-09 10:53:06 -07:00

network_proxy_loader_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

network_proxy_loader.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

original_image_detail.rs

Extract tool config into codex-tools (#16379)

2026-04-01 13:21:50 -07:00

otel_init.rs

Use AbsolutePathBuf in skill loading and codex_home (#17407)

2026-04-13 10:26:51 -07:00

personality_migration_tests.rs

fix(app-server) revert null instructions changes (#17047)

2026-04-07 15:18:34 -07:00

personality_migration.rs

Refactor config types into a separate crate (#16962)

2026-04-07 00:32:41 +00:00

project_doc_tests.rs

Always enable original image detail on supported models (#17665)

2026-04-14 08:15:56 -07:00

project_doc.rs

Use AbsolutePathBuf in skill loading and codex_home (#17407)

2026-04-13 10:26:51 -07:00

prompt_debug.rs

Use AbsolutePathBuf in skill loading and codex_home (#17407)

2026-04-13 10:26:51 -07:00

realtime_context_tests.rs

Budget realtime current thread context (#17519)

2026-04-12 11:59:09 -07:00

realtime_context.rs

Cap realtime mirrored user turns (#17685)

2026-04-13 14:31:18 -07:00

realtime_conversation_tests.rs

Wrap delegated input text (#17868)

2026-04-14 19:58:58 -07:00

realtime_conversation.rs

Wrap delegated input text (#17868)

2026-04-14 19:58:58 -07:00

realtime_prompt.rs

fix (#17493)

2026-04-11 13:52:17 -07:00

review_format.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

review_prompts.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

rollout.rs

chore: merge name and title (#17116)

2026-04-09 18:44:26 +01:00

safety_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

safety.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

sandbox_tags_tests.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

sandbox_tags.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

seatbelt.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

session_prefix.rs

feat: change multi-agent to use path-like system instead of uuids (#15313)

2026-03-20 18:23:48 +00:00

session_rollout_init_error.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

session_startup_prewarm.rs

fix(app-server) revert null instructions changes (#17047)

2026-04-07 15:18:34 -07:00

shell_detect.rs

chore: rename codex-command to codex-shell-command (#11378)

2026-02-10 17:03:46 -08:00

shell_snapshot_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

shell_snapshot.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

shell_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

shell.rs

fix: add shell fallback paths for pwsh/powershell that work on GitHub Actions Windows runners (#16617)

2026-04-02 13:47:10 -07:00

skills_watcher.rs

Make skill loading filesystem-aware (#17720)

2026-04-14 15:40:40 -07:00

skills.rs

Use AbsolutePathBuf in skill loading and codex_home (#17407)

2026-04-13 10:26:51 -07:00

spawn.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

state_db_bridge.rs

[codex] reduce module visibility (#16978)

2026-04-07 08:03:35 -07:00

stream_events_utils_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

stream_events_utils.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

test_support.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

thread_manager_tests.rs

Use AbsolutePathBuf in skill loading and codex_home (#17407)

2026-04-13 10:26:51 -07:00

thread_manager.rs

Make skill loading filesystem-aware (#17720)

2026-04-14 15:40:40 -07:00

thread_rollout_truncation_tests.rs

fix: update fork boundaries computation (#16322)

2026-03-31 14:10:43 +02:00

thread_rollout_truncation.rs

[codex-analytics] feature plumbing and emittance (#16640)

2026-04-13 23:11:49 -07:00

turn_diff_tracker_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

turn_diff_tracker.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

turn_metadata_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

turn_metadata.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

turn_timing_tests.rs

feat: add memory citation to agent message (#14821)

2026-03-18 10:03:38 +00:00

turn_timing.rs

[codex] reduce module visibility (#16978)

2026-04-07 08:03:35 -07:00

user_shell_command_tests.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

user_shell_command.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

util_tests.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

util.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

web_search.rs

add missing fields to WebSearchAction and update app-server types (#10276)

2026-01-30 16:37:56 -08:00

windows_sandbox_read_grants_tests.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

windows_sandbox_read_grants.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

windows_sandbox_tests.rs

Configure multi_agent_v2 spawn agent hints (#17071)

2026-04-08 08:42:18 -07:00

windows_sandbox.rs

Configure multi_agent_v2 spawn agent hints (#17071)

2026-04-08 08:42:18 -07:00