mirror of
https://github.com/openai/codex.git
synced 2026-09-20 12:47:38 +00:00
3305c4f31d
## Why A delegate bound at session creation cannot provide different callbacks for cells sharing that session. Each execution needs to retain its own delegate across yields and release it when the cell is cleaned up. ## What changed - Pass `CodeModeSessionDelegate` to `execute` instead of session creation. - Route tool calls, notifications, and cell closure callbacks through the execution's delegate in the in-process runtime and the gRPC and stdio transports. - Retain delegates with pending executions and live cells, releasing them through closure and cancellation cleanup. ## Testing Add coverage for distinct delegates across yielded cells, gRPC callbacks before cell admission, and delegate release after completion or abandoned execution cleanup. Update transport tests to verify callbacks reach the owning cell's delegate. GitOrigin-RevId: 7469f52104b993e790a40c65fb800ad02b7fd606
95 lines
3.1 KiB
Rust
95 lines
3.1 KiB
Rust
use std::io;
|
|
use std::path::PathBuf;
|
|
use std::sync::Arc;
|
|
|
|
use codex_code_mode_protocol::CodeModeSessionProvider;
|
|
use pretty_assertions::assert_eq;
|
|
|
|
use super::ProcessOwnedCodeModeSession;
|
|
use super::ProcessOwnedCodeModeSessionProvider;
|
|
use super::connection::ConnectionError;
|
|
use crate::NoopCodeModeSessionDelegate;
|
|
|
|
#[test]
|
|
fn provider_reuses_its_live_process_host() {
|
|
let provider = ProcessOwnedCodeModeSessionProvider::default();
|
|
|
|
let first = provider.process_host();
|
|
let second = provider.process_host();
|
|
|
|
assert!(Arc::ptr_eq(&first, &second));
|
|
}
|
|
|
|
#[test]
|
|
fn missing_host_error_limits_the_displayed_path_to_512_bytes() {
|
|
let executable = "codex-code-mode-host-does-not-exist";
|
|
let host_program = format!("{}{executable}", "missing-directory/".repeat(/*n*/ 64));
|
|
let expected_suffix = &host_program[host_program.len() - (512 - "...".len())..];
|
|
let error = ConnectionError::Spawn {
|
|
host_program: PathBuf::from(&host_program),
|
|
error: io::Error::new(io::ErrorKind::NotFound, "host unavailable"),
|
|
};
|
|
|
|
assert_eq!(
|
|
error.to_string(),
|
|
format!("failed to spawn code-mode host ...{expected_suffix}: host unavailable")
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn missing_host_error_preserves_utf8_boundaries_when_truncating_the_path() {
|
|
let executable = "codex-code-mode-host-does-not-exist";
|
|
let host_program = format!("{}{executable}", "🦀".repeat(/*n*/ 256));
|
|
let error = ConnectionError::Spawn {
|
|
host_program: PathBuf::from(host_program),
|
|
error: io::Error::new(io::ErrorKind::NotFound, "host unavailable"),
|
|
}
|
|
.to_string();
|
|
let displayed_path = error
|
|
.strip_prefix("failed to spawn code-mode host ")
|
|
.and_then(|message| message.strip_suffix(": host unavailable"))
|
|
.expect("missing-host error should contain the displayed host path");
|
|
|
|
assert!(displayed_path.starts_with("..."));
|
|
assert!(displayed_path.ends_with(executable));
|
|
assert!(displayed_path.len() <= 512);
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn provider_returns_missing_host_error() {
|
|
let provider = ProcessOwnedCodeModeSessionProvider::with_host_program(
|
|
"codex-code-mode-host-does-not-exist".into(),
|
|
);
|
|
|
|
let error = provider
|
|
.create_session()
|
|
.await
|
|
.err()
|
|
.expect("missing host should fail");
|
|
|
|
assert!(error.contains("failed to spawn code-mode host codex-code-mode-host-does-not-exist"));
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn shutdown_before_open_does_not_spawn_the_host() {
|
|
let session = ProcessOwnedCodeModeSession::new();
|
|
|
|
session.shutdown().await.expect("shutdown session");
|
|
let error = session
|
|
.execute(
|
|
codex_code_mode_protocol::ExecuteRequest {
|
|
tool_call_id: "call-1".to_string(),
|
|
enabled_tools: Vec::new(),
|
|
source: "text('unreachable')".to_string(),
|
|
yield_time_ms: None,
|
|
max_output_tokens: None,
|
|
},
|
|
Arc::new(NoopCodeModeSessionDelegate),
|
|
)
|
|
.await
|
|
.err()
|
|
.expect("shutdown session should reject execution");
|
|
|
|
assert_eq!(error, "code mode session is shutting down");
|
|
}
|