mirror of
https://github.com/openai/codex.git
synced 2026-11-19 22:30:42 +00:00
## What changed - Make `TimeProvider::current_time` and `CodexThread::current_time` synchronous, with clock reads required to avoid yielding or calling back into the session. - Remove the experimental `currentTime/read` app-server request and its client-backed clock and sleep polling implementation. - Require a host-provided `TimeProvider` for external clocks. App-server thread startup now fails when `features.current_time_reminder.clock_source = "external"` has no provider. ## Testing Add coverage for external provider selection and rejection of app-server thread startup without an external provider. GitOrigin-RevId: 09479d6eb28453b343dee78b3673092e73ae5d73
23 lines
760 B
Rust
23 lines
760 B
Rust
#![cfg(test)]
|
|
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn explicit_external_time_requires_a_provider() {
|
|
let config = CurrentTimeReminderConfig {
|
|
clock_source: CurrentTimeSource::External,
|
|
..Default::default()
|
|
};
|
|
let err = resolve_time_provider(Some(&config), /*external_provider*/ None)
|
|
.err()
|
|
.expect("missing provider");
|
|
assert!(
|
|
err.to_string()
|
|
.contains("no external current-time provider")
|
|
);
|
|
let provider: Arc<dyn TimeProvider> = Arc::new(SystemTimeProvider);
|
|
let selected = resolve_time_provider(Some(&config), Some(Arc::clone(&provider))).unwrap();
|
|
assert!(Arc::ptr_eq(&selected, &provider));
|
|
assert!(resolve_time_provider(/*config*/ None, /*external_provider*/ None).is_ok());
|
|
}
|