jif 5eea8d0dd3 Review terminal input against retained permissions (#41328) ...

## Why

An existing terminal keeps the sandbox, network settings, and grants it had at launch. Later `write_stdin` calls must account for that retained authority, including when permissions change between turns.

## What changed

- Capture each terminal's effective launch permissions and compare them with the current environment before accepting non-empty input.
- Request approval when the terminal bypassed the sandbox, retains additional grants, strict auto-review is active, or its sandbox or network settings differ from the current policy.
- Reject input when current denied-read or environment-owned network restrictions cannot be enforced by the existing terminal, while keeping empty polls and non-TTY interrupts available without review.
- Include the effective sandbox mode and user-visible additional grants in `write_stdin` approval actions without exposing host-owned grant paths.

## Testing

Added unit and end-to-end coverage for retained cross-turn grants, strict auto-review, sandbox and network policy changes, denied reads, Windows sandbox backends, and private grant redaction.

GitOrigin-RevId: e2d71daf9358474c885998786c4928069100711c

2026-08-28 11:38:03 +00:00

..

snapshots

Track window and fork positions in turn metadata (#40987)

2026-08-26 22:37:59 +00:00

abort_tasks.rs

Add per-turn cyber access program selection (#40687)

2026-08-25 19:54:52 +00:00

additional_context.rs

Annotate user input and contextual fragments with content kinds (#40196)

2026-08-23 06:10:44 +00:00

agent_execution.rs

Honor environment-resolved workspace roots (#40912)

2026-08-26 16:28:35 +00:00

agent_websocket.rs

Track window and fork positions in turn metadata (#40987)

2026-08-26 22:37:59 +00:00

agents_md.rs

Gate content item kinds behind a feature flag (#40450)

2026-08-24 18:22:13 +00:00

apply_patch_cli.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

apply_patch_serialization.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

approvals.rs

Add credential brokering to network proxy feature config (#40466)

2026-08-24 19:52:27 +00:00

audio_truncation.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

auto_review.rs

Make Ultra reasoning fallback model-aware (#41206)

2026-08-27 21:03:09 +00:00

catalog_permission_messages.rs

Forward model confirmation policies to actor MCP tools (#41072)

2026-08-27 06:58:07 +00:00

cli_stream.rs

Sanitize credentials from Git remote metadata (#40713)

2026-08-25 21:34:05 +00:00

client_websockets.rs

Expose response usage metadata in completion events (#41087)

2026-08-27 07:50:05 +00:00

client.rs

Expose the PowerShell version in environment context (#41232)

2026-08-28 00:22:05 +00:00

cloud_config.rs

Preserve managed deny-read rules across permission updates (#40004)

2026-08-21 20:15:23 +00:00

code_mode_elicitation.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

code_mode.rs

Roll over Guardian context before follow-up reviews (#41215)

2026-08-27 22:28:46 +00:00

codex_delegate.rs

Preserve MCP tool output as content items (#40737)

2026-08-25 23:42:50 +00:00

collaboration_instructions.rs

Forward model confirmation policies to actor MCP tools (#41072)

2026-08-27 06:58:07 +00:00

compact_remote_parity.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

compact_remote.rs

Enable retained-image budgeting by default (#40994)

2026-08-26 23:05:08 +00:00

compact_resume_fork.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

compact.rs

Finalize model-specific tool plans in ToolRouter (#41195)

2026-08-27 20:01:39 +00:00

context_annotations.rs

Gate content item kinds behind a feature flag (#40450)

2026-08-24 18:22:13 +00:00

current_time_reminder.rs

Add configurable gating for the sleep tool (#41243)

2026-08-28 02:09:07 +00:00

cyber_access_program.rs

Add per-turn cyber access program selection (#40687)

2026-08-25 19:54:52 +00:00

cyber_exec_policy.rs

Standardize shell execution on unified exec (#39772)

2026-08-20 18:29:35 +00:00

daybreak_access.rs

Attach verified access context to eligible plugin MCP calls (#41005)

2026-08-27 00:02:26 +00:00

deprecation_notice.rs

Standardize shell execution on unified exec (#39772)

2026-08-20 18:29:35 +00:00

exec_policy.rs

Honor environment-resolved workspace roots (#40912)

2026-08-26 16:28:35 +00:00

exec.rs

Add network environment ID plumbing (#28766)

2026-06-18 14:09:38 +02:00

extension_sandbox.rs

Preserve filesystem permission path conventions (#39084)

2026-08-17 21:49:30 +00:00

external_auth.rs

Surface model provider authentication recovery progress (#41239)

2026-08-28 01:14:02 +00:00

fork_thread.rs

Separate thread settings from environment configuration (#39597)

2026-08-20 05:29:12 +00:00

git_enrichment.rs

Sanitize credentials from Git remote metadata (#40713)

2026-08-25 21:34:05 +00:00

guardian_mcp_elicitation.rs

Require synchronous review for sensitive MCP actions (#41094)

2026-08-27 08:44:54 +00:00

guardian_review_cancellation.rs

Cancel Guardian reviews with their tool calls (#40021)

2026-08-21 21:51:12 +00:00

guardian_review.rs

Roll over Guardian context before follow-up reviews (#41215)

2026-08-27 22:28:46 +00:00

guardian_subagent_authorization.rs

Reuse Guardian reviews in async risk scoring (#40013)

2026-08-21 21:22:35 +00:00

hooks_executor.rs

Honor environment-resolved workspace roots (#40912)

2026-08-26 16:28:35 +00:00

hooks_mcp.rs

Preserve MCP tool output as content items (#40737)

2026-08-25 23:42:50 +00:00

hooks.rs

Standardize shell execution on unified exec (#39772)

2026-08-20 18:29:35 +00:00

image_rollout.rs

Annotate user input and contextual fragments with content kinds (#40196)

2026-08-23 06:10:44 +00:00

injected_models_cache.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

interrupt_hooks.rs

Add hooks for interrupted turns (#40511)

2026-08-25 01:27:18 +00:00

items.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

json_result.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

live_cli.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

mcp_auth_elicitation.rs

Preserve MCP tool output as content items (#40737)

2026-08-25 23:42:50 +00:00

mcp_auth_refresh.rs

Attach verified access context to eligible plugin MCP calls (#41005)

2026-08-27 00:02:26 +00:00

mcp_optional_startup_grace.rs

Make the optional MCP startup grace configurable (#41199)

2026-08-27 20:31:40 +00:00

mcp_refresh_cleanup.rs

Negotiate MCP extensions per app-server session (#36910)

2026-08-04 15:23:43 +00:00

mcp_startup_refresh_http_proxy.rs

Honor environment-resolved workspace roots (#40912)

2026-08-26 16:28:35 +00:00

mcp_tool_cache.rs

Preserve MCP tool output as content items (#40737)

2026-08-25 23:42:50 +00:00

mcp_tool_exposure.rs

Honor environment-resolved workspace roots (#40912)

2026-08-26 16:28:35 +00:00

mcp_turn_metadata.rs

Include originating item IDs in MCP request metadata (#40866)

2026-08-26 10:39:05 +00:00

mod.rs

Review terminal input against retained permissions (#41328)

2026-08-28 11:38:03 +00:00

model_overrides.rs

[5 of 7] Replace OverrideTurnContext with ThreadSettings (#22508)

2026-05-18 21:03:51 -07:00

model_runtime_selectors.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

model_switching.rs

Make Ultra reasoning fallback model-aware (#41206)

2026-08-27 21:03:09 +00:00

model_visible_layout.rs

Scope extension capabilities to invocation lifetimes (#41020)

2026-08-27 02:00:31 +00:00

models_cache_ttl.rs

Make Ultra reasoning fallback model-aware (#41206)

2026-08-27 21:03:09 +00:00

models_etag_responses.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

multi_agent_mode.rs

Make Ultra reasoning fallback model-aware (#41206)

2026-08-27 21:03:09 +00:00

multi_agent_resume.rs

Wait for turn completion events in multi-agent resume tests (#39702)

2026-08-20 11:57:32 +00:00

multi_exec_server_sandbox.rs

Attach verified access context to eligible plugin MCP calls (#41005)

2026-08-27 00:02:26 +00:00

network_approval.rs

Require approval for input to escalated terminals (#40978)

2026-08-26 21:39:05 +00:00

openai_file_mcp.rs

Preserve MCP tool output as content items (#40737)

2026-08-25 23:42:50 +00:00

otel.rs

Make tool-result telemetry limits configurable (#39779)

2026-08-20 19:09:04 +00:00

override_updates.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

pending_input.rs

Support standalone function outputs in turn routing (#40991)

2026-08-26 22:48:37 +00:00

permissions_messages.rs

Forward model confirmation policies to actor MCP tools (#41072)

2026-08-27 06:58:07 +00:00

personality.rs

Make Ultra reasoning fallback model-aware (#41206)

2026-08-27 21:03:09 +00:00

plugins.rs

Honor layered configuration when loading plugins (#40954)

2026-08-26 19:02:02 +00:00

prompt_cache_key.rs

Use session IDs for prompt cache keys (#33035)

2026-07-14 10:37:23 +00:00

prompt_caching.rs

Enable unified exec by default on Windows (#38625)

2026-08-14 19:07:15 +00:00

prompt_debug_tests.rs

Enable git attribution across Codex entry points (#34819)

2026-07-22 20:23:35 +00:00

quota_exceeded.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

realtime_conversation.rs

Include thread source in realtime connection metadata (#41250)

2026-08-28 02:39:47 +00:00

realtime_initial_items.rs

Add a realtime delegation acknowledgement control (#36413)

2026-08-01 01:17:26 +00:00

remote_env.rs

Harden core test fixture startup assertions (#41194)

2026-08-27 19:58:09 +00:00

remote_models.rs

Make Ultra reasoning fallback model-aware (#41206)

2026-08-27 21:03:09 +00:00

request_compression.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

request_permissions_tool.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

request_permissions.rs

Standardize shell execution on unified exec (#39772)

2026-08-20 18:29:35 +00:00

request_plugin_install.rs

Include suggestion IDs in plugin install metadata (#39765)

2026-08-20 17:54:42 +00:00

request_user_input.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

responses_api_proxy_headers.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

responses_lite.rs

Give Responses Lite prefix items stable IDs (#40962)

2026-08-26 19:44:12 +00:00

responses_system_proxy.rs

Migrate login HTTP construction to HttpClient (#34643)

2026-07-22 00:50:28 +00:00

resume_warning.rs

Add per-turn cyber access program selection (#40687)

2026-08-25 19:54:52 +00:00

resume.rs

Use turn environment settings for sandbox execution (#40771)

2026-08-26 03:28:57 +00:00

retry_after.rs

Decouple HTTP retry backoff from overload integration testing (#41313)

2026-08-28 10:39:10 +00:00

review.rs

Enable clock tools for persistent reasoning turns (#40942)

2026-08-26 18:06:12 +00:00

rmcp_client.rs

Make Ultra reasoning fallback model-aware (#41206)

2026-08-27 21:03:09 +00:00

rollout_budget.rs

Annotate user input and contextual fragments with content kinds (#40196)

2026-08-23 06:10:44 +00:00

rollout_list_find.rs

Honor the configured SQLite home across state consumers (#34994)

2026-07-23 19:19:35 +00:00

safety_buffering.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

safety_check_downgrade.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

search_tool.rs

Scope extension capabilities to invocation lifetimes (#41020)

2026-08-27 02:00:31 +00:00

send_user_message_async.rs

Add developer instructions for persistent mode (#41050)

2026-08-27 04:58:21 +00:00

settings_commits.rs

Keep settings operations bound to their committed snapshot (#40645)

2026-08-25 17:20:37 +00:00

settings_constraints.rs

Validate step settings against proposed permissions (#40647)

2026-08-25 17:27:04 +00:00

shell_snapshot.rs

Add in-memory shell snapshots to unified exec (#39957)

2026-08-21 15:24:56 +00:00

skill_approval.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

skills_extension.rs

Scope extension capabilities to invocation lifetimes (#41020)

2026-08-27 02:00:31 +00:00

skills.rs

Reduce skill catalog prompts with path aliases (#41011)

2026-08-27 01:22:23 +00:00

spawn_agent_description.rs

Make Ultra reasoning fallback model-aware (#41206)

2026-08-27 21:03:09 +00:00

sqlite_state.rs

Track window and fork positions in turn metadata (#40987)

2026-08-26 22:37:59 +00:00

step_settings_snapshots.rs

Snapshot resolved settings for each model step (#40651)

2026-08-25 17:41:22 +00:00

step_settings.rs

Resolve token budgets from each step's active model (#41162)

2026-08-27 15:01:22 +00:00

stream_error_allows_next_turn.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

stream_no_completed.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

subagent_notifications.rs

Make Ultra reasoning fallback model-aware (#41206)

2026-08-27 21:03:09 +00:00

subagent_service_tier.rs

Make subagents follow the root service tier (#41308)

2026-08-28 09:48:13 +00:00

token_budget.rs

Resolve token budgets from each step's active model (#41162)

2026-08-27 15:01:22 +00:00

tool_harness.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

tool_lifecycle.rs

Let extensions process MCP tool results (#41202)

2026-08-27 20:39:39 +00:00

tool_parallelism.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

tools.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

truncation.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

turn_input_submission.rs

Add per-turn cyber access program selection (#40687)

2026-08-25 19:54:52 +00:00

turn_state.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

unified_exec_process_events.rs

Harden core test fixture startup assertions (#41194)

2026-08-27 19:58:09 +00:00

unified_exec_stdin_approval.rs

Review terminal input against retained permissions (#41328)

2026-08-28 11:38:03 +00:00

unified_exec_stdin_review_size.rs

Reject oversized reviewed terminal input (#41159)

2026-08-27 14:54:13 +00:00

unified_exec_zsh_fork_approvals.rs

Require approval for input to escalated terminals (#40978)

2026-08-26 21:39:05 +00:00

unified_exec.rs

Require approval for input to escalated terminals (#40978)

2026-08-26 21:39:05 +00:00

unstable_features_warning.rs

Extract persisted history types into a dedicated crate (#37871)

2026-08-10 19:26:52 +00:00

user_notification.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

user_shell_cmd.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

view_image.rs

Make Ultra reasoning fallback model-aware (#41206)

2026-08-27 21:03:09 +00:00

web_search.rs

Add an Amazon Bedrock Runtime provider (#38470)

2026-08-14 01:23:59 +00:00

websocket_fallback.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

window_headers.rs

Track window and fork positions in turn metadata (#40987)

2026-08-26 22:37:59 +00:00

windows_sandbox.rs

Preserve Windows root reads with deny-read rules (#40441)

2026-08-24 17:29:21 +00:00

workspace_roots.rs

Honor environment-resolved workspace roots (#40912)

2026-08-26 16:28:35 +00:00

worktree_trust.rs

Validate linked worktrees before inheriting project trust (#39616)

2026-08-20 06:29:32 +00:00