mirror of
https://github.com/openai/codex.git
synced 2026-10-29 19:08:43 +00:00
yansenzhou-oai
26ad281fd1
## What changed `review/start` now supports only inline reviews on the supplied thread and returns that thread's id as `reviewThreadId`. Clients can omit `delivery`, send `null`, or specify `"inline"`; `"detached"` is no longer supported. For a separate review thread, call `thread/start` followed by `review/start`. To preserve conversation history with custom review instructions, use `thread/fork` followed by `turn/start`. Remove detached review execution and its app-server dependency on `codex-agent-extension`, and update the protocol schemas and generated clients. Preserve `ReviewDelivery.inline` as a Python enum member. ## Testing Add a Python regression test verifying that inline review delivery parses as `ReviewDelivery.inline` and round-trips to the original JSON. GitOrigin-RevId: ed16c5271c3315ae3afcb3ee78883ed421394b4d
128 lines
3.1 KiB
JSON
Generated
128 lines
3.1 KiB
JSON
Generated
{
|
|
"$schema": "http://json-schema.org/draft-07/schema#",
|
|
"definitions": {
|
|
"ReviewDelivery": {
|
|
"enum": [
|
|
"inline"
|
|
],
|
|
"type": "string"
|
|
},
|
|
"ReviewTarget": {
|
|
"oneOf": [
|
|
{
|
|
"description": "Review the working tree: staged, unstaged, and untracked files.",
|
|
"properties": {
|
|
"type": {
|
|
"enum": [
|
|
"uncommittedChanges"
|
|
],
|
|
"title": "UncommittedChangesReviewTargetType",
|
|
"type": "string"
|
|
}
|
|
},
|
|
"required": [
|
|
"type"
|
|
],
|
|
"title": "UncommittedChangesReviewTarget",
|
|
"type": "object"
|
|
},
|
|
{
|
|
"description": "Review changes between the current branch and the given base branch.",
|
|
"properties": {
|
|
"branch": {
|
|
"type": "string"
|
|
},
|
|
"type": {
|
|
"enum": [
|
|
"baseBranch"
|
|
],
|
|
"title": "BaseBranchReviewTargetType",
|
|
"type": "string"
|
|
}
|
|
},
|
|
"required": [
|
|
"branch",
|
|
"type"
|
|
],
|
|
"title": "BaseBranchReviewTarget",
|
|
"type": "object"
|
|
},
|
|
{
|
|
"description": "Review the changes introduced by a specific commit.",
|
|
"properties": {
|
|
"sha": {
|
|
"type": "string"
|
|
},
|
|
"title": {
|
|
"description": "Optional human-readable label (e.g., commit subject) for UIs.",
|
|
"type": [
|
|
"string",
|
|
"null"
|
|
]
|
|
},
|
|
"type": {
|
|
"enum": [
|
|
"commit"
|
|
],
|
|
"title": "CommitReviewTargetType",
|
|
"type": "string"
|
|
}
|
|
},
|
|
"required": [
|
|
"sha",
|
|
"type"
|
|
],
|
|
"title": "CommitReviewTarget",
|
|
"type": "object"
|
|
},
|
|
{
|
|
"description": "Arbitrary instructions, equivalent to the old free-form prompt.",
|
|
"properties": {
|
|
"instructions": {
|
|
"type": "string"
|
|
},
|
|
"type": {
|
|
"enum": [
|
|
"custom"
|
|
],
|
|
"title": "CustomReviewTargetType",
|
|
"type": "string"
|
|
}
|
|
},
|
|
"required": [
|
|
"instructions",
|
|
"type"
|
|
],
|
|
"title": "CustomReviewTarget",
|
|
"type": "object"
|
|
}
|
|
]
|
|
}
|
|
},
|
|
"properties": {
|
|
"delivery": {
|
|
"anyOf": [
|
|
{
|
|
"$ref": "#/definitions/ReviewDelivery"
|
|
},
|
|
{
|
|
"type": "null"
|
|
}
|
|
],
|
|
"default": null,
|
|
"description": "Reviews run inline on the supplied thread. Omit this field or pass `inline`. To review on a separate thread, start a thread first and use its id."
|
|
},
|
|
"target": {
|
|
"$ref": "#/definitions/ReviewTarget"
|
|
},
|
|
"threadId": {
|
|
"type": "string"
|
|
}
|
|
},
|
|
"required": [
|
|
"target",
|
|
"threadId"
|
|
],
|
|
"title": "ReviewStartParams",
|
|
"type": "object"
|
|
} |