Files
codex/codex-rs/rmcp-client/src/streamable_http_retry_tests.rs
T
yitaoh-oai 4360c5f813 Remove model-selected Search MCP routing (#62808)
## What changed

Use the turn's effective `web_search` mode for standalone and hosted
web search. Remove model-selected Search MCP discovery, fallback, and
provider tracking across thread resumes.

Remove `web_search_provider` from model metadata, the
`tools.client_search_provider` hint from configuration, and the
`hosted_search_policy` feature flag. Update the app-server schemas and
generated SDK types to match.

GitOrigin-RevId: 59e3371f4a43d532a484db52d5998f6770292028
2026-11-20 17:46:32 +00:00

122 lines
4.5 KiB
Rust

use std::any::TypeId;
use codex_exec_server::ExecServerError;
use pretty_assertions::assert_eq;
use rmcp::transport::DynamicTransportError;
use rmcp::transport::streamable_http_client::AuthRequiredError;
use rmcp::transport::streamable_http_client::StreamableHttpError;
use crate::http_client_adapter::StreamableHttpClientAdapterError;
use crate::rmcp_client::ClientOperationError;
use super::*;
#[test]
fn retryable_initialize_error_includes_discovery_and_initialized_notification_context() {
let contexts = [
"send discover request",
"send initialize request",
"send initialized notification",
"receive initialize response",
];
assert_eq!(
contexts.map(|context| {
RmcpClient::is_retryable_client_initialize_error(&retryable_initialize_error(context))
}),
[true, true, true, false],
);
}
#[test]
fn streamable_http_retry_classifies_transport_and_auth_errors() {
let errors = [
StreamableHttpError::Client(StreamableHttpClientAdapterError::HttpRequest(
ExecServerError::RequestNotSent("enterprise policy is updating".to_string()),
)),
StreamableHttpError::Client(StreamableHttpClientAdapterError::HttpRequest(
ExecServerError::HttpRequest("error sending request for url".to_string()),
)),
StreamableHttpError::Client(StreamableHttpClientAdapterError::HttpRequest(
ExecServerError::Server {
code: JSON_RPC_INTERNAL_ERROR_CODE,
message: "http/request failed: error sending request for url".to_string(),
},
)),
StreamableHttpError::Client(StreamableHttpClientAdapterError::HttpRequest(
ExecServerError::Protocol(
"http response stream `http-1` failed: exec-server transport disconnected"
.to_string(),
),
)),
StreamableHttpError::Client(StreamableHttpClientAdapterError::HttpRequest(
ExecServerError::Protocol(
"http response stream `http-1` received seq 2, expected 1".to_string(),
),
)),
StreamableHttpError::UnexpectedServerResponse("HTTP 502: upstream failure".into()),
StreamableHttpError::UnexpectedServerResponse("HTTP 400: bad request".into()),
StreamableHttpError::Client(StreamableHttpClientAdapterError::Auth(
codex_api::AuthError::Transient("credential refresh unavailable".to_string()),
)),
StreamableHttpError::Client(StreamableHttpClientAdapterError::Auth(
codex_api::AuthError::Build("invalid authentication".to_string()),
)),
StreamableHttpError::Client(StreamableHttpClientAdapterError::Auth(
codex_api::AuthError::Policy(codex_http_client::NetworkPolicyDenied::Revoked),
)),
];
assert_eq!(
errors.map(|error| RmcpClient::is_retryable_streamable_http_error(&error)),
[
false, true, true, true, false, true, false, true, false, false
],
);
}
#[test]
fn startup_http_authentication_challenges_require_reauthorization() {
let transport_error = || {
DynamicTransportError::from_parts(
"streamable_http",
TypeId::of::<()>(),
Box::new(
StreamableHttpError::<StreamableHttpClientAdapterError>::AuthRequired(
AuthRequiredError::new("Bearer error=\"invalid_token\"".to_string()),
),
),
)
};
let errors = [
anyhow::Error::new(rmcp::service::ClientInitializeError::TransportError {
error: transport_error(),
context: "send initialize request".into(),
}),
anyhow::Error::new(ClientOperationError::from(
rmcp::service::ServiceError::TransportSend(transport_error()),
)),
];
for error in errors {
assert!(crate::startup_error::is_authentication_required_error(
&error
));
}
}
fn retryable_initialize_error(context: &'static str) -> rmcp::service::ClientInitializeError {
rmcp::service::ClientInitializeError::TransportError {
error: DynamicTransportError::from_parts(
"streamable_http",
TypeId::of::<()>(),
Box::new(StreamableHttpError::Client(
StreamableHttpClientAdapterError::HttpRequest(ExecServerError::HttpRequest(
"error sending request for url".to_string(),
)),
)),
),
context: context.into(),
}
}