ioanbudea-OAI c141c31323 Preserve requested approval reviewers across policy overrides (#59272) ...

## Why

A model requirement can force `auto_review` even when the requested reviewer is `user`. Persisting or sending that effective value back as an explicit choice loses the original selection, so removing the requirement cannot restore it on resume.

## What changed

- Retain `requested_approvals_reviewer` separately from the effective reviewer in configuration and thread settings, with a fallback for older histories.
- Restore the requested reviewer on resume while applying current model requirements and reviewer allowlists.
- Let ordinary TUI turns, continuations, retries, and forks inherit the server's reviewer instead of echoing its effective value as an explicit request.
- Preserve a worker's requested reviewer when reloading it rather than inheriting the sender's selection.

## Testing

Extend resume coverage for explicit `auto_review`, removal of a model requirement, and a tightened reviewer allowlist. Update TUI assertions for omitted reviewer overrides and verify worker reload preserves its reviewer.

GitOrigin-RevId: d8c9c3a7b89e55e63f0e8ae210d6a87cb5547933

2026-11-04 00:31:24 +00:00

..

mcp_resource

Use PathUri for skill identity and path matching (#51482)

2026-10-06 21:29:35 +00:00

snapshots

Add a feature-gated account check for CLI thread resume (#58890)

2026-11-02 13:51:49 +00:00

account_enterprise_tests.rs

Preserve safe enterprise MCP authentication error details (#56153)

2026-10-22 11:51:23 +00:00

account_gcp.rs

Show the selected ChatGPT workspace in /status (#57366)

2026-10-27 05:22:23 +00:00

account_system_proxy_tests.rs

Apply shared network policy throughout embedded Codex startup (#47411)

2026-09-23 00:49:19 +00:00

account_thread_usage.rs

Show native dollar thread usage for ENT26 plans (#57251)

2026-10-26 20:54:35 +00:00

account_workspace_switching.rs

Add experimental ChatGPT workspace switching to app-server (#57514)

2026-10-27 17:04:16 +00:00

account.rs

Add experimental ChatGPT workspace switching to app-server (#57514)

2026-10-27 17:04:16 +00:00

agent_message_board.rs

Align message-board tools with the multi-agent namespace (#47028)

2026-09-21 13:27:39 +00:00

analytics.rs

Expose assistant content token counts in completion notifications (#59041)

2026-11-03 02:26:29 +00:00

app_installed.rs

Add support for Academic Researchers plans (#55387)

2026-10-19 21:43:19 +00:00

app_list.rs

Upgrade rmcp to 3.5.1 and harden lifecycle tests (#52972)

2026-10-10 19:43:24 +00:00

app_read.rs

Preserve account network policy for ChatGPT backend requests (#47703)

2026-09-24 00:50:02 +00:00

application_network.rs

Enforce application network policy across app-server requests (#47407)

2026-09-23 00:47:07 +00:00

attached_thread_tests.rs

Keep parent history out of attached thread views (#57256)

2026-10-26 21:07:36 +00:00

attestation.rs

Add managed command checkpoints requiring fresh human approval (#58045)

2026-10-29 11:23:51 +00:00

auth_storage_originator_tests.rs

Track credential storage outcomes and redact sensitive errors (#49384)

2026-09-29 22:24:09 +00:00

auto_env.rs

test: add delayed exec-server transport (#31427)

2026-07-09 00:17:38 +00:00

bedrock_gov_cloud_tests.rs

Add an advisory Bedrock GovCloud requirements check (#49817)

2026-10-01 02:06:05 +00:00

bedrock_service_tier_tests.rs

Advertise Ultrafast for GPT-6.1 Sol on Amazon Bedrock (#51794)

2026-10-07 18:32:50 +00:00

bedrock_setup.rs

Fix model selection after provider setup (#58945)

2026-11-02 18:42:19 +00:00

client_metadata.rs

Add Responses API client metadata patches for turn start and steer (#54053)

2026-10-14 17:39:43 +00:00

code_mode_host.rs

Finish idle thread unloads after slow shutdown (#51420)

2026-10-06 17:10:19 +00:00

collaboration_mode_list.rs

test: migrate TestAppServer callers to builder (#31451)

2026-07-08 00:15:49 +00:00

command_exec.rs

Make apply_patch preserve line endings unconditionally (#51203)

2026-10-05 23:52:06 +00:00

compaction.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

config_model_provider_requirements_tests.rs

Enforce managed model provider selection and definitions (#44650)

2026-09-10 21:41:39 +00:00

config_requirements_application.rs

Support managed network requirements under permissions.network (#58182)

2026-10-29 22:36:06 +00:00

config_requirements_browser_use_tests.rs

Enforce Fast and Ultra Fast policies independently (#51253)

2026-10-06 03:35:55 +00:00

config_requirements_desktop.rs

Add managed Desktop workspace storage requirements (#55965)

2026-10-21 19:06:57 +00:00

config_requirements_exec_tests.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

config_requirements_in_app_browser.rs

Enforce Fast and Ultra Fast policies independently (#51253)

2026-10-06 03:35:55 +00:00

config_requirements_login.rs

Enforce Fast and Ultra Fast policies independently (#51253)

2026-10-06 03:35:55 +00:00

config_rpc.rs

Support app settings in plugin configuration (#58428)

2026-10-30 20:39:47 +00:00

config_server_tests.rs

Route standalone web search through the thread's workspace context (#58140)

2026-10-29 18:09:55 +00:00

connection_handling_stdio_tests.rs

Bound app-server stdio shutdown and handle Unix SIGTERM gracefully (#44523)

2026-09-10 13:02:57 +00:00

connection_handling_websocket_compression_tests.rs

Gate app-server WebSocket compression behind a feature flag (#54949)

2026-10-17 23:34:04 +00:00

connection_handling_websocket_unix.rs

Explain session creation failures during server shutdown (#52721)

2026-10-09 23:16:46 +00:00

connection_handling_websocket.rs

Broadcast thread section changes to connected clients (#58380)

2026-10-30 16:09:46 +00:00

critical_path_analytics_tests.rs

Report auto-review overhead in turn critical-path analytics (#59260)

2026-11-03 23:49:01 +00:00

curated_mcp_sync.rs

Use descriptor-safe helpers for executable test fixtures (#50018)

2026-10-01 15:57:03 +00:00

current_time.rs

Tag current time reminders in model context (#38443)

2026-08-13 21:53:52 +00:00

cyber_access_program.rs

Decouple API-key cyber access programs from model discovery (#49714)

2026-09-30 19:21:02 +00:00

daemon_update_recovery.rs

Add managed command checkpoints requiring fresh human approval (#58045)

2026-10-29 11:23:51 +00:00

daybreak_access.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

dynamic_tools.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

environment_add.rs

Defer environment disconnect notifications until recovery fails (#55401)

2026-10-19 22:55:42 +00:00

environment_info.rs

Support request IDs in exec-server WebSocket handshakes (#52234)

2026-10-08 19:13:52 +00:00

environment_status.rs

Support request IDs in exec-server WebSocket handshakes (#52234)

2026-10-08 19:13:52 +00:00

exec_server_test_support.rs

[app-server] expose environment info RPC (#30291)

2026-06-27 19:34:10 +00:00

executor_mcp.rs

Upgrade rmcp to 3.5.1 and harden lifecycle tests (#52972)

2026-10-10 19:43:24 +00:00

executor_skills_spawn_tests.rs

Preserve subagent capabilities independently of forked history (#52241)

2026-10-08 19:21:57 +00:00

executor_skills.rs

Suppress warnings when skill descriptions are shortened (#46070)

2026-09-17 01:28:24 +00:00

experimental_api.rs

Add managed command checkpoints requiring fresh human approval (#58045)

2026-10-29 11:23:51 +00:00

experimental_feature_list.rs

Keep global app-server config independent of the launch directory (#51872)

2026-10-07 23:19:26 +00:00

external_agent_config.rs

Scope local history discovery to the current ChatGPT account (#58918)

2026-11-02 16:00:20 +00:00

external_agent_import_sync.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

external_agent_memory_concurrency.rs

Prevent memory imports from racing with consolidation (#56462)

2026-10-23 12:23:10 +00:00

feedback.rs

Include directly attached threads in diagnostic uploads (#57824)

2026-10-28 20:21:30 +00:00

frozen_cloud_skills.rs

Add frozen cloud skill snapshots to the app server (#55631)

2026-10-20 17:01:52 +00:00

fs.rs

test: migrate TestAppServer callers to builder (#31451)

2026-07-08 00:15:49 +00:00

gateway_oauth_tests.rs

Add file-backed storage for gateway OAuth credentials (#58219)

2026-10-30 02:28:51 +00:00

gcp_setup_tests.rs

Fix model selection after provider setup (#58945)

2026-11-02 18:42:19 +00:00

git_attribution.rs

Remove the deprecated thread/rollback API (#44915)

2026-09-11 21:32:04 +00:00

guardian_action_budget_tests.rs

Preserve complete actions in Guardian approval reviews (#44569)

2026-09-10 16:01:02 +00:00

guardian_code_mode_tests.rs

Make Code Mode wrappers transparent to Guardian model policies (#45915)

2026-09-16 10:11:26 +00:00

guardian_goal_tests.rs

Test goal provenance in existing workers' Guardian reviews (#57430)

2026-10-27 11:05:48 +00:00

guardian_pending_score_tests.rs

Use conversations for all Guardian v2 async classification (#56556)

2026-10-23 18:48:10 +00:00

guardian_policy_tests.rs

Scope model catalog caches to the current provider and auth identity (#43906)

2026-09-08 20:37:30 +00:00

guardian_stateful_async_tests.rs

Use conversations for all Guardian v2 async classification (#56556)

2026-10-23 18:48:10 +00:00

guardian_sync_session_tests.rs

Add experimental Guardian review for injected thread commands (#58119)

2026-10-29 16:30:06 +00:00

guardian_v2_history_tests.rs

Preserve independent Guardian history across parent compaction (#48779)

2026-09-27 20:15:23 +00:00

guardian_v2_model_tests.rs

Use conversations for all Guardian v2 async classification (#56556)

2026-10-23 18:48:10 +00:00

guardian_v2.rs

Preserve full MCP results in rollout traces (#57280)

2026-10-26 21:56:23 +00:00

history_notes_extension.rs

Track content provenance through prompt assembly and compaction (#53831)

2026-10-14 02:01:49 +00:00

hooks_list.rs

Include environment hooks in thread hook listings (#56553)

2026-10-23 18:39:28 +00:00

host_skills.rs

Refresh host skill catalogs through world state (#33425)

2026-07-15 20:59:21 +00:00

https_mock.rs

Route standalone web search through the thread's workspace context (#58140)

2026-10-29 18:09:55 +00:00

imagegen_extension.rs

Add optional animated GIF output to image generation (#59073)

2026-11-03 06:24:24 +00:00

initialize.rs

Add managed command checkpoints requiring fresh human approval (#58045)

2026-10-29 11:23:51 +00:00

luna_reserve.rs

Extend rate limit reads with usage capabilities (#42358)

2026-09-02 21:01:04 +00:00

marketplace_add.rs

Handle @ in local marketplace paths (#34959)

2026-07-23 15:32:36 +00:00

marketplace_remove.rs

Keep global app-server config independent of the launch directory (#51872)

2026-10-07 23:19:26 +00:00

marketplace_upgrade.rs

Clean up failed and abandoned marketplace staging directories (#55689)

2026-10-20 22:25:54 +00:00

mcp_connection_sharing.rs

Add per-chat leases for shared MCP connections (#57978)

2026-10-29 03:47:52 +00:00

mcp_event_stream.rs

Add app-server MCP event streaming (#39761)

2026-08-20 17:49:35 +00:00

mcp_protocol_default.rs

Give hosted Codex Apps an independent MCP protocol opt-in (#44318)

2026-09-09 22:22:08 +00:00

mcp_resource_origin.rs

Add explicit app and account targets to MCP resource reads (#47248)

2026-09-22 10:42:50 +00:00

mcp_resource.rs

Validate thread providers before resume and input (#57840)

2026-10-28 21:33:02 +00:00

mcp_server_elicitation.rs

Add managed command checkpoints requiring fresh human approval (#58045)

2026-10-29 11:23:51 +00:00

mcp_server_status.rs

Skip resource template discovery for hosted Apps (#57861)

2026-10-28 23:21:04 +00:00

mcp_tool.rs

Add managed command checkpoints requiring fresh human approval (#58045)

2026-10-29 11:23:51 +00:00

memory_read.rs

Add experimental thread memory summary reads (#56465)

2026-10-23 12:35:58 +00:00

memory_reset.rs

Support memory v2 in external-agent memory imports (#56414)

2026-10-23 09:06:13 +00:00

misalignment_policy.rs

Preserve review targets and scope misalignment continuation metadata (#51217)

2026-10-06 01:26:11 +00:00

mod.rs

Add model provider configuration writes to the app-server (#58876)

2026-11-02 12:22:22 +00:00

model_auto_review.rs

Restore permission profiles when resuming threads (#39153)

2026-08-18 06:22:04 +00:00

model_list_requirements_tests.rs

Add model provider configuration writes to the app-server (#58876)

2026-11-02 12:22:22 +00:00

model_list.rs

Reload the model catalog after account changes (#54169)

2026-10-15 03:06:16 +00:00

model_provider_capabilities_read.rs

Remove the provider capability gate for tool namespaces (#50447)

2026-10-02 22:55:08 +00:00

model_provider_config_tests.rs

Add model provider configuration writes to the app-server (#58876)

2026-11-02 12:22:22 +00:00

model_provider_enforcement_tests.rs

Add experimental Guardian review for injected thread commands (#58119)

2026-10-29 16:30:06 +00:00

model_provider_list_tests.rs

Add model provider discovery to the app server (#58845)

2026-11-02 08:31:14 +00:00

multi_agent_v2_developer_instructions.rs

Preserve parent history by default in full agent forks (#55548)

2026-10-20 11:56:17 +00:00

otel.rs

Fix trace exporter activation after account switches (#57657)

2026-10-28 06:22:58 +00:00

output_schema.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

permission_profile_list.rs

Resolve permission profiles with explicit execution-host path context (#44676)

2026-09-11 00:03:40 +00:00

plan_item.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

plugin_install.rs

Keep remote plugin bundle URLs out of diagnostics (#58165)

2026-10-29 19:49:03 +00:00

plugin_list.rs

Allow disabling plugin discovery prefetch at app-server startup (#57249)

2026-10-26 20:54:08 +00:00

plugin_manifest_cache.rs

Cache parsed plugin manifests across plugin workflows (#49099)

2026-09-28 23:32:45 +00:00

plugin_read.rs

Add configurable default plugin activation policy (#52220)

2026-10-08 18:42:58 +00:00

plugin_reconcile.rs

Record active plugin inventory in turn analytics (#46323)

2026-09-17 23:47:06 +00:00

plugin_search.rs

Replace Sites migration state with a runtime compatibility guard (#46108)

2026-09-17 04:23:45 +00:00

plugin_share.rs

Remove plugin extension metadata from discovery and summaries (#48035)

2026-09-25 08:25:37 +00:00

plugin_uninstall.rs

Run plugin app-server tests in automatic environments (#38189)

2026-08-12 13:33:01 +00:00

process_exec.rs

Preserve process output and control replies under backpressure (#57569)

2026-10-27 21:51:50 +00:00

projects.rs

Scope local history discovery to the current ChatGPT account (#58918)

2026-11-02 16:00:20 +00:00

rate_limit_reset_credits.rs

Expose selected workspace routing in app-server account reads (#45529)

2026-09-14 22:31:32 +00:00

rate_limits_identity_tests.rs

Enforce application network policy across app-server requests (#47407)

2026-09-23 00:47:07 +00:00

rate_limits.rs

Add support for Academic Researchers plans (#55387)

2026-10-19 21:43:19 +00:00

realtime_conversation.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

realtime_transcript_tests.rs

Preserve realtime V3 transcripts in conversation history (#58221)

2026-10-30 02:43:02 +00:00

recommended_plugins.rs

Wait for login completion in recommended plugin tests (#47828)

2026-09-24 12:26:05 +00:00

remote_control_auth.rs

Enforce application network policy across app-server requests (#47407)

2026-09-23 00:47:07 +00:00

remote_control.rs

Persist remote-control RPC preferences in managed daemon settings (#52304)

2026-10-08 22:42:12 +00:00

remote_thread_store.rs

Scope local history discovery to the current ChatGPT account (#58918)

2026-11-02 16:00:20 +00:00

request_permissions.rs

Bind permission grants to the originating turn (#49880)

2026-10-01 05:33:36 +00:00

request_user_input.rs

Retire the untrusted approval policy (#39630)

2026-08-20 07:03:02 +00:00

request_validation.rs

Refactor image content to use a shared ImageReference type (#45543)

2026-09-14 23:25:09 +00:00

residency.rs

Scope model catalog caches to the current provider and auth identity (#43906)

2026-09-08 20:37:30 +00:00

review.rs

Remove detached delivery from review/start (#57667)

2026-10-28 07:12:32 +00:00

rollout_compress_tests.rs

Fix session lookup and resume after rollout compression (#54008)

2026-10-14 15:22:02 +00:00

rollout_migration.rs

Expose experimental durable thread read state in the app server (#52350)

2026-10-09 01:22:30 +00:00

safety_check_downgrade.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

selected_capability_stack.rs

Restrict capability roots to captured turn environments (#49280)

2026-09-29 15:10:17 +00:00

selected_environment.rs

Harden unsandboxed patch filesystem access (#39659)

2026-08-20 08:10:08 +00:00

server_diagnostics.rs

Keep app-server thread RPCs active until delegated work completes (#43950)

2026-09-09 00:25:02 +00:00

session_end.rs

Bound app-server stdio shutdown and handle Unix SIGTERM gracefully (#44523)

2026-09-10 13:02:57 +00:00

skills_list.rs

Use PathUri for skill identity and path matching (#51482)

2026-10-06 21:29:35 +00:00

sleep.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

sqlite_recovery.rs

Scope local history discovery to the current ChatGPT account (#58918)

2026-11-02 16:00:20 +00:00

thread_archive.rs

Restore spawned descendants when unarchiving a thread (#57635)

2026-10-28 04:05:31 +00:00

thread_attachments.rs

Add attachment owner lookup to the app-server (#50094)

2026-10-01 20:47:05 +00:00

thread_delete.rs

Delete Guardian evidence boards when permanently deleting threads (#58955)

2026-11-02 19:26:15 +00:00

thread_environments.rs

Expose loaded thread environments in app-server responses (#42386)

2026-09-02 23:41:14 +00:00

thread_fork_multi_agent_tests.rs

Scope model catalog caches to the current provider and auth identity (#43906)

2026-09-08 20:37:30 +00:00

thread_fork.rs

Expose assistant content token counts in completion notifications (#59041)

2026-11-03 02:26:29 +00:00

thread_goal_empty_responses.rs

Include environment hooks in thread hook listings (#56553)

2026-10-23 18:39:28 +00:00

thread_inject_items.rs

Add experimental Guardian review for injected thread commands (#58119)

2026-10-29 16:30:06 +00:00

thread_list.rs

Scope local history discovery to the current ChatGPT account (#58918)

2026-11-02 16:00:20 +00:00

thread_loaded_list.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

thread_memory_mode_set.rs

Honor the configured SQLite home across state consumers (#34994)

2026-07-23 19:19:35 +00:00

thread_metadata_update.rs

Scope local history discovery to the current ChatGPT account (#58918)

2026-11-02 16:00:20 +00:00

thread_name_persistence.rs

Persist empty paginated threads when naming them (#49785)

2026-10-01 00:57:29 +00:00

thread_name_websocket.rs

Restore app-server websocket listener with auth guard (#22404)

2026-05-12 18:40:53 -07:00

thread_queue.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

thread_read_state.rs

Add experimental app-server thread read-state updates (#52395)

2026-10-09 03:42:19 +00:00

thread_read.rs

Expose assistant content token counts in completion notifications (#59041)

2026-11-03 02:26:29 +00:00

thread_resume_account_tests.rs

Add a feature-gated account check for CLI thread resume (#58890)

2026-11-02 13:51:49 +00:00

thread_resume_network_tests.rs

Resolve network approval prompts when their requests end (#58350)

2026-10-30 14:40:32 +00:00

thread_resume.rs

Preserve requested approval reviewers across policy overrides (#59272)

2026-11-04 00:31:24 +00:00

thread_revert.rs

Add managed command checkpoints requiring fresh human approval (#58045)

2026-10-29 11:23:51 +00:00

thread_sample.rs

Allow upstream interruption when canceling Responses Lite turns (#57864)

2026-10-29 00:03:28 +00:00

thread_sections.rs

Broadcast thread section changes to connected clients (#58380)

2026-10-30 16:09:46 +00:00

thread_settings_update.rs

Preserve thread model settings across resume and revert (#55923)

2026-10-21 15:34:43 +00:00

thread_shell_command.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

thread_start.rs

Add GPT-6.1 Terra to model catalogs (#57293)

2026-10-26 22:13:14 +00:00

thread_status.rs

Add managed command checkpoints requiring fresh human approval (#58045)

2026-10-29 11:23:51 +00:00

thread_timeline.rs

Expose assistant content token counts in completion notifications (#59041)

2026-11-03 02:26:29 +00:00

thread_unarchive.rs

Add experimental attached thread forks (#56351)

2026-10-23 04:52:47 +00:00

thread_unload.rs

Bound waits for the thread writer coordination lock (#57360)

2026-10-27 04:52:09 +00:00

thread_unsubscribe.rs

Preserve rollout tracing across sub-agent reloads (#57615)

2026-10-28 01:29:34 +00:00

turn_cost_otel.rs

Apply shared network policy throughout embedded Codex startup (#47411)

2026-09-23 00:49:19 +00:00

turn_interrupt.rs

Avoid cloning turn items for app-server active turn lookups (#46305)

2026-09-17 21:25:34 +00:00

turn_settings_update.rs

Remove retired model entries while preserving migration prompts (#44250)

2026-09-09 17:56:33 +00:00

turn_start.rs

Scope local history discovery to the current ChatGPT account (#58918)

2026-11-02 16:00:20 +00:00

turn_steer.rs

Render untrusted additional context as named tool outputs (#57279)

2026-10-26 21:55:00 +00:00

user_verification_mcp.rs

Upgrade rmcp to 3.5.1 and harden lifecycle tests (#52972)

2026-10-10 19:43:24 +00:00

user_verification.rs

Add cancellation for native user-verification RPCs (#43925)

2026-09-08 21:48:53 +00:00

view_image.rs

Expose lifecycle timestamps on app-server thread items (#57172)

2026-10-26 18:13:00 +00:00

web_search_routing.rs

Return standalone web search failures to the model (#58147)

2026-10-29 18:41:17 +00:00

web_search.rs

Resolve model-selected search providers with policy-aware fallback (#59036)

2026-11-03 02:08:56 +00:00

windows_sandbox_setup.rs

Allow full-access Windows setup to provision through registered Core (#47922)

2026-09-24 19:29:53 +00:00

workspace_routing.rs

Show the selected ChatGPT workspace in /status (#57366)

2026-10-27 05:22:23 +00:00