mirror of
https://github.com/openai/codex.git
synced 2026-10-30 19:18:49 +00:00
Greg Brisebois
4bc746c94f
## What changed Include `tool_name` in MCP tool approval elicitation metadata and forward available `readOnlyHint`, `destructiveHint`, `idempotentHint`, and `openWorldHint` values under `tool_annotations`. Omit unspecified hints and the annotation title. Reuse the stored tool approval metadata when available so annotation hints reach the approval request. ## Testing Extend unit tests to cover tool names, annotation hints, and omission of unspecified hints. Update integration coverage to verify that the approval tool name matches the executed MCP call and that `readOnlyHint` is preserved. GitOrigin-RevId: f082fe7fd87fde9f4895149e09210c7cb9d1e582
43 lines
2.2 KiB
Rust
43 lines
2.2 KiB
Rust
/// Identifies privileged Codex approvals. Changing this key or adding another
|
|
/// privileged discriminator requires updating the MCP elicitation router's
|
|
/// form-forwarding safeguards.
|
|
pub const APPROVAL_KIND_KEY: &str = "codex_approval_kind";
|
|
pub const APPROVAL_KIND_MCP_TOOL_CALL: &str = "mcp_tool_call";
|
|
pub const APPROVAL_KIND_BROWSER_AUTH: &str = "browser_auth";
|
|
pub const APPROVAL_KIND_TOOL_SUGGESTION: &str = "tool_suggestion";
|
|
/// Marks requests that need user input even when their form schema is empty.
|
|
pub const REQUIRES_USER_INPUT_KEY: &str = "codex_requires_user_input";
|
|
pub const REQUEST_TYPE_KEY: &str = "codex_request_type";
|
|
pub const REQUEST_TYPE_APPROVAL_REQUEST: &str = "approval_request";
|
|
pub const STRICT_AUTO_REVIEW_KEY: &str = "codex_strict_auto_review";
|
|
/// Marks a sensitive action requiring synchronous review when routed to automatic review.
|
|
/// Absent or false preserves the existing approval path; this does not opt into review.
|
|
pub const SENSITIVE_ACTION_KEY: &str = "codex_sensitive_action";
|
|
pub const APPROVALS_REVIEWER_KEY: &str = "approvals_reviewer";
|
|
pub const PERSIST_KEY: &str = "persist";
|
|
pub const PERSIST_SESSION: &str = "session";
|
|
pub const PERSIST_ALWAYS: &str = "always";
|
|
/// Set where cancellation originates, before user actions and runtime failures
|
|
/// are flattened into the same elicitation action. Absence means unknown.
|
|
pub const CANCELLATION_REASON_KEY: &str = "codex_approval_cancellation_reason";
|
|
|
|
#[derive(Clone, Copy, Debug, PartialEq, Eq, serde::Serialize, serde::Deserialize)]
|
|
#[serde(rename_all = "snake_case")]
|
|
pub enum McpApprovalCancellationReason {
|
|
User,
|
|
Interrupted,
|
|
NonInteractive,
|
|
}
|
|
|
|
pub const SOURCE_KEY: &str = "source";
|
|
pub const SOURCE_CONNECTOR: &str = "connector";
|
|
pub const CONNECTOR_ID_KEY: &str = "connector_id";
|
|
pub const CONNECTOR_NAME_KEY: &str = "connector_name";
|
|
pub const CONNECTOR_DESCRIPTION_KEY: &str = "connector_description";
|
|
pub const TOOL_NAME_KEY: &str = "tool_name";
|
|
pub const TOOL_ANNOTATIONS_KEY: &str = "tool_annotations";
|
|
pub const TOOL_TITLE_KEY: &str = "tool_title";
|
|
pub const TOOL_DESCRIPTION_KEY: &str = "tool_description";
|
|
pub const TOOL_PARAMS_KEY: &str = "tool_params";
|
|
pub const TOOL_PARAMS_DISPLAY_KEY: &str = "tool_params_display";
|