mirror of
https://github.com/openai/codex.git
synced 2026-10-31 19:28:49 +00:00
Adam Perry @ OpenAI
6fa3bcaae8
## Why Detached work can keep request spans open beyond response enqueueing. Record explicit phase timings to distinguish request handling from the full span lifetime. ## What changed - Record server dispatch and response enqueue offsets from request receipt, plus a response enqueue event for HTTP responses that bypass the dispatcher. - Emit client request enqueue and response receipt events, including success or server-error outcomes and reader-to-caller delay. Carry completion timestamps to the awaiting task so receipt events retain its tracing context. - Add spans for process startup, sandbox preparation, shell snapshot preparation and capture, and process spawning. Record process identifiers only when nonempty and at most 64 bytes long. GitOrigin-RevId: 237db898b3284fe8a6a36cb0055b3c7991d8e8a4
83 lines
3.0 KiB
Rust
83 lines
3.0 KiB
Rust
//! Emits process lifecycle telemetry and bounds process identifiers recorded by tracing.
|
|
//! Lifecycle events retain the identity captured at launch across reconnects and later operations.
|
|
|
|
use std::sync::Arc;
|
|
|
|
use codex_sandboxing::SandboxType;
|
|
use opentelemetry::trace::SpanContext;
|
|
|
|
use crate::telemetry::ExecutorRegistration;
|
|
|
|
/// Log fields captured at launch, never refreshed from a resumed session.
|
|
#[derive(Clone, Default)]
|
|
pub(crate) struct ProcessTelemetry {
|
|
pub(crate) launch_context: Option<SpanContext>,
|
|
pub(crate) thread_id: Option<String>,
|
|
pub(crate) tool_call_id: Option<String>,
|
|
pub(crate) executor_registration: Option<Arc<ExecutorRegistration>>,
|
|
}
|
|
|
|
/// Lifecycle events with outcome fields only when a process has exited.
|
|
pub(crate) enum ProcessTelemetryEvent {
|
|
Start,
|
|
SpawnFailed,
|
|
SandboxDenied,
|
|
Exit {
|
|
exit_code: i32,
|
|
termination_requested: bool,
|
|
},
|
|
}
|
|
|
|
impl ProcessTelemetry {
|
|
pub(crate) fn log(&self, event: ProcessTelemetryEvent, sandbox: SandboxType) {
|
|
let (event_name, exit_code, termination_requested, reason) = match event {
|
|
ProcessTelemetryEvent::Start => ("codex.exec_server.process_start", None, None, None),
|
|
ProcessTelemetryEvent::SpawnFailed => {
|
|
("codex.exec_server.process_spawn_failed", None, None, None)
|
|
}
|
|
ProcessTelemetryEvent::SandboxDenied => (
|
|
"codex.exec_server.sandbox_denied",
|
|
None,
|
|
None,
|
|
Some("inferred_denial"),
|
|
),
|
|
ProcessTelemetryEvent::Exit {
|
|
exit_code,
|
|
termination_requested,
|
|
} => (
|
|
"codex.exec_server.process_exit",
|
|
Some(exit_code),
|
|
Some(termination_requested),
|
|
None,
|
|
),
|
|
};
|
|
let trace_id = self
|
|
.launch_context
|
|
.as_ref()
|
|
.map(|span| span.trace_id().to_string());
|
|
let span_id = self
|
|
.launch_context
|
|
.as_ref()
|
|
.map(|span| span.span_id().to_string());
|
|
tracing::event!(
|
|
target: "codex_otel.log_only",
|
|
tracing::Level::INFO,
|
|
event.name = event_name,
|
|
launch.trace_id = trace_id.as_deref(),
|
|
launch.span_id = span_id.as_deref(),
|
|
conversation.id = self.thread_id.as_deref(),
|
|
tool.call_id = self.tool_call_id.as_deref(),
|
|
executor.environment_id = self.executor_registration.as_ref().map(|registration| registration.environment_id.as_str()),
|
|
executor.registration_id = self.executor_registration.as_ref().map(|registration| registration.executor_registration_id.as_str()),
|
|
sandbox.type = ?sandbox,
|
|
process.exit_code = exit_code,
|
|
process.termination_requested = termination_requested,
|
|
reason,
|
|
);
|
|
}
|
|
}
|
|
|
|
pub(crate) fn trace_process_id(process_id: &str) -> Option<&str> {
|
|
(!process_id.is_empty() && process_id.len() <= 64).then_some(process_id)
|
|
}
|