mirror of
https://github.com/openai/codex.git
synced 2026-11-16 22:00:36 +00:00
## Why MCP servers must forward sandbox policy unchanged to `codex sandbox --sandbox-state-json`, while interpreting launcher information to find the Codex CLI. Keep those contracts separate so consumers can preserve unknown policy fields. ## What changed - Accept the experimental `codex/sandbox-state` capability alongside the deprecated `codex/sandbox-state-meta` capability, and send identical policy values under both `_meta` keys. - Move `codexExecutable` out of the policy into `codex/sandbox-launcher`, supplied only when a verified CLI path is available for a local stdio server. - Replace stale sandbox metadata while retaining unrelated entries, and remove stale launcher metadata when no launcher is available. - Document the metadata contract and how servers should forward policy and retain authority for long-lived subprocesses. ## Testing Update unit and integration coverage for policy serialization, identical state aliases, launcher availability across execution environments, and stale metadata replacement. GitOrigin-RevId: e544c06e6e023953b1fc8069b7b1affa065262d1
63 lines
2.4 KiB
Rust
63 lines
2.4 KiB
Rust
//! Preserve sandbox policy wire semantics while launcher metadata evolves separately.
|
|
|
|
use super::*;
|
|
use pretty_assertions::assert_eq;
|
|
use serde_json::Value;
|
|
|
|
#[test]
|
|
fn sandbox_state_serializes_skip_missing_entries_as_missing_path_behavior() {
|
|
let sandbox_cwd = PathUri::from_host_native_path(
|
|
std::env::current_dir().expect("current directory should be available"),
|
|
)
|
|
.expect("current directory should convert to a URI");
|
|
let sandbox_state = SandboxState {
|
|
permission_profile: PermissionProfile::workspace_write(),
|
|
codex_linux_sandbox_exe: None,
|
|
sandbox_cwd,
|
|
use_legacy_landlock: false,
|
|
use_mxc: false,
|
|
};
|
|
|
|
let serialized = serde_json::to_value(&sandbox_state).expect("serialize sandbox state");
|
|
let serialized_text = serde_json::to_string(&serialized).expect("serialize JSON text");
|
|
assert!(
|
|
!serialized_text.contains("generated_default_path"),
|
|
"MCP sandbox metadata must preserve FileSystemPath's stable wire variants"
|
|
);
|
|
assert!(
|
|
!serialized_text.contains("generated_default_special"),
|
|
"MCP sandbox metadata must preserve FileSystemPath's stable wire variants"
|
|
);
|
|
|
|
let entries = serialized
|
|
.pointer("/permissionProfile/file_system/entries")
|
|
.and_then(Value::as_array)
|
|
.expect("workspace-write profile should contain filesystem entries");
|
|
let skip_missing_entries = entries
|
|
.iter()
|
|
.filter(|entry| entry.get("missing_path_behavior").and_then(Value::as_str) == Some("skip"))
|
|
.collect::<Vec<_>>();
|
|
assert!(
|
|
!skip_missing_entries.is_empty(),
|
|
"skip-missing entries should be represented as optional missing_path_behavior"
|
|
);
|
|
assert!(
|
|
skip_missing_entries.iter().all(|entry| {
|
|
matches!(
|
|
entry.pointer("/path/type").and_then(Value::as_str),
|
|
Some("path" | "special")
|
|
)
|
|
}),
|
|
"skip-missing entries should use the stable path/special variants"
|
|
);
|
|
|
|
let deserialized: SandboxState =
|
|
serde_json::from_value(serialized.clone()).expect("deserialize legacy sandbox state");
|
|
assert_eq!(deserialized, sandbox_state);
|
|
|
|
let mut extended = serialized;
|
|
extended["futureField"] = serde_json::json!({"preservedByOpaqueConsumers": true});
|
|
let deserialized: SandboxState = serde_json::from_value(extended).expect("extended state");
|
|
assert_eq!(deserialized, sandbox_state);
|
|
}
|