mirror of
https://github.com/openai/codex.git
synced 2026-11-12 21:20:34 +00:00
Eric Traut
54b90f98a5
## Why Threads need a visible title while automatic generation is pending or fails. Hidden title-generation requests must also stay out of the foreground conversation, including during skill installation prompts. ## What changed - Immediately display a Markdown-stripped, single-line excerpt of the first message, capped at 60 characters. Replace it with the generated title, or save the excerpt if generation fails or returns an invalid title. - Give title threads explicit read-only permissions and request the `never` approval policy, subject to managed policy constraints. Keep blocking input requests on the hidden thread until timeout. - Interrupt timed-out temporary structured turns before detaching them. ## Testing Add coverage for provisional title replacement, fallback persistence, managed permission and approval policies, and hidden input requests. Add a terminal integration test that verifies title generation after choosing “Continue anyway” on a skill installation prompt. GitOrigin-RevId: f408f3061e5e7f0d9d6bc1f2f9674303e9e68400
92 lines
2.9 KiB
Rust
92 lines
2.9 KiB
Rust
//! Exercises automatic title generation alongside a foreground skill installation prompt.
|
|
|
|
use super::focus_palette::PtyCodex;
|
|
use super::focus_palette::write_test_config;
|
|
use anyhow::Result;
|
|
use core_test_support::responses;
|
|
use std::io::Write;
|
|
use std::time::Duration;
|
|
use std::time::Instant;
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn automatic_title_after_continue_anyway() -> Result<()> {
|
|
core_test_support::skip_if_no_network!(Ok(()));
|
|
let workspace = tempfile::tempdir()?;
|
|
let cwd = workspace.path().canonicalize()?;
|
|
let home = tempfile::tempdir()?;
|
|
write_test_config(home.path(), &cwd)?;
|
|
let skill = home.path().join("skills/ping");
|
|
std::fs::create_dir_all(skill.join("agents"))?;
|
|
std::fs::write(
|
|
skill.join("SKILL.md"),
|
|
"---\nname: ping\ndescription: Ping a service.\n---\nCheck the service.\n",
|
|
)?;
|
|
std::fs::write(
|
|
skill.join("agents/openai.yaml"),
|
|
"dependencies:
|
|
tools:
|
|
- type: mcp
|
|
value: ping
|
|
transport: streamable_http
|
|
url: http://127.0.0.1:1/mcp
|
|
",
|
|
)?;
|
|
|
|
let server = responses::start_mock_server().await;
|
|
responses::mount_response_handler(&server, |request| {
|
|
let (id, message) = if request.body_json()["text"]["format"]["type"] == "json_schema" {
|
|
("title", r#"{"title":"Check service health"}"#)
|
|
} else {
|
|
("foreground", "Foreground turn completed")
|
|
};
|
|
responses::sse_response(responses::sse(vec![
|
|
responses::ev_assistant_message(id, message),
|
|
responses::ev_completed(id),
|
|
]))
|
|
})
|
|
.await;
|
|
let mut config = std::fs::OpenOptions::new()
|
|
.append(true)
|
|
.open(home.path().join("config.toml"))?;
|
|
writeln!(
|
|
config,
|
|
"[model_providers.test]
|
|
name = 'Mock'
|
|
base_url = '{}/v1'
|
|
wire_api = 'responses'
|
|
|
|
[tui]
|
|
status_line = ['thread-title']",
|
|
server.uri(),
|
|
)?;
|
|
let mut terminal = PtyCodex::start(
|
|
&cwd,
|
|
home,
|
|
&[
|
|
"--no-daemon",
|
|
"-c",
|
|
"model_provider='test'",
|
|
"-c",
|
|
"approval_policy='on-request'",
|
|
"$ping the service",
|
|
],
|
|
)?;
|
|
terminal.wait_for_screen("Continue anyway")?;
|
|
// Startup can drain pending input after it first draws the installation prompt.
|
|
let deadline = Instant::now() + Duration::from_secs(/*secs*/ 30);
|
|
while terminal.screen_contains("1 unanswered") {
|
|
anyhow::ensure!(Instant::now() < deadline, "installation prompt stayed open");
|
|
terminal.write_input(b"2")?;
|
|
terminal.read_output(Duration::from_millis(/*millis*/ 50))?;
|
|
}
|
|
terminal.wait_for_screen("answer: Continue anyway")?;
|
|
terminal.wait_for_screen("Foreground turn completed")?;
|
|
terminal.wait_for_screen("Check service health")?;
|
|
assert!(
|
|
!terminal.screen_contains("temporary structured threads cannot request"),
|
|
"{}",
|
|
terminal.screen_contents()
|
|
);
|
|
Ok(())
|
|
}
|