mirror of
https://github.com/openai/codex.git
synced 2026-08-23 13:09:46 +00:00
2e32d95894
## Why Code mode must link against a V8 build with sandbox support, but Windows MSVC still used upstream non-sandboxed prebuilts and package builds selected the older release artifact profile. ## What changed - Enable the `v8_enable_sandbox` feature directly for the code mode runtime. - Select the `ptrcomp_sandbox_release` archive and bindings in Cargo packaging and CI, including Windows MSVC release builds. - Point Bazel's Windows MSVC targets at the sandbox-enabled Codex artifacts and enable the matching crate feature. ## Testing Add a runtime test that calls `v8__V8__IsSandboxEnabled()` and verifies that the linked V8 library has sandbox support enabled. GitOrigin-RevId: c1b49b44a6ccfea5b5006d69ec7866848d1cddd7
54 lines
2.0 KiB
YAML
54 lines
2.0 KiB
YAML
name: setup-rusty-v8
|
|
description: Download and verify Codex-built rusty_v8 artifacts for Cargo builds.
|
|
inputs:
|
|
target:
|
|
description: Rust target triple with Codex-built V8 release artifacts.
|
|
required: true
|
|
|
|
runs:
|
|
using: composite
|
|
steps:
|
|
- name: Configure rusty_v8 artifact overrides and verify checksums
|
|
shell: bash
|
|
env:
|
|
TARGET: ${{ inputs.target }}
|
|
run: |
|
|
set -euo pipefail
|
|
|
|
version="$(python3 "${GITHUB_WORKSPACE}/.github/scripts/rusty_v8_bazel.py" resolved-v8-crate-version)"
|
|
release_tag="rusty-v8-v${version}"
|
|
base_url="https://github.com/openai/codex/releases/download/${release_tag}"
|
|
binding_dir="${RUNNER_TEMP}/rusty_v8"
|
|
|
|
profile="ptrcomp_sandbox_release"
|
|
|
|
if [[ "$TARGET" == *-pc-windows-msvc ]]; then
|
|
archive_name="rusty_v8_${profile}_${TARGET}.lib.gz"
|
|
else
|
|
archive_name="librusty_v8_${profile}_${TARGET}.a.gz"
|
|
fi
|
|
binding_name="src_binding_${profile}_${TARGET}.rs"
|
|
checksums_name="rusty_v8_${profile}_${TARGET}.sha256"
|
|
|
|
archive_path="${binding_dir}/${archive_name}"
|
|
binding_path="${binding_dir}/${binding_name}"
|
|
checksums_path="${binding_dir}/${checksums_name}"
|
|
|
|
mkdir -p "${binding_dir}"
|
|
curl -fsSL "${base_url}/${archive_name}" -o "${archive_path}"
|
|
curl -fsSL "${base_url}/${binding_name}" -o "${binding_path}"
|
|
curl -fsSL "${base_url}/${checksums_name}" -o "${checksums_path}"
|
|
|
|
if [[ "$(wc -l < "${checksums_path}")" -ne 2 ]]; then
|
|
echo "Expected exactly two checksums for ${TARGET} in ${checksums_path}" >&2
|
|
exit 1
|
|
fi
|
|
|
|
if command -v sha256sum >/dev/null 2>&1; then
|
|
(cd "${binding_dir}" && sha256sum -c "${checksums_path}")
|
|
else
|
|
(cd "${binding_dir}" && shasum -a 256 -c "${checksums_path}")
|
|
fi
|
|
echo "RUSTY_V8_ARCHIVE=${archive_path}" >> "${GITHUB_ENV}"
|
|
echo "RUSTY_V8_SRC_BINDING_PATH=${binding_path}" >> "${GITHUB_ENV}"
|