Dylan Hurd 2da1b12822 Let permission hooks resolve strict auto-review requests (#32232) ...

## What changed

- Run permission-request hooks before routing approvals to the automated reviewer or user, including when `strict_auto_review` is enabled.
- Centralize approval resolution so hook, automated-reviewer, and user decisions share rejection handling and report the correct telemetry source.

## Testing

- Add an integration test showing that an allow hook can approve a shell command during strict auto-review without invoking the automated reviewer.

GitOrigin-RevId: 18e9d76baee6cbae9d35ae517250f2f82270a9d2

2026-07-10 18:12:27 +00:00

..

snapshots

Update models.json (#21818)

2026-07-08 16:24:12 -07:00

abort_tasks.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

additional_context.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

agent_execution.rs

Namespace multi-agent v2 tools under collaboration (#29067)

2026-06-23 14:15:20 +02:00

agent_jobs.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

agent_websocket.rs

Update models.json (#21818)

2026-07-08 16:24:12 -07:00

agents_md.rs

feat(app-server): add history_mode to thread (#29927)

2026-06-26 09:12:42 -07:00

apply_patch_cli.rs

Revert "[core] Support interleaved response items" (#31261)

2026-07-06 10:09:54 -07:00

approvals.rs

core: expose permission profile to shell tools (#29941)

2026-06-25 19:00:23 +00:00

auto_review.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

cli_stream.rs

Update models.json (#31684)

2026-07-09 03:40:08 +00:00

client_websockets.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

client.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

code_mode_elicitation.rs

code-mode: make all approvals trigger elicitation pause (#31650)

2026-07-08 15:27:04 -07:00

code_mode.rs

code-mode: fall back to using in process v8 if we fail to resolve external process (#31899)

2026-07-09 14:40:10 -07:00

codex_delegate.rs

Revert "[core] Support interleaved response items" (#31261)

2026-07-06 10:09:54 -07:00

collaboration_instructions.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

compact_remote_parity.rs

Stabilize remote compaction parity against dynamic skill catalogs (#31585)

2026-07-08 15:59:36 +01:00

compact_remote.rs

Update models.json (#21818)

2026-07-08 16:24:12 -07:00

compact_resume_fork.rs

Support openai/form extended form elicitations (#27500)

2026-06-18 11:54:49 -07:00

compact.rs

Update models.json (#21818)

2026-07-08 16:24:12 -07:00

current_time_reminder.rs

[codex] impl delivery_mode: current time reminders on response boundaries (#30033)

2026-06-25 19:28:50 +00:00

deprecation_notice.rs

Add indexed web search mode (#28489)

2026-06-19 05:35:57 -07:00

exec_policy.rs

Preserve managed exec policy after rules parse errors (#31188)

2026-07-06 19:28:44 -07:00

exec.rs

Add network environment ID plumbing (#28766)

2026-06-18 14:09:38 +02:00

extension_sandbox.rs

Use the image generation extension by default (#31596)

2026-07-09 12:25:19 +09:00

external_auth.rs

[codex] Add externally provided Codex auth (#31274)

2026-07-07 17:43:19 -07:00

fork_thread.rs

Share resumed rollout history (#28426)

2026-06-23 10:23:25 -04:00

guardian_review.rs

chore(approvals) consolidate guardian calls for shell tools (#31267)

2026-07-06 13:23:01 -07:00

hooks_mcp.rs

Represent MCP authentication with an enum (#29924)

2026-06-24 19:51:51 -07:00

hooks.rs

Let permission hooks resolve strict auto-review requests (#32232)

2026-07-10 18:12:27 +00:00

image_rollout.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

items.rs

Use the image generation extension by default (#31596)

2026-07-09 12:25:19 +09:00

json_result.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

live_cli.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

mcp_auth_elicitation.rs

[codex] Enable auth elicitation by default (#28772)

2026-07-07 11:48:27 -07:00

mcp_auth_refresh.rs

fix: forward originator to Codex Apps MCP (#31481)

2026-07-09 16:51:44 +00:00

mcp_refresh_cleanup.rs

Pin MCP runtimes to model steps (#30101)

2026-06-26 00:53:07 +01:00

mcp_tool_exposure.rs

Make Apps guidance react to MCP availability (#30226)

2026-07-06 14:29:19 -07:00

mcp_turn_metadata.rs

[codex-rs] Add writes app approval mode (#30482)

2026-07-07 13:13:59 -04:00

mod.rs

Propagate workspace roots to exec-server sandboxes (#32214)

2026-07-10 16:55:01 +00:00

model_overrides.rs

[5 of 7] Replace OverrideTurnContext with ThreadSettings (#22508)

2026-05-18 21:03:51 -07:00

model_runtime_selectors.rs

Use the image generation extension by default (#31596)

2026-07-09 12:25:19 +09:00

model_switching.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

model_visible_layout.rs

Update models.json (#21818)

2026-07-08 16:24:12 -07:00

models_cache_ttl.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

models_etag_responses.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

multi_agent_mode.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

network_approval.rs

fix: attribut network requests to the exact exec on linux (#29697)

2026-07-06 14:51:34 -07:00

openai_file_mcp.rs

[codex-apps] Filter optional file fields by tool schema (#31686)

2026-07-09 14:32:23 -07:00

otel.rs

Revert "[core] Support interleaved response items" (#31261)

2026-07-06 10:09:54 -07:00

override_updates.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

pending_input.rs

[codex] nest sleep config under current time reminder (#29910)

2026-06-24 17:49:00 -07:00

permissions_messages.rs

Use model catalog approval messages (#31312)

2026-07-07 10:52:38 -07:00

personality_migration.rs

feat(app-server): add history_mode to thread (#29927)

2026-06-26 09:12:42 -07:00

personality.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

plugins.rs

Make Apps guidance react to MCP availability (#30226)

2026-07-06 14:29:19 -07:00

prompt_caching.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

prompt_debug_tests.rs

feat(core): store turn_id on ResponseItem metadata (#28360)

2026-06-22 16:45:14 -07:00

quota_exceeded.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

realtime_conversation.rs

[codex] Flush trailing realtime transcript tail (#29918)

2026-07-06 14:12:54 -07:00

remote_env.rs

Support pending remote environment registration (#32231)

2026-07-10 18:08:35 +00:00

remote_models.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

request_compression.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

request_permissions_tool.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

request_permissions.rs

[codex] test exec relative additional permissions (#28587)

2026-06-16 20:45:57 +00:00

request_plugin_install.rs

[plugins] Track plugin install requests by ID (#29684)

2026-06-24 21:29:11 +00:00

request_user_input.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

responses_api_proxy_headers.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

responses_lite.rs

Use the image generation extension by default (#31596)

2026-07-09 12:25:19 +09:00

resume_warning.rs

[codex] Preserve reviewer when resuming threads (#30278)

2026-07-09 00:58:28 +00:00

resume.rs

Update models.json (#21818)

2026-07-08 16:24:12 -07:00

review.rs

feat(core): emit canonical review mode items (#31473)

2026-07-08 09:59:50 -07:00

rmcp_client.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

rollout_budget.rs

Stabilize shared rollout budget test (#31587)

2026-07-08 16:10:28 +01:00

rollout_list_find.rs

Support thread-level originator overrides (#29477)

2026-06-23 17:23:38 -07:00

safety_buffering.rs

[codex] Read retry model from buffering events (#31262)

2026-07-06 17:04:26 +00:00

safety_check_downgrade.rs

Update models.json (#21818)

2026-07-08 16:24:12 -07:00

search_tool.rs

[codex] Restore v1 delegation guidance (#30511)

2026-06-28 20:34:47 -07:00

shell_command.rs

test: branch on target OS instead of runner flavor (#29712)

2026-06-23 14:27:13 -07:00

shell_serialization.rs

test: branch on target OS instead of runner flavor (#29712)

2026-06-23 14:27:13 -07:00

shell_snapshot.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

skill_approval.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

skills.rs

core tests: rename automatic environment builder (#29728)

2026-06-23 21:45:06 +00:00

spawn_agent_description.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

sqlite_state.rs

feat(app-server): add history_mode to thread (#29927)

2026-06-26 09:12:42 -07:00

stream_error_allows_next_turn.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

stream_no_completed.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

subagent_notifications.rs

Update models.json (#21818)

2026-07-08 16:24:12 -07:00

token_budget.rs

Represent MCP authentication with an enum (#29924)

2026-06-24 19:51:51 -07:00

tool_harness.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

tool_parallelism.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

tools.rs

Preserve namespaces on custom tool calls (#30302)

2026-06-27 09:54:56 -07:00

truncation.rs

Represent MCP authentication with an enum (#29924)

2026-06-24 19:51:51 -07:00

turn_state.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

unified_exec_process_events.rs

perf(skills): reuse walk inventory for host loading (#31566)

2026-07-09 09:54:24 +01:00

unified_exec_zsh_fork_approvals.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

unified_exec.rs

Keep unified exec output collection bounded (#32150)

2026-07-10 12:22:04 +00:00

unstable_features_warning.rs

[codex] Remove child AGENTS.md prompt experiment (#28993)

2026-06-18 16:13:07 -07:00

user_notification.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

user_shell_cmd.rs

[codex] Warn clearly when code mode output is truncated (#28467)

2026-06-16 10:37:06 -07:00

view_image.rs

Always send reasoning parameters in Responses requests (#32206)

2026-07-10 16:11:58 +00:00

web_search.rs

Update models.json (#21818)

2026-07-08 16:24:12 -07:00

websocket_fallback.rs

Pair thread environment settings (#26687)

2026-06-08 13:55:15 -07:00

window_headers.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

windows_sandbox.rs

Add network environment ID plumbing (#28766)

2026-06-18 14:09:38 +02:00

workspace_roots.rs

Propagate workspace roots to exec-server sandboxes (#32214)

2026-07-10 16:55:01 +00:00