Files
codex/codex-rs/app-server-client
Benjamin Carlsson f39fcc1bfb Hold Cloud reply streams until history can be refreshed (#62140)
## Why

A Cloud conversation can miss an entire turn while disconnected. A
successful reattach, even with an idle thread, cannot establish that the
client's history is complete.

## What changed

Add an app-server client operation that reattaches a disconnected,
loaded Cloud thread and returns its cached settings. The worker holds
the replacement stream so the caller can refresh turn and item history
before explicitly installing the stream and receiving buffered events.

Reattachment, recovery history reads, and stream installation share a
deadline and use the original Cloud sign-in and network permit. Dropping
the release handle cancels the replacement. Personal access token
sessions still reconnect by reopening the conversation.

## Testing

Extend Cloud connection tests to cover quiet and busy reattachments,
buffered event delivery, cancellation and retry, slow history reads,
and sign-in changes during recovery.

GitOrigin-RevId: a4e5cb967e097021596bc83aac2f8d1a95373712
2026-11-18 00:32:11 +00:00
..

codex-app-server-client

Shared in-process app-server client used by conversational CLI surfaces:

  • codex-exec
  • codex-tui

Purpose

This crate centralizes startup and lifecycle management for an in-process codex-app-server runtime, so CLI clients do not need to duplicate:

  • app-server bootstrap and initialize handshake
  • in-memory request/event transport wiring
  • lifecycle orchestration around caller-provided startup identity
  • graceful shutdown behavior

Startup identity

Callers pass both the app-server SessionSource and the initialize client_info.name explicitly when starting the facade.

That keeps thread metadata (for example in thread/list and thread/read) aligned with the originating runtime without baking TUI/exec-specific policy into the shared client layer.

Transport model

The in-process path uses typed channels:

  • client -> server: ClientRequest / ClientNotification
  • server -> client: InProcessServerEvent
    • ServerRequest
    • ServerNotification
    • LegacyNotification

JSON serialization is still used at external transport boundaries (stdio/websocket), but the in-process hot path is typed.

Typed requests still receive app-server responses through the JSON-RPC result envelope internally. That is intentional: the in-process path is meant to preserve app-server semantics while removing the process boundary, not to introduce a second response contract.

Bootstrap behavior

The client facade starts an already-initialized in-process runtime, but thread bootstrap still follows normal app-server flow:

  • caller sends thread/start or thread/resume
  • app-server returns the immediate typed response
  • richer session metadata may arrive later as a SessionConfigured legacy event

Surfaces such as TUI and exec may therefore need a short bootstrap phase where they reconcile startup response data with later events.

Backpressure and shutdown

  • Command queues and the embedded runtime remain bounded, using DEFAULT_IN_PROCESS_CHANNEL_CAPACITY by default.
  • The facade's local consumer event queue is unbounded and preserves notification order. This keeps the worker draining the bounded runtime while a caller waits for a request, preventing unread notifications from blocking its response.
  • shutdown() performs a bounded graceful shutdown and then aborts if timeout is exceeded.