Ankush Gupta 287e1020ae Add strict automatic review for MCP elicitations (#36365) ...

## What changed

- Recognize the `codex_strict_auto_review` MCP elicitation marker and route
  marked approval requests through the configured automatic reviewer.
- Accept only canonical automatic-review approvals and fail closed without a
  user prompt when review is unavailable, denied, malformed, disallowed by
  policy, or requests persistence.
- Validate Codex Apps approval metadata against the active MCP invocation and
  build the review request from the trusted invocation details.

## Testing

- Add unit coverage for strict review decisions, malformed markers, reviewer
  failures, explicit policy denials, and lifecycle cleanup.
- Add app-server round-trip coverage for approvals, denials, configuration
  constraints, spoofed metadata, persistent requests, and subsequent turns.

GitOrigin-RevId: af73b45a9b63118f25f6429d95b3222c5dbb59fb

2026-07-31 17:18:08 +00:00

..

account.rs

Support self-serve Business ProLite accounts (#35785)

2026-07-28 15:50:45 +00:00

analytics.rs

[codex] Attribute app-server analytics by thread originator (#29935)

2026-06-25 18:15:48 -07:00

app_installed.rs

Upgrade rmcp to 3.0.0-beta.3 (#35720)

2026-07-28 05:17:25 +00:00

app_list.rs

Upgrade rmcp to 3.0.0 (#36001)

2026-07-29 17:38:20 +00:00

app_read.rs

Use batch metadata for plugin app summaries (#34851)

2026-07-23 01:00:35 +00:00

attestation.rs

test: migrate app-server v2 starts to auto env (#31614)

2026-07-08 14:13:59 -07:00

auto_env.rs

test: add delayed exec-server transport (#31427)

2026-07-09 00:17:38 +00:00

client_metadata.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

code_mode_host.rs

Support remote code-mode hosts in app-server (#35098)

2026-07-24 04:37:01 +00:00

collaboration_mode_list.rs

test: migrate TestAppServer callers to builder (#31451)

2026-07-08 00:15:49 +00:00

command_exec.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

compaction.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

config_rpc.rs

Add managed policy for in-app updates (#35537)

2026-07-27 02:16:11 +00:00

connection_handling_websocket_unix.rs

[codex] Add user input client ids (#24653)

2026-05-28 14:54:39 -07:00

connection_handling_websocket.rs

Emit exec-policy warnings for freshly loaded thread config (#31253)

2026-07-06 10:17:15 -07:00

curated_mcp_sync.rs

Wait for MCP readiness in the curated sync test (#35794)

2026-07-28 16:57:17 +00:00

current_time.rs

Refresh environment dates from the configured clock (#36187)

2026-07-30 16:44:18 +00:00

dynamic_tools.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

environment_add.rs

Report selected environment connection transitions (#33251)

2026-07-15 05:21:13 +00:00

environment_info.rs

test: migrate TestAppServer callers to builder (#31451)

2026-07-08 00:15:49 +00:00

environment_status.rs

Expose environment status through app-server (#32920)

2026-07-14 01:49:16 +00:00

exec_server_test_support.rs

[app-server] expose environment info RPC (#30291)

2026-06-27 19:34:10 +00:00

executor_mcp.rs

Isolate MCP OAuth credentials by environment (#36310)

2026-07-31 11:23:46 +00:00

executor_skills.rs

Respect filesystem permissions during capability discovery (#36124)

2026-07-30 10:01:06 +00:00

experimental_api.rs

Support configurable realtime BEM channel prefixes (#34816)

2026-07-22 19:43:35 +00:00

experimental_feature_list.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

external_agent_config.rs

Include session titles in external agent import history (#35870)

2026-07-29 02:45:55 +00:00

external_agent_import_sync.rs

Sync updates to imported external agent sessions (#36356)

2026-07-31 16:17:44 +00:00

fs.rs

test: migrate TestAppServer callers to builder (#31451)

2026-07-08 00:15:49 +00:00

git_attribution.rs

Enable git attribution across Codex entry points (#34819)

2026-07-22 20:23:35 +00:00

hooks_list.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

host_skills.rs

Refresh host skill catalogs through world state (#33425)

2026-07-15 20:59:21 +00:00

imagegen_extension.rs

Correlate image requests and explicit interrupts with turns (#36092)

2026-07-30 05:53:21 +00:00

initialize.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

marketplace_add.rs

Handle @ in local marketplace paths (#34959)

2026-07-23 15:32:36 +00:00

marketplace_remove.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

marketplace_upgrade.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

mcp_resource.rs

Upgrade rmcp to 3.0.0 (#36001)

2026-07-29 17:38:20 +00:00

mcp_server_elicitation.rs

Add strict automatic review for MCP elicitations (#36365)

2026-07-31 17:18:08 +00:00

mcp_server_status.rs

Upgrade rmcp to 3.0.0-beta.3 (#35720)

2026-07-28 05:17:25 +00:00

mcp_tool.rs

Expose MCP read-only hints in tool call items (#36055)

2026-07-30 01:37:41 +00:00

memory_reset.rs

Honor the configured SQLite home across state consumers (#34994)

2026-07-23 19:19:35 +00:00

mod.rs

Sync updates to imported external agent sessions (#36356)

2026-07-31 16:17:44 +00:00

model_list.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

model_provider_capabilities_read.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

multi_agent_v2_developer_instructions.rs

Add configurable developer instructions for v2 subagents (#35708)

2026-07-28 03:33:31 +00:00

output_schema.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

permission_profile_list.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

plan_item.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

plugin_install.rs

Upgrade rmcp to 3.0.0 (#36001)

2026-07-29 17:38:20 +00:00

plugin_list.rs

Expose plugin installation timestamps in app-server summaries (#35859)

2026-07-29 01:16:29 +00:00

plugin_read.rs

Expose remote skill icon URLs through app server (#35012)

2026-07-23 21:06:37 +00:00

plugin_share.rs

Expose plugin installation timestamps in app-server summaries (#35859)

2026-07-29 01:16:29 +00:00

plugin_uninstall.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

process_exec.rs

test: migrate TestAppServer callers to builder (#31451)

2026-07-08 00:15:49 +00:00

rate_limit_reset_credits.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

rate_limits.rs

Support Enterprise automation account plans (#36228)

2026-07-30 21:49:53 +00:00

realtime_conversation.rs

Support configurable realtime BEM channel prefixes (#34816)

2026-07-22 19:43:35 +00:00

recommended_plugins.rs

Decouple recommended plugins from tool suggestions (#35839)

2026-07-28 22:53:33 +00:00

remote_control.rs

Exit the stdio app-server when its connection closes (#36035)

2026-07-29 22:00:20 +00:00

remote_thread_store.rs

Box app-server event payloads (#35854)

2026-07-29 00:30:11 +00:00

request_permissions.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

request_user_input.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

request_validation.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

review.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

safety_check_downgrade.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

selected_capability_stack.rs

Add batched executor capability discovery (#33852)

2026-07-17 15:45:48 +00:00

selected_environment.rs

Preserve executor paths in read command actions (#36223)

2026-07-30 21:12:41 +00:00

session_end.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

skills_list.rs

Keep session defaults static during config batch writes (#34940)

2026-07-23 13:11:16 +00:00

sleep.rs

Refresh environment dates from the configured clock (#36187)

2026-07-30 16:44:18 +00:00

thread_archive.rs

Enforce writer ownership for thread archive and deletion (#35031)

2026-07-23 23:18:06 +00:00

thread_delete.rs

Enforce writer ownership for thread archive and deletion (#35031)

2026-07-23 23:18:06 +00:00

thread_fork.rs

Add persisted sections for organizing threads (#35722)

2026-07-28 05:26:16 +00:00

thread_inject_items.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

thread_list.rs

Add persisted manual ordering for thread sections (#36007)

2026-07-29 18:37:22 +00:00

thread_loaded_list.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

thread_memory_mode_set.rs

Honor the configured SQLite home across state consumers (#34994)

2026-07-23 19:19:35 +00:00

thread_metadata_update.rs

Add persisted manual ordering for thread sections (#36007)

2026-07-29 18:37:22 +00:00

thread_name_websocket.rs

Restore app-server websocket listener with auth guard (#22404)

2026-05-12 18:40:53 -07:00

thread_read.rs

Add persisted sections for organizing threads (#35722)

2026-07-28 05:26:16 +00:00

thread_resume.rs

Stabilize file approval replay test (#36165)

2026-07-30 14:15:39 +00:00

thread_rollback.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

thread_settings_update.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

thread_shell_command.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

thread_start.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

thread_status.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

thread_unarchive.rs

Add persisted manual ordering for thread sections (#36007)

2026-07-29 18:37:22 +00:00

thread_unsubscribe.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

turn_interrupt.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

turn_start_zsh_fork.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

turn_start.rs

Use the host skill provider catalog in world state (#36309)

2026-07-31 11:01:47 +00:00

turn_steer.rs

Simplify app-server integration test setup (#34786)

2026-07-22 16:30:12 +00:00

web_search.rs

Allow custom providers to opt into standalone web search (#34846)

2026-07-23 00:02:15 +00:00

windows_sandbox_setup.rs

test: migrate TestAppServer callers to builder (#31451)

2026-07-08 00:15:49 +00:00