mirror of https://github.com/openai/codex.git synced 2026-09-07 15:40:00 +00:00

Files

Tom Wiltzius 17fe70fdf5 Avoid git probes outside repositories

The metadata rewrite added git metadata collection to live thread creation and
kept SessionMeta git collection in the rollout recorder. Those paths can also
run with temporary working directories that are not git repositories,
especially in app-server integration tests.

collect_git_info may spawn git and wait for its timeout before discovering that
a directory is not a repository. On slower CI platforms that extra subprocess
work made unrelated app-server startup tests miss their existing deadlines.

Guard the call sites with get_git_repo_root first. Non-repository directories
now skip git probing and record no git metadata, while real repository working
directories still collect the same commit, branch, and remote information as
before. This is a focused performance/behavior fix rather than a test timeout
increase.

2026-05-12 13:17:13 -07:00

src

Avoid git probes outside repositories

2026-05-12 13:17:13 -07:00

BUILD.bazel

ThreadStore interface (#17659 )

2026-04-14 13:51:00 -07:00

Cargo.toml

[codex] Remove remote thread store implementation (#21596 )

2026-05-08 00:02:46 +00:00

README.md

Unify thread metadata updates above store

2026-05-12 13:17:13 -07:00

README.md

Thread Store

codex-thread-store is the storage boundary for Codex threads. It defines the ThreadStore trait plus local and in-memory implementations. Other storage implementations may live outside this repository.

Responsibilities

ThreadStore::append_items is the raw canonical history append API. It does not infer metadata from item contents.
ThreadStore::update_thread_metadata is the only thread metadata write API. It accepts a single literal metadata patch shape, regardless of whether the caller is applying a user/API mutation or facts derived above the store from appended history.
LiveThread is the preferred API for active session persistence. It owns a per-thread metadata sync helper, applies the rollout persistence policy, appends canonical history, and then sends metadata patches through ThreadStore::update_thread_metadata.
ThreadManager routes metadata mutations for loaded and cold threads through one entrypoint. Loaded threads use their LiveThread; cold threads go directly to the store.
LocalThreadStore persists history through codex-rollout JSONL files and persists queryable metadata through the SQLite state database when available. Local explicit metadata mutations also maintain JSONL/name-index compatibility so reading old or SQLite-less local storage keeps working.
RolloutRecorder is the local JSONL writer. It writes already-canonical items for ThreadStore::append_items; it no longer decides metadata updates for live thread-store appends.
core/session creates or resumes LiveThread handles and does not need to know whether persistence is backed by local files or another store.

Direction

New metadata observation semantics should live above ThreadStore. Stores persist explicit metadata fields, but raw history appends remain history-only.