mirror of
https://github.com/openai/codex.git
synced 2026-09-11 20:36:49 +00:00
f53c91be2c
## Why Exec-server process and network-policy events need stable attribution to the launching tool call and executor without recording process payloads. ## What changed - Add optional `ExecMetadata` to `ExecParams` and propagate the thread and tool call IDs from unified exec. - Emit bounded OpenTelemetry events for process start, spawn failure, sandbox denial, and exit. Correlate them with the launch trace and registry-issued executor identity while excluding arguments, paths, environment values, output, and error text. - Preserve launch attribution across long-running processes and reconnects, and attach the same metadata to network-policy audit events. - Keep the protocol backward compatible when metadata is omitted, and prevent invalid trace headers from inheriting an unrelated active span. ## Testing Add coverage for metadata serialization and propagation, lifecycle event fields, trace relationships, reconnect behavior, spawn failures, sandbox denials, and network-policy attribution. GitOrigin-RevId: 7aa480a7289c73cb95e2c124c35500bb6f0d5084
79 lines
2.8 KiB
Rust
79 lines
2.8 KiB
Rust
//! Emits bounded process lifecycle telemetry using identity captured at launch.
|
|
//! Reconnects and later process operations must not replace that identity.
|
|
|
|
use std::sync::Arc;
|
|
|
|
use codex_sandboxing::SandboxType;
|
|
use opentelemetry::trace::SpanContext;
|
|
|
|
use crate::telemetry::ExecutorRegistration;
|
|
|
|
/// Log fields captured at launch, never refreshed from a resumed session.
|
|
#[derive(Clone, Default)]
|
|
pub(crate) struct ProcessTelemetry {
|
|
pub(crate) launch_context: Option<SpanContext>,
|
|
pub(crate) thread_id: Option<String>,
|
|
pub(crate) tool_call_id: Option<String>,
|
|
pub(crate) executor_registration: Option<Arc<ExecutorRegistration>>,
|
|
}
|
|
|
|
/// Lifecycle events with outcome fields only when a process has exited.
|
|
pub(crate) enum ProcessTelemetryEvent {
|
|
Start,
|
|
SpawnFailed,
|
|
SandboxDenied,
|
|
Exit {
|
|
exit_code: i32,
|
|
termination_requested: bool,
|
|
},
|
|
}
|
|
|
|
impl ProcessTelemetry {
|
|
pub(crate) fn log(&self, event: ProcessTelemetryEvent, sandbox: SandboxType) {
|
|
let (event_name, exit_code, termination_requested, reason) = match event {
|
|
ProcessTelemetryEvent::Start => ("codex.exec_server.process_start", None, None, None),
|
|
ProcessTelemetryEvent::SpawnFailed => {
|
|
("codex.exec_server.process_spawn_failed", None, None, None)
|
|
}
|
|
ProcessTelemetryEvent::SandboxDenied => (
|
|
"codex.exec_server.sandbox_denied",
|
|
None,
|
|
None,
|
|
Some("inferred_denial"),
|
|
),
|
|
ProcessTelemetryEvent::Exit {
|
|
exit_code,
|
|
termination_requested,
|
|
} => (
|
|
"codex.exec_server.process_exit",
|
|
Some(exit_code),
|
|
Some(termination_requested),
|
|
None,
|
|
),
|
|
};
|
|
let trace_id = self
|
|
.launch_context
|
|
.as_ref()
|
|
.map(|span| span.trace_id().to_string());
|
|
let span_id = self
|
|
.launch_context
|
|
.as_ref()
|
|
.map(|span| span.span_id().to_string());
|
|
tracing::event!(
|
|
target: "codex_otel.log_only",
|
|
tracing::Level::INFO,
|
|
event.name = event_name,
|
|
launch.trace_id = trace_id.as_deref(),
|
|
launch.span_id = span_id.as_deref(),
|
|
conversation.id = self.thread_id.as_deref(),
|
|
tool.call_id = self.tool_call_id.as_deref(),
|
|
executor.environment_id = self.executor_registration.as_ref().map(|registration| registration.environment_id.as_str()),
|
|
executor.registration_id = self.executor_registration.as_ref().map(|registration| registration.executor_registration_id.as_str()),
|
|
sandbox.type = ?sandbox,
|
|
process.exit_code = exit_code,
|
|
process.termination_requested = termination_requested,
|
|
reason,
|
|
);
|
|
}
|
|
}
|