mirror of
https://github.com/openai/codex.git
synced 2026-11-21 22:50:37 +00:00
## Why Keep the App Store Connect private key in Azure Key Vault instead of exporting it to release runners as a base64-encoded `.p8` secret. ## What changed - Add a notarization client that creates notary-scoped Apple JWTs with a pinned Azure Key Vault key, submits and streams artifacts to Apple's notarization service, polls for completion, and saves developer diagnostics. - Update the binary and DMG release wrappers to use the new client while continuing to staple accepted DMGs with `rcodesign`. - Configure release jobs with the notarization vault key name and version instead of private-key material. ## Testing - Add unit coverage for key validation, JWT signing, uploads, polling, diagnostic logs, and the binary and DMG wrapper contracts. GitOrigin-RevId: 8f526c5691d774964fd33f847f8420cac0840b05
112 lines
2.6 KiB
Bash
Executable File
112 lines
2.6 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# Notarize a standalone binary and retain its diagnostic report.
|
|
|
|
set -euo pipefail
|
|
|
|
usage() {
|
|
cat >&2 <<'EOF'
|
|
Usage: notarize_macos_binary_with_akv.sh --binary PATH [--report-dir PATH] [--max-wait-seconds SECONDS]
|
|
|
|
Options:
|
|
--binary PATH Signed standalone macOS binary to notarize.
|
|
--report-dir PATH Directory for notarization logs.
|
|
--max-wait-seconds SECONDS Maximum Apple notarization wait time.
|
|
EOF
|
|
}
|
|
|
|
binary_path=""
|
|
report_dir="${RUNNER_TEMP:-/tmp}/macos-binary-notarization-verification"
|
|
max_wait_seconds="600"
|
|
|
|
while [[ $# -gt 0 ]]; do
|
|
case "$1" in
|
|
--binary)
|
|
binary_path="${2:-}"
|
|
shift 2
|
|
;;
|
|
--report-dir)
|
|
report_dir="${2:-}"
|
|
shift 2
|
|
;;
|
|
--max-wait-seconds)
|
|
max_wait_seconds="${2:-}"
|
|
shift 2
|
|
;;
|
|
-h|--help)
|
|
usage
|
|
exit 0
|
|
;;
|
|
*)
|
|
echo "Unknown notarization argument: $1" >&2
|
|
usage
|
|
exit 2
|
|
;;
|
|
esac
|
|
done
|
|
|
|
if [[ -z "$binary_path" ]]; then
|
|
echo "--binary is required." >&2
|
|
usage
|
|
exit 2
|
|
fi
|
|
|
|
if [[ ! -f "$binary_path" ]]; then
|
|
echo "Binary does not exist: $binary_path" >&2
|
|
exit 1
|
|
fi
|
|
|
|
if [[ ! "$max_wait_seconds" =~ ^[0-9]+$ ]]; then
|
|
echo "--max-wait-seconds must be a non-negative integer." >&2
|
|
exit 2
|
|
fi
|
|
|
|
for command_name in python3 zip; do
|
|
if ! command -v "$command_name" >/dev/null 2>&1; then
|
|
echo "$command_name was not found on PATH." >&2
|
|
exit 1
|
|
fi
|
|
done
|
|
|
|
missing_environment=0
|
|
for variable_name in \
|
|
APPLE_NOTARIZATION_ISSUER_ID \
|
|
APPLE_NOTARIZATION_AKV_KEY_NAME \
|
|
AZURE_KEYVAULT_NAME
|
|
do
|
|
if [[ -z "${!variable_name:-}" ]]; then
|
|
echo "$variable_name must be configured before notarizing a binary." >&2
|
|
missing_environment=1
|
|
fi
|
|
done
|
|
|
|
if [[ "$missing_environment" -ne 0 ]]; then
|
|
exit 2
|
|
fi
|
|
|
|
mkdir -p "$report_dir"
|
|
|
|
notarization_temp_dir="$(mktemp -d)"
|
|
trap 'rm -rf "$notarization_temp_dir" >/dev/null' EXIT
|
|
|
|
binary_name="$(basename "$binary_path")"
|
|
archive_path="$notarization_temp_dir/${binary_name}.zip"
|
|
(
|
|
cd "$(dirname "$binary_path")"
|
|
zip -q "$archive_path" "$binary_name"
|
|
)
|
|
|
|
notarization_log="$report_dir/${binary_name}-notarization.log"
|
|
python3 "$(dirname "$0")/notarize_with_akv.py" \
|
|
--file "$archive_path" \
|
|
--report-log "$report_dir/${binary_name}-notarization-developer-log.json" \
|
|
--max-wait-seconds "$max_wait_seconds" \
|
|
2>&1 | tee "$notarization_log"
|
|
|
|
{
|
|
echo "binary_name=$binary_name"
|
|
echo "max_wait_seconds=$max_wait_seconds"
|
|
echo "binary_sha256=$(shasum -a 256 "$binary_path" | awk '{ print $1 }')"
|
|
echo "notarization=completed"
|
|
} >"$report_dir/${binary_name}-notarization-summary.txt"
|