Files
codex/codex-rs/tui/src/app_server_session/provider_selection.rs
T
alexsong-oai b2a8e68c74 Allow choosing the default provider for new chats in the TUI (#59722)
## What changed

- Add Space to set the default provider from Model providers settings, persisting `model_provider` on the connected server. Keep provider details available and disable selection when server configuration or client launch settings fix the provider.
- Apply the choice to `/new` while preserving the current chat. Refresh account details for new chats and reject account data that does not match the started provider.
- Block stale `/model` choices during saves and after confirmed or uncertain provider changes, including across reconnects. Tell users to restart the app server and TUI to refresh the model list, and discard queued picker actions from another backend or chat.

## Testing

Add coverage for provider saves, retry after disconnection, concurrent-save prevention, stale model choices, and account/provider matching, with updated provider-picker snapshots.

GitOrigin-RevId: af6d149f7de7a2eaa09a31935f7088faa64d6a59
2026-11-05 19:11:18 +00:00

87 lines
3.0 KiB
Rust

//! Provider request overrides honor managed requirements over explicit invocation choices.
//! Omission lets the server resolve the provider for thread creation, forks, and history lookup.
use super::AppServerSession;
use super::ThreadParamsMode;
use crate::legacy_core::config::Config;
use codex_config::ConfigLayerSource;
pub(crate) fn explicit_provider(config: &Config) -> Option<String> {
config
.config_layer_stack
.layers_high_to_low()
.find(|layer| layer.config.get("model_provider").is_some())
.filter(|layer| {
matches!(
layer.name,
ConfigLayerSource::SessionFlags
| ConfigLayerSource::User {
profile: Some(_),
..
}
)
})
.map(|_| config.model_provider_id.clone())
}
impl AppServerSession {
/// A remote client forwards its local named profile. Embedded sessions reload that same
/// profile from disk before /new, so only invocation flags can pin its provider.
pub(crate) fn client_provider_override_for_new_chats(&self, config: &Config) -> Option<String> {
match self.thread_params_mode() {
ThreadParamsMode::Cloud => None,
ThreadParamsMode::Remote => self.explicit_model_provider(config),
ThreadParamsMode::Embedded => {
let launch_flag = self.model_provider_override.is_some()
|| config.config_layer_stack.layers_high_to_low().any(|layer| {
layer.name == ConfigLayerSource::SessionFlags
&& layer.config.get("model_provider").is_some()
});
launch_flag
.then(|| self.explicit_model_provider(config))
.flatten()
}
}
}
pub(crate) fn explicit_model_provider(&self, config: &Config) -> Option<String> {
self.model_provider_override
.as_ref()
.map(|provider| {
config
.config_layer_stack
.required_model_provider()
.unwrap_or(provider)
.to_owned()
})
.or_else(|| explicit_provider(config))
}
pub(crate) async fn history_model_provider(
&self,
config: &Config,
) -> color_eyre::Result<Option<String>> {
if let Some(provider) = self.explicit_model_provider(config) {
return Ok(Some(provider));
}
let Some(cwd) = super::thread_cwd_from_config(
config,
self.thread_params_mode(),
self.remote_cwd_override(),
) else {
return Ok(None);
};
Ok(crate::config_update::read_effective_config_if_supported(
self.request_handle(),
std::path::Path::new(&cwd),
)
.await?
.map(|config| {
config
.config
.model_provider
.unwrap_or_else(|| "openai".to_string())
}))
}
}