openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-11-01 19:33:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,422 Commits 4,712 Branches 1,523 Tags
d4384083a5409552ae2b4a0cf717455e95d47fcd
Commit Graph
8422 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
ae 5bce369c4d fix: clean up styles & colors and define in styles.md (#2401) 
New style guide:

  # Headers, primary, and secondary text
  
- **Headers:** Use `bold`. For markdown with various header levels,
leave in the `#` signs.
  - **Primary text:** Default.
  - **Secondary text:** Use `dim`.
  
  # Foreground colors
  
- **Default:** Most of the time, just use the default foreground color.
`reset` can help get it back.
- **Selection:** Use ANSI `blue`. (Ed & AE want to make this cyan too,
but we'll do that in a followup since it's riskier in different themes.)
  - **User input tips and status indicators:** Use ANSI `cyan`.
  - **Success and additions:** Use ANSI `green`.
  - **Errors, failures and deletions:** Use ANSI `red`.
  - **Codex:** Use ANSI `magenta`.
  
  # Avoid
  
- Avoid custom colors because there's no guarantee that they'll contrast
well or look good on various terminal color themes.
- Avoid ANSI `black`, `white`, `yellow` as foreground colors because the
terminal theme will do a better job. (Use `reset` if you need to in
order to get those.) The exception is if you need contrast rendering
over a manually colored background.
  
  (There are some rules to try to catch this in `clippy.toml`.)

# Testing

Tested in a variety of light and dark color themes in Terminal, iTerm2, and Ghostty.
 2025-08-18 08:26:29 -07:00
Michael Bolin a269754668 remove mcp-server/src/mcp_protocol.rs and the code that depends on it (#2360) 2025-08-18 00:29:18 -07:00
Michael Bolin 897961811f merge commit for archive created by Sapling 2025-08-17 23:06:13 -07:00
Michael Bolin a06dc97fb5 remove mcp-server/src/mcp_protocol.rs and the code that depends on it 2025-08-17 23:06:07 -07:00
Michael Bolin 682e4a6029 Merge 538fa74044 into sapling-pr-archive-bolinfest 2025-08-17 23:05:16 -07:00
Michael Bolin 538fa74044 remove mcp-server/src/mcp_protocol.rs and the code that depends on it 2025-08-17 23:05:13 -07:00
Michael Bolin 43de9cd001 merge commit for archive created by Sapling 2025-08-17 23:04:09 -07:00
Michael Bolin 6b4292b9e4 remove mcp-server/src/mcp_protocol.rs and the code that depends on it 2025-08-17 23:04:04 -07:00
Michael Bolin 44a58feb94 merge commit for archive created by Sapling 2025-08-17 23:00:28 -07:00
Michael Bolin 991b1b32ed remove mcp-server/src/mcp_protocol.rs and the code that depends on it 2025-08-17 23:00:21 -07:00
Michael Bolin 017214f079 merge commit for archive created by Sapling 2025-08-17 22:11:33 -07:00
Michael Bolin d973d33c1c remove mcp-server/src/mcp_protocol.rs and the code that depends on it 2025-08-17 22:11:28 -07:00
Michael Bolin 1bf636e340 merge commit for archive created by Sapling 2025-08-17 22:08:10 -07:00
Michael Bolin 84215cf9e3 remove mcp-server/src/mcp_protocol.rs and the code that depends on it 2025-08-17 22:08:04 -07:00
Michael Bolin b581498882 fix: introduce EventMsg::TurnAborted (#2365) 
Introduces `EventMsg::TurnAborted` that should be sent in response to
`Op::Interrupt`.

In the MCP server, updates the handling of a
`ClientRequest::InterruptConversation` request such that it sends the
`Op::Interrupt` but does not respond to the request until it sees an
`EventMsg::TurnAborted`.
 2025-08-17 21:40:31 -07:00
Michael Bolin 1040fc439f merge commit for archive created by Sapling 2025-08-17 21:33:09 -07:00
Michael Bolin a42cb311d8 fix: introduce EventMsg::TurnAborted 2025-08-17 21:33:02 -07:00
Michael Bolin 18711d4cfd Merge 00139a1afc into sapling-pr-archive-bolinfest 2025-08-17 15:43:25 -07:00
Michael Bolin 00139a1afc fix: introduce EventMsg::TurnAborted 2025-08-17 15:43:10 -07:00
Michael Bolin 22fc98224b Merge 1cd51fe1b8 into sapling-pr-archive-bolinfest 2025-08-17 15:34:37 -07:00
Michael Bolin 1cd51fe1b8 fix: remove shutdown_flag param to run_login_server() 2025-08-17 15:34:28 -07:00
Michael Bolin cfcbac1591 Merge 437caeffa6 into sapling-pr-archive-bolinfest 2025-08-17 15:27:04 -07:00
Michael Bolin 437caeffa6 fix: reduce references to Server in codex-login crate 2025-08-17 15:26:58 -07:00
Michael Bolin 88cdde4df0 Merge 3aff1f62ef into sapling-pr-archive-bolinfest 2025-08-17 14:54:03 -07:00
Michael Bolin 3aff1f62ef fix: make ShutdownHandle a private field of LoginServer 2025-08-17 14:53:55 -07:00
Michael Bolin a7bd7e458a merge commit for archive created by Sapling 2025-08-17 14:39:36 -07:00
Michael Bolin 4dc441bca6 fix: eliminate ServerOptions.login_timeout and have caller use tokio::time::timeout() instead 2025-08-17 14:39:30 -07:00
Michael Bolin e634182ac8 merge commit for archive created by Sapling 2025-08-17 14:35:46 -07:00
Michael Bolin 3544a84d50 fix: eliminate ServerOptions.login_timeout and have caller use tokio::time::timeout() instead 2025-08-17 14:35:40 -07:00
Michael Bolin b52dc59f26 merge commit for archive created by Sapling 2025-08-17 14:32:26 -07:00
Michael Bolin 16766382a3 fix: change shutdown_flag from Arc<AtomicBool> to tokio::sync::Notify 2025-08-17 14:32:17 -07:00
Michael Bolin cfca8371f6 fix: eliminate ServerOptions.login_timeout and have caller use tokio::time::timeout() instead 2025-08-17 14:32:17 -07:00
Michael Bolin 67c58ee62d Merge 173fa5fab4 into sapling-pr-archive-bolinfest 2025-08-17 14:26:44 -07:00
Michael Bolin 173fa5fab4 fix: eliminate ServerOptions.login_timeout and have caller use tokio::time::timeout() instead 2025-08-17 14:26:24 -07:00
Michael Bolin d699a3af75 fix: change shutdown_flag from Arc<AtomicBool> to tokio::sync::Notify 2025-08-17 14:26:24 -07:00
Michael Bolin 29f0e27fcc Merge 4361cc6c90 into sapling-pr-archive-bolinfest 2025-08-17 14:19:29 -07:00
Michael Bolin 4361cc6c90 fix: eliminate ServerOptions.login_timeout and have caller use tokio::time::timeout() instead 2025-08-17 14:19:24 -07:00
Michael Bolin 6ca4d72c98 Merge ca6ded7d2a into sapling-pr-archive-bolinfest 2025-08-17 14:17:56 -07:00
Michael Bolin ca6ded7d2a fix: eliminate ServerOptions.login_timeout and have caller use tokio::time::timeout() instead 2025-08-17 14:17:45 -07:00
Michael Bolin d107e27d59 fix: change shutdown_flag from Arc<AtomicBool> to tokio::sync::Notify 2025-08-17 14:12:18 -07:00
Michael Bolin a868d626bb Merge a72581ec8f into sapling-pr-archive-bolinfest 2025-08-17 13:58:40 -07:00
Michael Bolin a72581ec8f fix: async-ify login flow 2025-08-17 13:54:55 -07:00
Michael Bolin 4b8d0fda61 Merge 21816438b8 into sapling-pr-archive-bolinfest 2025-08-17 13:17:27 -07:00
Michael Bolin 21816438b8 chore: prefer returning Err to expect() 2025-08-17 13:17:21 -07:00
Michael Bolin 71cae06e66 fix: refactor login/src/server.rs so process_request() is a separate function (#2388) 2025-08-17 12:32:56 -07:00
Michael Bolin a57eb9d8fb Merge 53f893ce8c into sapling-pr-archive-bolinfest 2025-08-17 11:35:10 -07:00
Michael Bolin 53f893ce8c chore: prefer returning Err to expect() 2025-08-17 11:35:03 -07:00
Michael Bolin 19168d74fe merge commit for archive created by Sapling 2025-08-17 11:19:34 -07:00
Michael Bolin 374c1aa922 fix: refactor login/src/server.rs so process_request() is a separate function 2025-08-17 11:19:29 -07:00
Michael Bolin 5f94238199 merge commit for archive created by Sapling 2025-08-17 11:16:49 -07:00