Commit Graph
913 Commits
Author SHA1 Message Date
kevin zhao 696a543fec feat: integrating heuristics-based fallback in execpolicy 2025-12-03 01:32:53 -08:00
kevin zhao a26955c75d fmt exec_policy imports 2025-12-02 22:42:48 +00:00
kevin zhao acc7c999fb fix test 2025-12-02 22:42:48 +00:00
kevin zhao 1d14bc51e8 inlining and cleanup tests 2025-12-02 22:42:48 +00:00
kevin zhao bf897bf45d inlining 2025-12-02 22:42:48 +00:00
kevin zhao 3e570a8824 update messaging 2025-12-02 22:42:48 +00:00
kevin zhao ba34d0ca96 cleanup forbidden messaging 2025-12-02 22:42:48 +00:00
kevin zhao a13ca36702 delete useless comment 2025-12-02 22:42:48 +00:00
kevin zhao 7edc990705 improve messaging 2025-12-02 22:42:48 +00:00
kevin zhao a91a00e8a7 feat: integrating heuristics-based fallback in execpolicy 2025-12-02 22:42:48 +00:00
kevin zhao a69bd729db improved behavior for dont ask again for this prefix 2025-12-02 22:42:48 +00:00
kevin zhao 338ec43a3a fix rebase bug 2025-12-02 17:42:25 -05:00
kevin zhao a10a775ad7 add docstring 2025-12-02 17:38:52 -05:00
kevin zhao ecf0f163c6 docs 2025-12-02 17:38:52 -05:00
kevin zhao d6e85f9325 only cloning when needed 2025-12-02 17:38:52 -05:00
kevin zhao 3460d33d66 fix approvals test 2025-12-02 17:38:52 -05:00
kevin zhao bfe5b194ca fix formatting 2025-12-02 17:38:52 -05:00
kevin zhao 3dc54e6bce fixup allow_prefix_if_applicable 2025-12-02 17:38:51 -05:00
kevin zhao d2e5d40762 running test with single thread 2025-12-02 17:38:51 -05:00
kevin zhao 08a85a07fd fix compile error 2025-12-02 17:38:51 -05:00
kevin zhao 00bd765957 fix flaky test 2025-12-02 17:38:51 -05:00
kevin zhao a610663a36 fix compile 2025-12-02 17:38:51 -05:00
kevin zhao 48e424c7d4 . 2025-12-02 17:38:51 -05:00
kevin zhao 4a9089294f integration test 2025-12-02 17:38:50 -05:00
kevin zhao 945074d6f0 fixing rw lock bug causing tui to hang 2025-12-02 17:38:50 -05:00
kevin zhao d67b1f7d32 cleanup exec_policy getters 2025-12-02 17:38:50 -05:00
kevin zhao aa3c4d3d1f moving args around 2025-12-02 17:38:50 -05:00
kevin zhao d747d1d492 do not send allow_prefix if execpolicy is disabled 2025-12-02 17:38:49 -05:00
kevin zhao 02c66be831 refactor: adding allow_prefix into ApprovedAllowPrefix 2025-12-02 17:38:49 -05:00
kevin zhao d4d293fcf0 clippy 2025-12-02 17:38:49 -05:00
kevin zhao a2528c3675 using RW locks 2025-12-02 17:38:49 -05:00
kevin zhao 8fb06a9d5b mutating in memory policy instead of reloading 2025-12-02 17:38:49 -05:00
kevin zhao ea9fc79dec Add explicit prefix-approval decision and wire it through execpolicy/UI snapshots 2025-12-02 17:38:48 -05:00
kevin zhao 80e3635b25 Add approval allow-prefix flow in core and tui 2025-12-02 17:38:48 -05:00
liam 4d4778ec1c Trim history.jsonl when history.max_bytes is set (#6242)
This PR honors the `history.max_bytes` configuration parameter by
trimming `history.jsonl` whenever it grows past the configured limit.
While appending new entries we retain the newest record, drop the oldest
lines to stay within the byte budget, and serialize the compacted file
back to disk under the same lock to keep writers safe.
2025-12-02 14:01:05 -08:00
zhao-oai 5ebdc9af1b persisting credits if new snapshot does not contain credit info (#7490)
in response to incoming changes to responses headers where the header
may sometimes not contain credits info (no longer forcing a credit
check)
2025-12-02 16:23:24 -05:00
Michael Bolin f6a7da4ac3 fix: drop lock once it is no longer needed (#7500)
I noticed this while doing a post-commit review of https://github.com/openai/codex/pull/7467.
2025-12-02 20:46:26 +00:00
Ahmed Ibrahim 127e307f89 Show token used when context window is unknown (#7497)
- Show context window usage in tokens instead of percentage when the
window length is unknown.
2025-12-02 11:45:50 -08:00
Ahmed Ibrahim 21ad1c1c90 Use non-blocking mutex (#7467) 2025-12-02 10:50:46 -08:00
jif-oai 72b95db12f feat: intercept apply_patch for unified_exec (#7446) 2025-12-02 17:54:02 +00:00
jif-oai 9ee855ec57 feat: add warning message for the model (#7445)
Add a warning message as a user turn to the model if the model does not
behave as expected (here, for example, if the model opens too many
`unified_exec` sessions)
2025-12-02 11:56:00 +00:00
jif-oai 4b78e2ab09 chore: review everywhere (#7444) 2025-12-02 11:26:27 +00:00
Thibault SottiauxandGav Verma a8d5ad37b8 feat: experimental support for skills.md (#7412)
This change prototypes support for Skills with the CLI. This is an
**experimental** feature for internal testing.

---------

Co-authored-by: Gav Verma <gverma@openai.com>
2025-12-01 20:22:35 -08:00
Steve Mostovoy f443555728 fix(core): enable history lookup on windows (#7457)
- Add portable history log id helper to support inode-like tracking on
Unix and creation time on Windows
- Refactor history metadata and lookup to share code paths and allow
nonzero log ids across platforms
- Add coverage for lookup stability after appends
2025-12-01 16:29:01 -08:00
Dylan Hurd 5b25915d7e fix(apply_patch) tests for shell_command (#7307)
## Summary
Adds test coverage for invocations of apply_patch via shell_command with
heredoc, to validate behavior.

## Testing
- [x] These are tests
2025-12-01 15:09:22 -08:00
Ali Towaiji 0cc3b50228 Fix recent_commits(limit=0) returning 1 commit instead of 0 (#7334)
Fixes #7333

This is a small bug fix.

This PR fixes an inconsistency in `recent_commits` where `limit == 0`
still returns 1 commit due to the use of `limit.max(1)` when
constructing the `git log -n` argument.

Expected behavior: requesting 0 commits should return an empty list.

This PR:
- returns an empty `Vec` when `limit == 0`
- adds a test for `recent_commits(limit == 0)` that fails before the
change and passes afterwards
- maintains existing behavior for `limit > 0`

This aligns behavior with API expectations and avoids downstream
consumers misinterpreting the repository as having commit history when
`limit == 0` is used to explicitly request none.

Happy to adjust if the current behavior is intentional.
2025-12-01 10:14:36 -08:00
jif-oai a421eba31f fix: disable review rollout filtering (#7371) 2025-12-01 09:04:13 +00:00
jif-oai 457c9fdb87 chore: better session recycling (#7368) 2025-11-30 12:42:26 -08:00
jif-oai aaec8abf58 feat: detached review (#7292) 2025-11-28 11:34:57 +00:00
Job Chong cbd7d0d543 chore: improve rollout session init errors (#7336)
Title: Improve rollout session initialization error messages

Issue: https://github.com/openai/codex/issues/7283

What: add targeted mapping for rollout/session initialization errors so
users get actionable messages when Codex cannot access session files.

Why: session creation previously returned a generic internal error,
hiding permissions/FS issues and making support harder.

How:
- Added rollout::error::map_session_init_error to translate the more
common io::Error kinds into user-facing hints (permission, missing dir,
file blocking, corruption). Others are passed through directly with
`CodexErr::Fatal`.
- Reused the mapper in Codex session creation to preserve root causes
instead of returning InternalAgentDied.
2025-11-27 00:20:33 -08:00