From fa2585a285995ffa57e8f36717457dfd971a906d Mon Sep 17 00:00:00 2001 From: Charles Cunningham Date: Wed, 18 Mar 2026 16:20:14 -0700 Subject: [PATCH] Simplify feedback attachment path setup Use the rollout attachment helper directly and rely on its empty result for feedback uploads without logs. Co-authored-by: Codex --- codex-rs/app-server/src/codex_message_processor.rs | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/codex-rs/app-server/src/codex_message_processor.rs b/codex-rs/app-server/src/codex_message_processor.rs index ddcd544e0a..42d4242d51 100644 --- a/codex-rs/app-server/src/codex_message_processor.rs +++ b/codex-rs/app-server/src/codex_message_processor.rs @@ -7000,14 +7000,10 @@ impl CodexMessageProcessor { let codex_home = self.config.codex_home.clone(); let upload_result = tokio::task::spawn_blocking(move || { - let mut attachment_paths = if include_logs { - feedback_rollout_attachment_paths( - codex_home.as_path(), - validated_rollout_path.as_deref(), - ) - } else { - Vec::new() - }; + let mut attachment_paths = feedback_rollout_attachment_paths( + codex_home.as_path(), + validated_rollout_path.as_deref(), + ); if let Some(extra_log_files) = extra_log_files { attachment_paths.extend(extra_log_files); }