From f7a0a9e96adef52feb92fa602900fe97b995e8c4 Mon Sep 17 00:00:00 2001 From: rreichel3-oai Date: Thu, 19 Mar 2026 18:52:08 -0400 Subject: [PATCH] Relax Windows plugin-read init test timeout --- codex-rs/app-server/tests/suite/v2/plugin_read.rs | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/codex-rs/app-server/tests/suite/v2/plugin_read.rs b/codex-rs/app-server/tests/suite/v2/plugin_read.rs index 977ceb2691..c12821a067 100644 --- a/codex-rs/app-server/tests/suite/v2/plugin_read.rs +++ b/codex-rs/app-server/tests/suite/v2/plugin_read.rs @@ -44,6 +44,11 @@ use tokio::task::JoinHandle; use tokio::time::timeout; const DEFAULT_TIMEOUT: Duration = Duration::from_secs(10); +// Windows CI runners can take longer to finish the app-server startup handshake. +#[cfg(windows)] +const DEFAULT_INIT_TIMEOUT: Duration = Duration::from_secs(25); +#[cfg(not(windows))] +const DEFAULT_INIT_TIMEOUT: Duration = DEFAULT_TIMEOUT; #[tokio::test] async fn plugin_read_returns_plugin_details_with_bundle_contents() -> Result<()> { @@ -173,7 +178,7 @@ enabled = true write_installed_plugin(&codex_home, "codex-curated", "demo-plugin")?; let mut mcp = McpProcess::new(codex_home.path()).await?; - timeout(DEFAULT_TIMEOUT, mcp.initialize()).await??; + timeout(DEFAULT_INIT_TIMEOUT, mcp.initialize()).await??; let marketplace_path = AbsolutePathBuf::try_from(repo_root.path().join(".agents/plugins/marketplace.json"))?; @@ -388,7 +393,7 @@ async fn plugin_read_accepts_legacy_string_default_prompt() -> Result<()> { write_plugins_enabled_config(&codex_home)?; let mut mcp = McpProcess::new(codex_home.path()).await?; - timeout(DEFAULT_TIMEOUT, mcp.initialize()).await??; + timeout(DEFAULT_INIT_TIMEOUT, mcp.initialize()).await??; let request_id = mcp .send_plugin_read_request(PluginReadParams { @@ -442,7 +447,7 @@ async fn plugin_read_returns_invalid_request_when_plugin_is_missing() -> Result< write_plugins_enabled_config(&codex_home)?; let mut mcp = McpProcess::new(codex_home.path()).await?; - timeout(DEFAULT_TIMEOUT, mcp.initialize()).await??; + timeout(DEFAULT_INIT_TIMEOUT, mcp.initialize()).await??; let request_id = mcp .send_plugin_read_request(PluginReadParams { @@ -494,7 +499,7 @@ async fn plugin_read_returns_invalid_request_when_plugin_manifest_is_missing() - write_plugins_enabled_config(&codex_home)?; let mut mcp = McpProcess::new(codex_home.path()).await?; - timeout(DEFAULT_TIMEOUT, mcp.initialize()).await??; + timeout(DEFAULT_INIT_TIMEOUT, mcp.initialize()).await??; let request_id = mcp .send_plugin_read_request(PluginReadParams {