openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-11-10 21:00:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow inline patch review during approval prompts (#58281)

Browse Source 
## Why

Collapsed patch details should remain accessible while an approval prompt is open, and reviewing them should not leave the transcript stuck behind new output after approval.

## What changed

Allow clicking transcript disclosure controls while a modal prompt is open. When expanding details during patch approval interrupts following the latest output, resume following once that approval ends or advances to another patch. Preserve manual scrolling and text selection instead of automatically jumping to the latest output.

## Testing

Extend patch approval coverage with an inline expansion snapshot and checks for queued approvals and subsequent output. Add a regression test that preserves manual scroll position when approval ends.

GitOrigin-RevId: 249aa6bb2a84364a8cb111454fa5b6a3dce218b3
This commit is contained in:
Eric Traut
2026-10-30 08:03:51 +00:00
committed by copyberry
parent eab2603712
commit f752c97f7d
14 changed files with 214 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/tui/src/transcript_view.rs
+2
View File
@@ -458,6 +458,7 @@ impl TranscriptView {
}
pub(crate) fn jump_to_latest(&mut self) {
self.disclosure.resume_after_approval = None;
self.cancel_search();
self.cancel_beginning();
self.position = Position::Latest;
@@ -471,6 +472,7 @@ impl TranscriptView {
pub(crate) fn scroll(&mut self, cells: &[Arc<dyn HistoryCell>], rows: isize) {
if rows != 0 {
self.disclosure.resume_after_approval = None;
self.last_click = None;
self.cancel_beginning();
}