mirror of
https://github.com/openai/codex.git
synced 2026-11-18 22:20:48 +00:00
Remove legacy sandbox-policy accessors from configuration (#61395)
## What changed - Remove `Config::legacy_sandbox_policy` and `Permissions::legacy_sandbox_policy`. - Update core and TUI tests to use permission profiles and filesystem/network policies directly, with explicit conversion where legacy wire formats are required. - Report the active sandbox label in app-server resume override mismatch diagnostics. GitOrigin-RevId: cbc5417944e23404523e69dc5516d66d6bfafefe
This commit is contained in:
@@ -7809,7 +7809,7 @@ fn agent_picker_item_name_snapshot() {
|
||||
async fn side_fork_config_is_ephemeral_and_appends_developer_guardrails() {
|
||||
let app = make_test_app().await;
|
||||
let original_approval_policy = app.config.permissions.approval_policy.value();
|
||||
let original_sandbox_policy = app.config.legacy_sandbox_policy();
|
||||
let original_permission_profile = app.config.permissions.effective_permission_profile();
|
||||
|
||||
let mut fork_config = app.side_fork_config();
|
||||
crate::app_server_session::SideChatStorage::Temporary.configure_fork(&mut fork_config);
|
||||
@@ -7819,7 +7819,10 @@ async fn side_fork_config_is_ephemeral_and_appends_developer_guardrails() {
|
||||
fork_config.permissions.approval_policy.value(),
|
||||
original_approval_policy
|
||||
);
|
||||
assert_eq!(fork_config.legacy_sandbox_policy(), original_sandbox_policy);
|
||||
assert_eq!(
|
||||
fork_config.permissions.effective_permission_profile(),
|
||||
original_permission_profile
|
||||
);
|
||||
let developer_instructions = fork_config
|
||||
.developer_instructions
|
||||
.as_deref()
|
||||
|
||||
@@ -253,8 +253,12 @@ async fn misalignment_continuation_requires_current_review_and_submits_once() ->
|
||||
.then(|| config.permissions.user_visible_workspace_roots().to_vec()),
|
||||
approval_policy: (!server_owned).then_some(AskForApproval::OnRequest),
|
||||
approvals_reviewer: None,
|
||||
sandbox_policy: (!server_owned && !preserve)
|
||||
.then(|| config.legacy_sandbox_policy().into()),
|
||||
sandbox_policy: (!server_owned && !preserve).then(|| config
|
||||
.permissions
|
||||
.effective_permission_profile()
|
||||
.to_legacy_sandbox_policy(config.cwd.as_path())
|
||||
.expect("test permissions fit the legacy wire format")
|
||||
.into()),
|
||||
cyber_access_program: rollout_enabled.then_some(if daybreak {
|
||||
CyberAccessProgram::DaybreakBlue.into()
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user