From f60dfe80b5c97be25e7c69b3792c0bf4bfcd3c50 Mon Sep 17 00:00:00 2001 From: iceweasel-oai Date: Thu, 3 Sep 2026 18:06:23 +0000 Subject: [PATCH] Record Windows sandbox private desktop usage (#42596) ## What changed Increment the `codex.windows_sandbox.private_desktop` counter when preparing a Windows restricted-token sandbox execution, tagging it with whether private desktop isolation is enabled. GitOrigin-RevId: 1eb5e183b57e19753dc133dbe152eabe23dd2a23 --- codex-rs/sandboxing/src/manager.rs | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/codex-rs/sandboxing/src/manager.rs b/codex-rs/sandboxing/src/manager.rs index 0439e1c63e..de124d54cb 100644 --- a/codex-rs/sandboxing/src/manager.rs +++ b/codex-rs/sandboxing/src/manager.rs @@ -451,11 +451,22 @@ impl SandboxManager { .to_string(), )); } - ( - os_argv_to_strings(argv), - None, - Some(pending_sandboxed_request?), - ) + let pending = pending_sandboxed_request?; + if let Some(metrics) = codex_otel::global() { + let _ = metrics.counter( + "codex.windows_sandbox.private_desktop", + /*inc*/ 1, + &[( + "enabled", + if windows_sandbox_private_desktop { + "true" + } else { + "false" + }, + )], + ); + } + (os_argv_to_strings(argv), None, Some(pending)) } #[cfg(not(target_os = "windows"))] SandboxType::WindowsRestrictedToken => (