mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
chore: enforce argument-comment lint across all targets
This commit is contained in:
@@ -525,6 +525,9 @@ mod tests {
|
||||
let metadata = ThreadMetadata::try_from(thread_row(Some("future")))
|
||||
.expect("thread metadata should parse");
|
||||
|
||||
assert_eq!(metadata, expected_thread_metadata(None));
|
||||
assert_eq!(
|
||||
metadata,
|
||||
expected_thread_metadata(/*reasoning_effort*/ None)
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -265,13 +265,13 @@ mod tests {
|
||||
.expect("initialize runtime");
|
||||
|
||||
let claimed = runtime
|
||||
.try_claim_backfill(3600)
|
||||
.try_claim_backfill(/*lease_seconds*/ 3600)
|
||||
.await
|
||||
.expect("initial backfill claim");
|
||||
assert_eq!(claimed, true);
|
||||
|
||||
let duplicate_claim = runtime
|
||||
.try_claim_backfill(3600)
|
||||
.try_claim_backfill(/*lease_seconds*/ 3600)
|
||||
.await
|
||||
.expect("duplicate backfill claim");
|
||||
assert_eq!(duplicate_claim, false);
|
||||
@@ -291,17 +291,17 @@ WHERE id = 1
|
||||
.expect("force stale backfill lease");
|
||||
|
||||
let stale_claim = runtime
|
||||
.try_claim_backfill(10)
|
||||
.try_claim_backfill(/*lease_seconds*/ 10)
|
||||
.await
|
||||
.expect("stale backfill claim");
|
||||
assert_eq!(stale_claim, true);
|
||||
|
||||
runtime
|
||||
.mark_backfill_complete(None)
|
||||
.mark_backfill_complete(/*last_watermark*/ None)
|
||||
.await
|
||||
.expect("mark complete");
|
||||
let claim_after_complete = runtime
|
||||
.try_claim_backfill(3600)
|
||||
.try_claim_backfill(/*lease_seconds*/ 3600)
|
||||
.await
|
||||
.expect("claim after complete");
|
||||
assert_eq!(claim_after_complete, false);
|
||||
|
||||
@@ -679,7 +679,12 @@ mod tests {
|
||||
#[test]
|
||||
fn format_feedback_log_line_matches_feedback_formatter_shape() {
|
||||
assert_eq!(
|
||||
format_feedback_log_line(1, 123_456_000, "INFO", "alpha"),
|
||||
format_feedback_log_line(
|
||||
/*ts*/ 1,
|
||||
/*ts_nanos*/ 123_456_000,
|
||||
"INFO",
|
||||
"alpha"
|
||||
),
|
||||
"1970-01-01T00:00:01.123456Z INFO alpha\n"
|
||||
);
|
||||
}
|
||||
@@ -687,7 +692,12 @@ mod tests {
|
||||
#[test]
|
||||
fn format_feedback_log_line_preserves_existing_trailing_newline() {
|
||||
assert_eq!(
|
||||
format_feedback_log_line(1, 123_456_000, "INFO", "alpha\n"),
|
||||
format_feedback_log_line(
|
||||
/*ts*/ 1,
|
||||
/*ts_nanos*/ 123_456_000,
|
||||
"INFO",
|
||||
"alpha\n"
|
||||
),
|
||||
"1970-01-01T00:00:01.123456Z INFO alpha\n"
|
||||
);
|
||||
}
|
||||
@@ -1247,9 +1257,9 @@ mod tests {
|
||||
assert_eq!(
|
||||
String::from_utf8(bytes).expect("valid utf-8"),
|
||||
[
|
||||
format_feedback_log_line(1, 0, "INFO", "alpha"),
|
||||
format_feedback_log_line(2, 0, "INFO", "bravo"),
|
||||
format_feedback_log_line(3, 0, "INFO", "charlie"),
|
||||
format_feedback_log_line(/*ts*/ 1, /*ts_nanos*/ 0, "INFO", "alpha"),
|
||||
format_feedback_log_line(/*ts*/ 2, /*ts_nanos*/ 0, "INFO", "bravo"),
|
||||
format_feedback_log_line(/*ts*/ 3, /*ts_nanos*/ 0, "INFO", "charlie"),
|
||||
]
|
||||
.concat()
|
||||
);
|
||||
@@ -1380,9 +1390,24 @@ mod tests {
|
||||
assert_eq!(
|
||||
String::from_utf8(bytes).expect("valid utf-8"),
|
||||
[
|
||||
format_feedback_log_line(1, 0, "INFO", "threadless-before"),
|
||||
format_feedback_log_line(2, 0, "INFO", "thread-scoped"),
|
||||
format_feedback_log_line(3, 0, "INFO", "threadless-after"),
|
||||
format_feedback_log_line(
|
||||
/*ts*/ 1,
|
||||
/*ts_nanos*/ 0,
|
||||
"INFO",
|
||||
"threadless-before"
|
||||
),
|
||||
format_feedback_log_line(
|
||||
/*ts*/ 2,
|
||||
/*ts_nanos*/ 0,
|
||||
"INFO",
|
||||
"thread-scoped"
|
||||
),
|
||||
format_feedback_log_line(
|
||||
/*ts*/ 3,
|
||||
/*ts_nanos*/ 0,
|
||||
"INFO",
|
||||
"threadless-after"
|
||||
),
|
||||
]
|
||||
.concat()
|
||||
);
|
||||
@@ -1463,9 +1488,24 @@ mod tests {
|
||||
assert_eq!(
|
||||
String::from_utf8(bytes).expect("valid utf-8"),
|
||||
[
|
||||
format_feedback_log_line(2, 0, "INFO", "old-process-thread"),
|
||||
format_feedback_log_line(3, 0, "INFO", "new-process-thread"),
|
||||
format_feedback_log_line(4, 0, "INFO", "new-process-threadless"),
|
||||
format_feedback_log_line(
|
||||
/*ts*/ 2,
|
||||
/*ts_nanos*/ 0,
|
||||
"INFO",
|
||||
"old-process-thread"
|
||||
),
|
||||
format_feedback_log_line(
|
||||
/*ts*/ 3,
|
||||
/*ts_nanos*/ 0,
|
||||
"INFO",
|
||||
"new-process-thread"
|
||||
),
|
||||
format_feedback_log_line(
|
||||
/*ts*/ 4,
|
||||
/*ts_nanos*/ 0,
|
||||
"INFO",
|
||||
"new-process-threadless"
|
||||
),
|
||||
]
|
||||
.concat()
|
||||
);
|
||||
@@ -1647,10 +1687,20 @@ mod tests {
|
||||
assert_eq!(
|
||||
String::from_utf8(bytes).expect("valid utf-8"),
|
||||
[
|
||||
format_feedback_log_line(1, 0, "INFO", "thread-1"),
|
||||
format_feedback_log_line(2, 0, "INFO", "thread-2"),
|
||||
format_feedback_log_line(3, 0, "INFO", "threadless-proc-1"),
|
||||
format_feedback_log_line(4, 0, "INFO", "threadless-proc-2"),
|
||||
format_feedback_log_line(/*ts*/ 1, /*ts_nanos*/ 0, "INFO", "thread-1"),
|
||||
format_feedback_log_line(/*ts*/ 2, /*ts_nanos*/ 0, "INFO", "thread-2"),
|
||||
format_feedback_log_line(
|
||||
/*ts*/ 3,
|
||||
/*ts_nanos*/ 0,
|
||||
"INFO",
|
||||
"threadless-proc-1"
|
||||
),
|
||||
format_feedback_log_line(
|
||||
/*ts*/ 4,
|
||||
/*ts_nanos*/ 0,
|
||||
"INFO",
|
||||
"threadless-proc-2"
|
||||
),
|
||||
]
|
||||
.concat()
|
||||
);
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@@ -1037,7 +1037,10 @@ mod tests {
|
||||
})];
|
||||
|
||||
runtime
|
||||
.apply_rollout_items(&builder, &items, None, None)
|
||||
.apply_rollout_items(
|
||||
&builder, &items, /*new_thread_memory_mode*/ None,
|
||||
/*updated_at_override*/ None,
|
||||
)
|
||||
.await
|
||||
.expect("apply_rollout_items should succeed");
|
||||
|
||||
@@ -1096,7 +1099,10 @@ mod tests {
|
||||
})];
|
||||
|
||||
runtime
|
||||
.apply_rollout_items(&builder, &items, None, None)
|
||||
.apply_rollout_items(
|
||||
&builder, &items, /*new_thread_memory_mode*/ None,
|
||||
/*updated_at_override*/ None,
|
||||
)
|
||||
.await
|
||||
.expect("apply_rollout_items should succeed");
|
||||
|
||||
@@ -1329,7 +1335,12 @@ mod tests {
|
||||
DateTime::<Utc>::from_timestamp(1_700_001_234, 0).expect("timestamp");
|
||||
|
||||
runtime
|
||||
.apply_rollout_items(&builder, &items, None, Some(override_updated_at))
|
||||
.apply_rollout_items(
|
||||
&builder,
|
||||
&items,
|
||||
/*new_thread_memory_mode*/ None,
|
||||
Some(override_updated_at),
|
||||
)
|
||||
.await
|
||||
.expect("apply_rollout_items should succeed");
|
||||
|
||||
|
||||
Reference in New Issue
Block a user