From ef33e43a159beeeb95dddf7cde05926cc9871929 Mon Sep 17 00:00:00 2001 From: "Adam Perry @ OpenAI" Date: Thu, 22 Oct 2026 23:09:07 +0000 Subject: [PATCH] Fix MCP cancellation tests to use the metadata callback (#56292) Update both `call_tool` invocations in `dropping_tool_call_cancels_remote_request` to pass `|_| Ok(None)`, matching the metadata callback API while continuing to omit metadata. GitOrigin-RevId: 9d0f3e3108fe81972ce4fd4cca13f4b7febcc616 --- .../rmcp-client/src/user_verification_cancellation_tests.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/codex-rs/rmcp-client/src/user_verification_cancellation_tests.rs b/codex-rs/rmcp-client/src/user_verification_cancellation_tests.rs index 43561368cd..30a21bc930 100644 --- a/codex-rs/rmcp-client/src/user_verification_cancellation_tests.rs +++ b/codex-rs/rmcp-client/src/user_verification_cancellation_tests.rs @@ -99,7 +99,7 @@ async fn dropping_tool_call_cancels_remote_request() -> anyhow::Result<()> { let mut call = Box::pin(client.call_tool( "wait".into(), /*arguments*/ None, - /*meta*/ None, + |_| Ok(None), /*timeout*/ None, )); // Drop before yielding to the transport's independently scheduled send tasks. @@ -125,7 +125,7 @@ async fn dropping_tool_call_cancels_remote_request() -> anyhow::Result<()> { let mut next = Box::pin(client.call_tool( "next".into(), /*arguments*/ None, - /*meta*/ None, + |_| Ok(None), /*timeout*/ None, )); let request = tokio::select! {