Report why turn critical path capture is incomplete (#62357)

## Why

The `incomplete` status alone gives no indication of which timing dependency was missing or which operation prevented capture.

## What changed

Emit deduplicated `critical_path_incomplete_reasons` in turn analytics for incomplete captures. Reasons cover unsupported Code Mode and agent operations, unattributed reviews and user waits, missing turn starts, and forced teardown, with an `unclassified` fallback. External tools that share a built-in name can still invalidate capture without being classified as the built-in operation.

During interruption, use the task's join result to distinguish forced teardown from normal completion so a task that already finished can still report a complete path.

## Testing

Add coverage for analytics serialization, concurrent reason deduplication, tool name collisions, and interrupted tasks that finish normally or require forced teardown.

GitOrigin-RevId: fab9aa1ff881997a34dcf75adc5638133cedc7fe
This commit is contained in:
akak-oai
2026-11-18 20:29:59 +00:00
committed by copyberry
parent 513577302a
commit ed9becd2fc
17 changed files with 279 additions and 96 deletions
@@ -1,3 +1,4 @@
use codex_analytics::IncompleteReason;
use codex_direct_tool_timing::ToolBatchTiming;
use codex_direct_tool_timing::ToolTimingGuard;
use codex_features::Feature;
@@ -17,6 +18,7 @@ use codex_protocol::request_permissions::RequestPermissionProfile;
use codex_protocol::request_permissions::RequestPermissionsResponse;
use codex_protocol::request_user_input::RequestUserInputArgs;
use codex_protocol::request_user_input::RequestUserInputResponse;
use pretty_assertions::assert_eq;
use tokio::sync::watch;
use tokio_util::sync::CancellationToken;
@@ -299,4 +301,8 @@ async fn unowned_human_wait_does_not_claim_a_complete_path(capture: bool) {
.is_none(),
capture
);
assert_eq!(
turn_context.turn_timing_state.incomplete_reasons().first(),
capture.then_some(&IncompleteReason::UnattributedUserWait)
);
}
+3 -1
View File
@@ -849,7 +849,9 @@ impl Session {
.features
.enabled(Feature::CriticalPathTiming)
{
turn_context.turn_timing_state.invalidate_critical_path();
turn_context
.turn_timing_state
.invalidate_critical_path(&[IncompleteReason::UnattributedUserWait]);
}
let _elicitation = self.services.elicitations.register();
let (tx_response, rx_response) = oneshot::channel();
+4 -1
View File
@@ -68,6 +68,7 @@ use chrono::Utc;
use codex_analytics::AnalyticsEventsClient;
use codex_analytics::ImagePreparationFact;
use codex_analytics::ImagePreparationMetadata;
use codex_analytics::IncompleteReason;
use codex_analytics::SubAgentThreadStartedInput;
use codex_analytics::ThreadInitializationMode;
use codex_analytics::TurnCodexErrorFact;
@@ -3312,7 +3313,9 @@ impl Session {
.features
.enabled(Feature::CriticalPathTiming)
{
turn_context.turn_timing_state.invalidate_critical_path();
turn_context
.turn_timing_state
.invalidate_critical_path(&[IncompleteReason::UnattributedUserWait]);
}
timing
}