mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
Address Python goal review feedback
This commit is contained in:
@@ -576,6 +576,19 @@ def test_failed_goal_starts_release_routing_without_model_requests(tmp_path) ->
|
||||
with pytest.raises(TypeError) as type_error:
|
||||
thread.start_goal(123) # type: ignore[arg-type]
|
||||
|
||||
existing = codex._client.thread_goal_set(
|
||||
thread.id,
|
||||
objective="Keep this valid stored goal",
|
||||
status=ThreadGoalStatus.paused,
|
||||
).goal
|
||||
with pytest.raises(ValueError) as long_error:
|
||||
thread.start_goal("x" * 4_001)
|
||||
persisted = codex._client.request(
|
||||
"thread/goal/get",
|
||||
{"threadId": thread.id},
|
||||
response_model=ThreadGoalGetResponse,
|
||||
).goal
|
||||
|
||||
ephemeral = codex.thread_start(ephemeral=True)
|
||||
with pytest.raises(InvalidRequestError) as ephemeral_error:
|
||||
ephemeral.start_goal("Persist this goal")
|
||||
@@ -585,7 +598,17 @@ def test_failed_goal_starts_release_routing_without_model_requests(tmp_path) ->
|
||||
registered_goals = dict(codex._client._router._goal_operations)
|
||||
|
||||
assert {
|
||||
"errors": [str(empty_error.value), str(type_error.value), ephemeral_error.value.message],
|
||||
"errors": [
|
||||
str(empty_error.value),
|
||||
str(type_error.value),
|
||||
str(long_error.value),
|
||||
ephemeral_error.value.message,
|
||||
],
|
||||
"stored_goal": (
|
||||
existing.objective,
|
||||
persisted.objective if persisted else None,
|
||||
persisted.status if persisted else None,
|
||||
),
|
||||
"follow_up": (follow_up.status, follow_up.final_response),
|
||||
"request_count": len(requests),
|
||||
"registered_goals": registered_goals,
|
||||
@@ -593,8 +616,14 @@ def test_failed_goal_starts_release_routing_without_model_requests(tmp_path) ->
|
||||
"errors": [
|
||||
"goal objective must not be empty",
|
||||
"goal objective must be a string",
|
||||
"goal objective must be at most 4000 characters",
|
||||
f"thread must be persisted before starting a goal: {ephemeral.id}",
|
||||
],
|
||||
"stored_goal": (
|
||||
"Keep this valid stored goal",
|
||||
"Keep this valid stored goal",
|
||||
ThreadGoalStatus.paused,
|
||||
),
|
||||
"follow_up": (TurnStatus.completed, "Ordinary turn complete."),
|
||||
"request_count": 1,
|
||||
"registered_goals": {},
|
||||
|
||||
Reference in New Issue
Block a user