openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-13 11:47:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

codex: address PR review feedback (#28582)

Browse Source
This commit is contained in:
Steven Lee
2026-06-16 20:58:28 +00:00
parent 7db1786573
commit e750db2ccb
16 changed files with 199 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
codex-rs/utils/plugins/src/plugin_service_routing_tests.rs
View File

@@ -22,10 +22,19 @@ fn preview_signal_requires_exact_enabled_value() {
#[test]
fn routing_cookie_is_disabled_by_default_and_cannot_be_enabled_by_caller() {
assert_eq!(plugin_service_routing_cookie(&[], false), None);
assert_eq!(
plugin_service_routing_cookie(&[b"oai-chat-plugin-service-preview=true".as_slice()], false,),
None,
plugin_service_routing_cookie(&[], /*preview_enabled*/ false),
None
);
assert_eq!(
plugin_service_routing_cookie(
&[
b"session=abc; oai-chat-plugin-service-preview=true".as_slice(),
b"theme=dark".as_slice(),
],
/*preview_enabled*/ false,
),
Some(b"session=abc; theme=dark".to_vec()),
);
}
@@ -37,7 +46,7 @@ fn routing_cookie_preserves_unrelated_cookies_and_replaces_caller_value() {
b"session=abc; oai-chat-plugin-service-preview=false".as_slice(),
b"theme=dark; oai-chat-plugin-service-preview=true".as_slice(),
],
true,
/*preview_enabled*/ true,
),
Some(b"session=abc; theme=dark; oai-chat-plugin-service-preview=true".to_vec()),
);