Reuse Guardian reviewer history for direct reviews (#61163)

## What changed

Route direct reviews through the reusable Guardian session so sequential `thread/guardianReview` calls on the same loaded thread can share review history with live approvals. Keep the reviewer conversation separate from the actor and follow the parent thread's persistence settings. Retries reassess the final call under the current policy.

## Testing

Extend app-server coverage to verify history reuse within a parent thread and isolation between parents. Extend the core scenario and snapshot to cover sequential direct reviews without executing the recorded commands.

GitOrigin-RevId: 5f10a04aec43a9351e38575265cb6b5ff06530a5
This commit is contained in:
swastik-oai
2026-11-12 18:30:45 +00:00
committed by copyberry
parent d2f7632472
commit e61a08f9ec
9 changed files with 213 additions and 131 deletions
+22 -34
View File
@@ -210,45 +210,33 @@ impl ReviewInput {
}
}
/// Assess the supplied request in a fresh reviewer without publishing a live approval.
/// Assess the recorded call in a Guardian session separate from the actor.
/// The parent can reuse that session across calls.
/// The caller enforces the deadline and cancellation during setup.
pub(super) async fn assess_isolated(
self,
deadline: ReviewDeadline,
cancellation: &CancellationToken,
) -> Result<GuardianAssessment, GuardianReviewError> {
let review = async {
let (pool, config) = select_synchronous_reviewer(&self.session, &self.context)
.ok_or_else(|| {
GuardianReviewError::session(anyhow::anyhow!(
"Guardian reviewer is unavailable"
))
})?;
let config = config.await.map_err(GuardianReviewError::prompt_build)?;
let category = self.request.guardian_scope();
let params = self.into_params(
config,
category,
ReviewAttemptOptions {
authorization: None,
external_cancel: Some(cancellation.clone()),
deadline,
},
);
let prepared = super::review_session::prepare_review(params)
.await
.map_err(GuardianReviewError::prompt_build)?;
Ok::<_, GuardianReviewError>(pool.review_isolated(&prepared).await.0)
};
let outcome = match run_before_review_deadline(
deadline,
Some(cancellation),
Box::pin(review),
)
.await
{
Ok(result) => result?,
Err(interruption) => interruption,
};
let (pool, config) =
select_synchronous_reviewer(&self.session, &self.context).ok_or_else(|| {
GuardianReviewError::session(anyhow::anyhow!("Guardian reviewer is unavailable"))
})?;
let config = config.await.map_err(GuardianReviewError::prompt_build)?;
let category = self.request.guardian_scope();
let params = self.into_params(
config,
category,
ReviewAttemptOptions {
authorization: None,
external_cancel: Some(cancellation.clone()),
deadline,
},
);
let (outcome, _) = Box::pin(super::review_session::run_guardian_review_session(
pool, params,
))
.await;
outcome.into_assessment()
}
}
@@ -5,7 +5,6 @@
#[path = "review_session_setup.rs"]
mod setup;
pub use setup::PreparedGuardianContext;
pub(super) use setup::prepare_review;
pub use setup::prepare_review_prewarm;
pub(crate) use setup::run_guardian_review_session;