From e44facebde771800606433978c48d580fd97f16a Mon Sep 17 00:00:00 2001 From: kevin zhao Date: Thu, 20 Nov 2025 01:41:14 +0000 Subject: [PATCH] maybefix --- codex-rs/app-server-protocol/src/protocol/v1.rs | 1 - codex-rs/app-server-protocol/src/protocol/v2.rs | 1 - .../app-server/tests/suite/codex_message_processor_flow.rs | 6 +++++- codex-rs/protocol/src/approvals.rs | 1 - 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/codex-rs/app-server-protocol/src/protocol/v1.rs b/codex-rs/app-server-protocol/src/protocol/v1.rs index cc7ba67cf0..a3c59bb35f 100644 --- a/codex-rs/app-server-protocol/src/protocol/v1.rs +++ b/codex-rs/app-server-protocol/src/protocol/v1.rs @@ -228,7 +228,6 @@ pub struct ExecCommandApprovalParams { pub reason: Option, pub risk: Option, pub parsed_cmd: Vec, - #[serde(skip_serializing_if = "Option::is_none", default)] pub allow_prefix: Option>, } diff --git a/codex-rs/app-server-protocol/src/protocol/v2.rs b/codex-rs/app-server-protocol/src/protocol/v2.rs index 30e538ce01..bdbe1fb613 100644 --- a/codex-rs/app-server-protocol/src/protocol/v2.rs +++ b/codex-rs/app-server-protocol/src/protocol/v2.rs @@ -960,7 +960,6 @@ pub struct CommandExecutionRequestApprovalParams { pub reason: Option, /// Optional model-provided risk assessment describing the blocked command. pub risk: Option, - #[serde(skip_serializing_if = "Option::is_none", default)] pub allow_prefix: Option>, } diff --git a/codex-rs/app-server/tests/suite/codex_message_processor_flow.rs b/codex-rs/app-server/tests/suite/codex_message_processor_flow.rs index 5677534e4b..4e345168a8 100644 --- a/codex-rs/app-server/tests/suite/codex_message_processor_flow.rs +++ b/codex-rs/app-server/tests/suite/codex_message_processor_flow.rs @@ -278,7 +278,11 @@ async fn test_send_user_turn_changes_approval_policy_behavior() -> Result<()> { parsed_cmd: vec![ParsedCommand::Unknown { cmd: "python3 -c 'print(42)'".to_string() }], - allow_prefix: None, + allow_prefix: Some(vec![ + "python3".to_string(), + "-c".to_string(), + "print(42)".to_string(), + ]), }, params ); diff --git a/codex-rs/protocol/src/approvals.rs b/codex-rs/protocol/src/approvals.rs index b91e6865ae..c63f275e40 100644 --- a/codex-rs/protocol/src/approvals.rs +++ b/codex-rs/protocol/src/approvals.rs @@ -53,7 +53,6 @@ pub struct ExecApprovalRequestEvent { pub parsed_cmd: Vec, /// Optional command prefix that can be allowlisted to avoid future prompts. #[serde(skip_serializing_if = "Option::is_none")] - #[serde(default)] pub allow_prefix: Option>, }