From e1e205c2dffe2a9cf0fc5c83b6304236f2ed433c Mon Sep 17 00:00:00 2001 From: Ahmed Ibrahim <219906144+aibrahim-oai@users.noreply.github.com> Date: Tue, 17 Mar 2026 05:25:53 +0000 Subject: [PATCH] Record validation pass 2 Co-authored-by: Codex --- .codex/flaky-test-triage.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.codex/flaky-test-triage.md b/.codex/flaky-test-triage.md index 94504c4923..15774b67bf 100644 --- a/.codex/flaky-test-triage.md +++ b/.codex/flaky-test-triage.md @@ -82,6 +82,7 @@ Older failures also appeared on Linux, but the repeated cross-PR signal is stron - CI annotation `67343276143` showed the busy-loop test yielded only the synthetic `Script running with cell ID ...` header and missed the expected `phase 1` output item. The root cause is in `core/src/tools/code_mode/runner.cjs`: the initial `yield_time_ms` timer started when the worker was created, so on a loaded runner the `100ms` budget could expire before the worker had begun executing `text("phase 1")`. - Current follow-up: make the worker emit an internal `started` message and arm the initial yield timer only after that signal arrives, so `yield_time_ms` measures script execution time instead of worker startup delay. - Runs `23178075559` (`rust-ci`) and `23178075565` (`Bazel (experimental)`) finished green on head `d8450f8e2`. The code-mode runner now starts the initial yield timer only after the worker signals that execution has started, so `code_mode_yield_timeout_works_for_busy_loop` no longer races against worker startup latency. This is pass 1 of 5 after the latest failing run. + - Runs `23179196582` (`rust-ci`) and `23179196522` (`Bazel (experimental)`) finished green on doc-only head `ad5be933d`, including the long-running Windows x64 and Windows arm64 `Tests` shards. That makes the current validation streak 2 of 5 after the latest failure. - Rationale: these failures are test-harness flakes, not product behaviors. The fixes keep the assertions intact and remove environment-sensitive startup and ordering hazards instead of stretching timeouts. ## Constraints @@ -127,3 +128,4 @@ Older failures also appeared on Linux, but the repeated cross-PR signal is stron | `4a3181290` | Suppress PowerShell CLIXML in apply_patch test | full pass | Runs `23176985939` (`rust-ci`) and `23176985980` (`Bazel (experimental)`) finished green for the full PR, including both Windows `Tests` jobs. The Windows `cmd.exe` harness now keeps the nested UTF-8 PowerShell read but suppresses progress records, switches to `[System.IO.File]::ReadAllText(...)`, and adds `-NonInteractive` so the shell tool returns only the source bytes. This is pass 1 of 5 after the latest failing run. | | `65f7f64ae` | Record validation pass 1 | failed | Run `23177624353` failed only in `Tests — ubuntu-24.04 - x86_64-unknown-linux-gnu`, in `codex-core::all::suite::code_mode::code_mode_yield_timeout_works_for_busy_loop`, while `Bazel (experimental)` run `23177624352` finished green on the same head. The only diff from the prior full-green head `4a3181290` was one extra line in this tracking document, so the failure exposed a latent code-mode yield race: the runner started the initial `yield_time_ms` timer when the worker was created, allowing the `100ms` budget to expire before the worker began executing user code on a loaded CI machine. | | `d8450f8e2` | Fix code mode yield startup race | full pass | Runs `23178075559` (`rust-ci`) and `23178075565` (`Bazel (experimental)`) both finished green for the full PR, including the previously flaky `Tests — ubuntu-24.04 - x86_64-unknown-linux-gnu` shard and both Windows `Tests` jobs. The code-mode runner now starts the initial yield timer only after the worker signals that execution has started, so `yield_time_ms` measures script runtime rather than worker startup latency. This is pass 1 of 5 after the latest failing run. | +| `ad5be933d` | Record validation pass 1 | full pass | Runs `23179196582` (`rust-ci`) and `23179196522` (`Bazel (experimental)`) finished green for the full PR, including the long-running Windows x64 and Windows arm64 `Tests` jobs. This extends the current streak to 2 consecutive full-suite green commits after `d8450f8e2`. |