mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
Add transcript search and per-activity detail controls (#46734)
## What changed - Add incremental, case-insensitive literal search across transcript details, loading older history as needed. Use `F3` to start Find, or `/` in the transcript pager, and navigate matches in either direction. Closing Find restores the previous presentation and reading position. - Add clickable activity detail controls and `F4` keyboard focus for inspecting individual activity groups in the owned transcript. Preserve expansion state as live activity becomes history. - Expose configurable `global.find_transcript`, `global.focus_activity`, and `pager.find` bindings under `tui.keymap`. Let new defaults yield to existing custom bindings and show available completions for pending chords. ## Testing Add regression coverage for Unicode matching, bounded scanning, paginated and changing history, selection during search, composer input isolation, activity controls, and custom shortcut conflicts. GitOrigin-RevId: 5bcbcdfbca7c5c296c635ec9b079ccd7a908e336
This commit is contained in:
@@ -83,7 +83,7 @@ impl TranscriptView {
|
||||
}
|
||||
}
|
||||
|
||||
/// Rejoin current history, retaining a replaced group until navigation leaves its revision.
|
||||
/// Rejoin current history, retaining Find offsets or a replaced group until navigation.
|
||||
/// Real selections keep their reading position, including a retired live revision.
|
||||
pub(crate) fn end_selection(&mut self, cells: &[Arc<dyn HistoryCell>]) {
|
||||
let Some(selection) = self.selection.take() else {
|
||||
@@ -100,7 +100,9 @@ impl TranscriptView {
|
||||
self.hold_position();
|
||||
}
|
||||
if let Position::Reading(anchor) = self.position {
|
||||
if !cells.iter().any(|cell| EntryKey::cell(cell) == anchor.key) {
|
||||
if self.search.has_active_query()
|
||||
|| !cells.iter().any(|cell| EntryKey::cell(cell) == anchor.key)
|
||||
{
|
||||
self.held_reading = Some(selection.snapshot);
|
||||
return;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user