mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
Launch Linux pipe processes through a fresh setup helper (#47612)
## Why Linux pipe launches need session, parent-death signal, and descriptor setup. Move this work into a fresh, single-threaded executable image to avoid forking the app-server for child setup. ## What changed - Register an early setup helper and launch it through `posix_spawn` for Linux pipe processes. - Start the helper with an empty environment, then transfer the target environment over a control socket so loader settings cannot interfere with helper startup. - Await target execution asynchronously, propagate setup and execution errors, and kill incomplete launches on cancellation. - Preserve direct spawning as a fallback when the helper is unavailable or fails before target execution. ## Testing Add coverage for launch semantics, avoiding fork, loader environment isolation, early argument dispatch, closed standard descriptors, and fallback under bootstrap failure or descriptor pressure. Add an app-server regression test that reuses a process handle after an execution failure. GitOrigin-RevId: 079c673f0f22ebd531f8c57e5338095cc98acfdc
This commit is contained in:
@@ -41,6 +41,7 @@ rust_binary(
|
||||
deps = [
|
||||
"//codex-rs/exec-server",
|
||||
"//codex-rs/http-client",
|
||||
"//codex-rs/utils/pty",
|
||||
"@crates//:tokio",
|
||||
],
|
||||
)
|
||||
|
||||
@@ -12,6 +12,8 @@ use std::ffi::OsStr;
|
||||
const CODEX_LINUX_SANDBOX_EXE_ENV_VAR: &str = "CODEX_TEST_LINUX_SANDBOX_EXE";
|
||||
|
||||
fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
|
||||
#[cfg(target_os = "linux")]
|
||||
codex_utils_pty::init_spawn_helper(std::env::args_os());
|
||||
let mut args = std::env::args_os();
|
||||
let _ = args.next();
|
||||
let argv1 = args.next();
|
||||
|
||||
Reference in New Issue
Block a user