mirror of
https://github.com/openai/codex.git
synced 2026-11-08 20:40:33 +00:00
Keep Guardian reviewers on summary-based compaction (#43912)
## Why Guardian reviewers can inherit token-budget mode from the parent session or model defaults, causing context rollover instead of summary-based compaction. ## What changed Clear inherited token-budget startup activation, set an explicit default `TokenBudgetConfig`, and disable `Feature::TokenBudget` and `Feature::ContextManagement` for Guardian review sessions. ## Testing Update regression coverage to verify that reviewers compact with a summary even when the parent and model enable token budgets. Cover both transcript modes and browser evidence, checking that review requests omit `token_budget.context_window` and retain the compaction summary. GitOrigin-RevId: e1a84f9c7752a712399cd749c3834b2a7bb4a7e6
This commit is contained in:
@@ -13,6 +13,7 @@ use tracing::warn;
|
||||
use crate::config::Config;
|
||||
use crate::config::Constrained;
|
||||
use crate::config::NetworkProxySpec;
|
||||
use crate::config::TokenBudgetConfig;
|
||||
|
||||
use super::prompt::BUNDLED_GUARDIAN_POLICY_TEMPLATE;
|
||||
use super::prompt::guardian_policy_prompt_with_config_and_template;
|
||||
@@ -43,6 +44,10 @@ pub fn build_guardian_review_session_config(
|
||||
guardian_config.include_skill_instructions = false;
|
||||
guardian_config.memories.use_memories = false;
|
||||
guardian_config.memories.dedicated_tools = false;
|
||||
// Clear inherited startup activation and keep an explicit configuration so model
|
||||
// defaults cannot re-enable token-budget mode after the feature is disabled below.
|
||||
guardian_config.token_budget_startup_config = None;
|
||||
guardian_config.token_budget = Some(TokenBudgetConfig::default());
|
||||
let catalog_auto_review = model_messages.and_then(|messages| messages.auto_review.as_ref());
|
||||
let tenant_policy_config = parent_config.resolve_guardian_policy(model_messages);
|
||||
let policy_template = catalog_auto_review
|
||||
@@ -90,6 +95,8 @@ pub fn build_guardian_review_session_config(
|
||||
Feature::Collab,
|
||||
Feature::MultiAgentV2,
|
||||
Feature::GuardianV2,
|
||||
Feature::TokenBudget,
|
||||
Feature::ContextManagement,
|
||||
Feature::CodexHooks,
|
||||
Feature::Apps,
|
||||
Feature::Plugins,
|
||||
|
||||
Reference in New Issue
Block a user