mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
Add directional conversation focus shortcuts in workspace mode (#59287)
## What changed - Add configurable `focus_pane_left` and `focus_pane_right` actions, defaulting to `leader left` / `leader h` and `leader right` / `leader l`. - Move focus to the parent or open side conversation without reopening a hidden pane. Preserve the current interaction when no neighbor is available, and accept fresh typing after a no-op shortcut while suppressing reported key repeats. - Expose the actions in the keymap picker and configuration schema, and prevent workspace-only pane bindings from claiming keys in classic mode. ## Testing Add regression coverage for pane navigation, preserved transcript selection and search, fresh typing after a no-op, key capture, and binding conflicts and limits. GitOrigin-RevId: 7f7629d15cffcd35d1353b36c5c9208dbb1034e8
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
//! Entry points for the configuration browser and its existing child editors.
|
||||
|
||||
use super::ChatWidget;
|
||||
use crate::activation_key_guard::ActivationKeySuppression;
|
||||
use crate::config_panel::ConfigEditor;
|
||||
use crate::config_panel::ConfigEditorHandoff;
|
||||
use crate::config_panel::ConfigPanel;
|
||||
@@ -69,7 +70,11 @@ impl ChatWidget {
|
||||
}
|
||||
}
|
||||
if let Some(activated_at) = handoff.active_at() {
|
||||
self.suppress_current_view_key_until_release(handoff.activation_key, activated_at);
|
||||
self.suppress_current_view_key_until_release(
|
||||
handoff.activation_key,
|
||||
activated_at,
|
||||
ActivationKeySuppression::ViewTransition,
|
||||
);
|
||||
}
|
||||
self.bottom_pane.config_editor_opened();
|
||||
}
|
||||
|
||||
@@ -2,6 +2,7 @@
|
||||
|
||||
use super::clipboard::PendingCopy;
|
||||
use super::*;
|
||||
use crate::activation_key_guard::ActivationKeySuppression;
|
||||
use crate::bottom_pane::BottomPaneView;
|
||||
use crate::clipboard_copy::CopyStatus;
|
||||
use crate::clipboard_copy::worker::CopyResult;
|
||||
@@ -91,9 +92,10 @@ impl ChatWidget {
|
||||
&mut self,
|
||||
key: KeyBinding,
|
||||
activated_at: Instant,
|
||||
suppression: ActivationKeySuppression,
|
||||
) {
|
||||
self.bottom_pane
|
||||
.suppress_current_view_key_until_release(key, activated_at);
|
||||
.suppress_current_view_key_until_release(key, activated_at, suppression);
|
||||
}
|
||||
|
||||
pub(crate) fn consume_view_transition_key_event(&mut self, key_event: KeyEvent) -> bool {
|
||||
|
||||
@@ -587,7 +587,7 @@ impl ChatWidget {
|
||||
Some(crate::activation_key_guard::ActivationKeyGuard::new_at(
|
||||
KeyBinding::from_event(key),
|
||||
Instant::now(),
|
||||
/*key_releases_reported*/ false,
|
||||
/*reported_repeats_only*/ false,
|
||||
));
|
||||
}
|
||||
consumed
|
||||
|
||||
Reference in New Issue
Block a user