Capture saved Daybreak preferences for native helpers (#60749)

## What changed

Add the disabled-by-default `daybreak_program_propagation` feature to capture a parent's saved Daybreak choice when spawning native helpers. Retain the choice and account identity for helper turns and nested spawns, while preserving explicit `cyber_access_program` overrides. A helper's own saved preference takes precedence on later turns.

Read pending metadata before persisted metadata so preferences survive thread materialization, with stored choices taking precedence. Share this resolution logic with `thread/read` and support refreshing the feature through user configuration.

## Testing

Add coverage for saved and pending preferences, unset choices, explicit overrides, failed metadata reads, nested spawns, parent unloading, feature withdrawal, and preference changes between helper turns.

GitOrigin-RevId: b3b349da8cb3d48154cddf058890587385efcda2
This commit is contained in:
jamy-OAI
2026-11-11 07:39:04 +00:00
committed by copyberry
parent c320b5c69e
commit d9a32c1789
23 changed files with 780 additions and 24 deletions
+38
View File
@@ -1,6 +1,7 @@
//! Verifies conservative classification at the shared storage error boundary.
use super::ThreadStoreError;
use codex_protocol::ThreadId;
use pretty_assertions::assert_eq;
#[test]
@@ -21,3 +22,40 @@ fn unclassified_sqlx_failures_remain_internal() {
assert_eq!(message, expected);
}
}
#[test]
fn missing_read_requires_the_requested_thread_and_a_known_store_error() {
let requested = ThreadId::new();
let other = ThreadId::new();
let missing_rollout = format!("no rollout found for thread id {requested}");
for error in [
ThreadStoreError::ThreadNotFound {
thread_id: requested,
},
ThreadStoreError::InvalidRequest {
message: missing_rollout.clone(),
},
] {
assert!(error.is_missing_for_read(requested));
assert!(!error.is_missing_for_read(other));
}
for error in [
ThreadStoreError::InvalidRequest {
message: format!("{missing_rollout} (lookup failed)"),
},
ThreadStoreError::InvalidRequest {
message: format!("thread {requested} is archived"),
},
ThreadStoreError::Retryable {
message: missing_rollout.clone(),
},
ThreadStoreError::Internal {
message: missing_rollout,
},
ThreadStoreError::Unsupported {
operation: "read_thread",
},
] {
assert!(!error.is_missing_for_read(requested), "{error:?}");
}
}