mirror of
https://github.com/openai/codex.git
synced 2026-11-16 22:00:36 +00:00
Honor system proxy settings for remote plugins (#34509)
## Why Remote plugin requests did not use Codex's effective outbound proxy policy, so they could bypass configured system proxy and PAC routing. ## What changed - Route remote plugin catalog, mutation, sharing, upload, and bundle download requests through the configured route-aware HTTP client. - Select routes using the complete request URL, including encoded query parameters and backend-provided signed upload or download URLs. - Preserve standard Codex headers and suppress diagnostics for URLs or headers that may contain credentials. ## Testing Add coverage for route selection of catalog queries, workspace plugin uploads, and backend-provided bundle download URLs. GitOrigin-RevId: 106936659e21decf145b6ab4d4be84992e386861
This commit is contained in:
@@ -93,6 +93,7 @@ pub async fn checkout_remote_plugin_share(
|
||||
))
|
||||
})?;
|
||||
crate::remote_bundle::download_and_extract_remote_plugin_bundle_to_path(
|
||||
config,
|
||||
bundle,
|
||||
local_plugin_path.clone(),
|
||||
)
|
||||
|
||||
@@ -1,4 +1,6 @@
|
||||
use super::*;
|
||||
use crate::test_support::recorded_http_client_urls;
|
||||
use crate::test_support::recording_remote_plugin_service_config;
|
||||
use codex_app_server_protocol::PluginAuthPolicy;
|
||||
use codex_app_server_protocol::PluginInstallPolicy;
|
||||
use codex_app_server_protocol::PluginInterface;
|
||||
@@ -175,7 +177,8 @@ async fn save_remote_plugin_share_creates_workspace_plugin() {
|
||||
.unwrap()
|
||||
.len();
|
||||
let server = MockServer::start().await;
|
||||
let config = test_config(&server);
|
||||
let (config, selected_urls) =
|
||||
recording_remote_plugin_service_config(format!("{}/backend-api", server.uri()));
|
||||
let auth = test_auth();
|
||||
|
||||
Mock::given(method("POST"))
|
||||
@@ -261,6 +264,17 @@ async fn save_remote_plugin_share_creates_workspace_plugin() {
|
||||
local_paths::load_plugin_share_local_paths(codex_home.path()).unwrap(),
|
||||
BTreeMap::from([("plugins_123".to_string(), plugin_path)])
|
||||
);
|
||||
assert_eq!(
|
||||
recorded_http_client_urls(&selected_urls),
|
||||
vec![
|
||||
format!(
|
||||
"{}/backend-api/public/plugins/workspace/upload-url",
|
||||
server.uri()
|
||||
),
|
||||
format!("{}/upload/file_123", server.uri()),
|
||||
format!("{}/backend-api/public/plugins/workspace", server.uri()),
|
||||
]
|
||||
);
|
||||
|
||||
let requests = server.received_requests().await.unwrap_or_default();
|
||||
let upload_request = requests
|
||||
|
||||
Reference in New Issue
Block a user