mirror of
https://github.com/openai/codex.git
synced 2026-11-17 22:10:37 +00:00
Capture local attachments before queuing turn input (#61962)
## Why Queued input can outlive its local attachment files. Reading those files only when rendering a model message can lose media submitted while turn admission is pending. ## What changed - Introduce `ResolvedUserInput` to carry captured image bytes, audio data URLs, or read errors through session queues and agent input. - Resolve client attachments on the submitting host before queuing, using a blocking task for local file reads. - Render messages from captured payloads while preserving original paths and text spans for display, along with image position mappings. ## Testing Add coverage for rendering and serialization after source files are removed, steered audio retained during pending admission, and local audio errors and display content. GitOrigin-RevId: 4bbb6bda44167439a8cfdae15d3c476a7b1d336b
This commit is contained in:
committed by
copyberry
parent
65a4450886
commit
d8d840d32a
@@ -64,8 +64,6 @@ use crate::request_user_input::RequestUserInputResponse;
|
||||
use crate::response_item_id::OptionalWireItemId;
|
||||
use crate::turn_input::CyberAccessProgram;
|
||||
use crate::turn_input::SuspendTurnOutcome;
|
||||
use crate::turn_input::TurnInputMode;
|
||||
use crate::turn_input::TurnInputRequest;
|
||||
use crate::turn_input::TurnInputSubmission;
|
||||
use crate::turn_input::TurnStartOptions;
|
||||
use codex_extension_items::image_generation::GeneratedImageRef;
|
||||
@@ -786,14 +784,6 @@ pub enum Op {
|
||||
/// Request the list of voices supported by realtime conversation streams.
|
||||
RealtimeConversationListVoices,
|
||||
|
||||
/// Submit turn input using the requested routing behavior.
|
||||
#[debug("TurnInput {{ requested_settings: {:?} }}", request.thread_settings)]
|
||||
TurnInput {
|
||||
request: Box<TurnInputRequest>,
|
||||
mode: TurnInputMode,
|
||||
reply: oneshot::Sender<CodexResult<TurnInputSubmission>>,
|
||||
},
|
||||
|
||||
/// Resume an interrupted regular turn.
|
||||
#[debug("RecoverTurn {{ requested_settings: {thread_settings:?} }}")]
|
||||
RecoverTurn {
|
||||
@@ -1149,7 +1139,6 @@ impl Op {
|
||||
Self::RealtimeConversationClose => "realtime_conversation_close",
|
||||
Self::RealtimeConversationDetach { .. } => "realtime_conversation_detach",
|
||||
Self::RealtimeConversationListVoices => "realtime_conversation_list_voices",
|
||||
Self::TurnInput { .. } => "turn_input",
|
||||
Self::RecoverTurn { .. } => "recover_turn",
|
||||
Self::SuspendTurnAndShutdown { .. } => "suspend_turn_and_shutdown",
|
||||
Self::ThreadSettings { .. } => "thread_settings",
|
||||
|
||||
Reference in New Issue
Block a user