From d7d15f5fd35f8cd8f461cbf1522454c16a511a48 Mon Sep 17 00:00:00 2001 From: "Rai (Michael Pokorny)" Date: Tue, 24 Jun 2025 16:57:40 -0700 Subject: [PATCH] remove session-scoped approval option for patches; update command approve label to B variant --- .../src/components/chat/terminal-chat-command-review.tsx | 4 ++-- codex-rs/tui/src/user_approval_widget.rs | 8 +------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/codex-cli/src/components/chat/terminal-chat-command-review.tsx b/codex-cli/src/components/chat/terminal-chat-command-review.tsx index 4d1efd98e1..e9f451a226 100644 --- a/codex-cli/src/components/chat/terminal-chat-command-review.tsx +++ b/codex-cli/src/components/chat/terminal-chat-command-review.tsx @@ -80,14 +80,14 @@ export function TerminalChatCommandReview({ | { label: string; value: "switch" } > = [ { - label: "Yes (y)", + label: "Yes, run this command (y)", value: ReviewDecision.YES, }, ]; if (showAlwaysApprove) { opts.push({ - label: "Yes, always approve this exact patch for this session (a)", + label: "Yes, apply this patch (a)", value: ReviewDecision.ALWAYS, }); } diff --git a/codex-rs/tui/src/user_approval_widget.rs b/codex-rs/tui/src/user_approval_widget.rs index 7c93c538d5..9704f69cf3 100644 --- a/codex-rs/tui/src/user_approval_widget.rs +++ b/codex-rs/tui/src/user_approval_widget.rs @@ -58,17 +58,11 @@ struct SelectOption { // keep in same order as in the TS implementation const SELECT_OPTIONS: &[SelectOption] = &[ SelectOption { - label: "Yes (y)", + label: "Yes, run this command (y)", decision: Some(ReviewDecision::Approved), enters_input_mode: false, }, - SelectOption { - label: "Yes, always approve this exact patch for this session (a)", - decision: Some(ReviewDecision::ApprovedForSession), - - enters_input_mode: false, - }, SelectOption { label: "Edit or give feedback (e)", decision: None,