From 7791ad5c24d11642248028eabf55c657258e55f9 Mon Sep 17 00:00:00 2001 From: Michael Bolin Date: Mon, 30 Mar 2026 08:50:31 -0700 Subject: [PATCH] fix: address coverage gap in argument-comment-lint --- .bazelrc | 1 + codex-rs/core/src/shell_snapshot_tests.rs | 12 +++++++++--- tools/argument-comment-lint/README.md | 4 +++- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/.bazelrc b/.bazelrc index b9275426fa..91ae7915e7 100644 --- a/.bazelrc +++ b/.bazelrc @@ -80,6 +80,7 @@ build:clippy --@rules_rust//rust/settings:clippy.toml=//codex-rs:clippy.toml # Shared config for Bazel-backed argument-comment-lint. build:argument-comment-lint --aspects=//tools/argument-comment-lint:lint_aspect.bzl%rust_argument_comment_lint_aspect build:argument-comment-lint --output_groups=argument_comment_lint_checks +build:argument-comment-lint --build_manual_tests build:argument-comment-lint --@rules_rust//rust/toolchain/channel=nightly # Rearrange caches on Windows so they're on the same volume as the checkout. diff --git a/codex-rs/core/src/shell_snapshot_tests.rs b/codex-rs/core/src/shell_snapshot_tests.rs index 90288300ff..ff700ff7a6 100644 --- a/codex-rs/core/src/shell_snapshot_tests.rs +++ b/codex-rs/core/src/shell_snapshot_tests.rs @@ -313,9 +313,15 @@ async fn timed_out_snapshot_shell_is_terminated() -> Result<()> { shell_snapshot: crate::shell::empty_shell_snapshot_receiver(), }; - let err = run_script_with_timeout(&shell, &script, Duration::from_secs(1), true, dir.path()) - .await - .expect_err("snapshot shell should time out"); + let err = run_script_with_timeout( + &shell, + &script, + Duration::from_secs(1), + /*use_login_shell*/ true, + dir.path(), + ) + .await + .expect_err("snapshot shell should time out"); assert!( err.to_string().contains("timed out"), "expected timeout error, got {err:?}" diff --git a/tools/argument-comment-lint/README.md b/tools/argument-comment-lint/README.md index 78e28f308f..49efd344e1 100644 --- a/tools/argument-comment-lint/README.md +++ b/tools/argument-comment-lint/README.md @@ -138,7 +138,9 @@ If no package selection is provided, `just argument-comment-lint` now defaults to the Bazel aspect path over `//codex-rs/...`. The Python wrappers remain the package-scoped escape hatch and still default the underlying Cargo invocation to `--all-targets` unless you explicitly narrow the target set, so targeted -wrapper runs cover test-only call sites by default. +wrapper runs cover test-only call sites by default. The Bazel config also sets +`--build_manual_tests` so wildcard lint runs include the internal +`*-unit-tests-bin` Rust targets and catch inline `#[cfg(test)]` call sites. Repo runs also promote `uncommented_anonymous_literal_argument` to an error by default: