Apply argument comment lint across codex-rs

This commit is contained in:
Michael Bolin
2026-03-13 18:42:40 -07:00
parent 4e594bc93b
commit cfc2e4783d
208 changed files with 1652 additions and 944 deletions

View File

@@ -777,7 +777,7 @@ impl EventProcessor for EventProcessorWithHumanOutput {
self,
"{} {}",
"collab".style(self.magenta),
format_collab_invocation("wait", &call_id, None).style(self.bold)
format_collab_invocation("wait", &call_id, /*prompt=*/ None).style(self.bold)
);
eprintln!(
" receivers: {}",
@@ -794,7 +794,7 @@ impl EventProcessor for EventProcessorWithHumanOutput {
ts_msg!(
self,
"{} {}:",
format_collab_invocation("wait", &call_id, None),
format_collab_invocation("wait", &call_id, /*prompt=*/ None),
"timed out".style(self.yellow)
);
return CodexStatus::Running;
@@ -803,7 +803,7 @@ impl EventProcessor for EventProcessorWithHumanOutput {
let title_style = if success { self.green } else { self.red };
let title = format!(
"{} {} agents complete:",
format_collab_invocation("wait", &call_id, None),
format_collab_invocation("wait", &call_id, /*prompt=*/ None),
statuses.len()
);
ts_msg!(self, "{}", title.style(title_style));
@@ -829,7 +829,8 @@ impl EventProcessor for EventProcessorWithHumanOutput {
self,
"{} {}",
"collab".style(self.magenta),
format_collab_invocation("close_agent", &call_id, None).style(self.bold)
format_collab_invocation("close_agent", &call_id, /*prompt=*/ None)
.style(self.bold)
);
eprintln!(
" receiver: {}",
@@ -847,7 +848,7 @@ impl EventProcessor for EventProcessorWithHumanOutput {
let title_style = if success { self.green } else { self.red };
let title = format!(
"{} {}:",
format_collab_invocation("close_agent", &call_id, None),
format_collab_invocation("close_agent", &call_id, /*prompt=*/ None),
format_collab_status(&status)
);
ts_msg!(self, "{}", title.style(title_style));
@@ -1246,7 +1247,7 @@ fn format_collab_invocation(tool: &str, call_id: &str, prompt: Option<&str>) ->
let prompt = prompt
.map(str::trim)
.filter(|prompt| !prompt.is_empty())
.map(|prompt| truncate_preview(prompt, 120));
.map(|prompt| truncate_preview(prompt, /*max_chars=*/ 120));
match prompt {
Some(prompt) => format!("{tool}({call_id}, prompt=\"{prompt}\")"),
None => format!("{tool}({call_id})"),
@@ -1258,7 +1259,7 @@ fn format_collab_status(status: &AgentStatus) -> String {
AgentStatus::PendingInit => "pending init".to_string(),
AgentStatus::Running => "running".to_string(),
AgentStatus::Completed(Some(message)) => {
let preview = truncate_preview(message.trim(), 120);
let preview = truncate_preview(message.trim(), /*max_chars=*/ 120);
if preview.is_empty() {
"completed".to_string()
} else {
@@ -1267,7 +1268,7 @@ fn format_collab_status(status: &AgentStatus) -> String {
}
AgentStatus::Completed(None) => "completed".to_string(),
AgentStatus::Errored(message) => {
let preview = truncate_preview(message.trim(), 120);
let preview = truncate_preview(message.trim(), /*max_chars=*/ 120);
if preview.is_empty() {
"errored".to_string()
} else {

View File

@@ -495,7 +495,7 @@ impl EventProcessorWithJsonOutput {
.iter()
.map(ToString::to_string)
.collect(),
None,
/*prompt=*/ None,
)
}
@@ -526,7 +526,7 @@ impl EventProcessorWithJsonOutput {
CollabTool::Wait,
ev.sender_thread_id.to_string(),
receiver_thread_ids,
None,
/*prompt=*/ None,
agents_states,
status,
)
@@ -538,7 +538,7 @@ impl EventProcessorWithJsonOutput {
CollabTool::CloseAgent,
ev.sender_thread_id.to_string(),
vec![ev.receiver_thread_id.to_string()],
None,
/*prompt=*/ None,
)
}
@@ -555,7 +555,7 @@ impl EventProcessorWithJsonOutput {
CollabTool::CloseAgent,
ev.sender_thread_id.to_string(),
vec![receiver_id.clone()],
None,
/*prompt=*/ None,
[(receiver_id, agent_state)].into_iter().collect(),
status,
)

View File

@@ -288,7 +288,7 @@ pub async fn run_main(cli: Cli, arg0_paths: Arg0DispatchPaths) -> anyhow::Result
let cloud_auth_manager = AuthManager::shared(
codex_home.clone(),
false,
/*enable_codex_api_key_env=*/ false,
config_toml.cli_auth_credentials_store.unwrap_or_default(),
);
let chatgpt_base_url = config_toml
@@ -389,7 +389,7 @@ pub async fn run_main(cli: Cli, arg0_paths: Arg0DispatchPaths) -> anyhow::Result
codex_core::otel_init::build_provider(
&config,
env!("CARGO_PKG_VERSION"),
None,
/*service_name_override=*/ None,
DEFAULT_ANALYTICS_ENABLED,
)
})) {
@@ -1343,7 +1343,7 @@ fn local_external_chatgpt_tokens(
) -> Result<ChatgptAuthTokensRefreshResponse, String> {
let auth_manager = AuthManager::shared(
config.codex_home.clone(),
false,
/*enable_codex_api_key_env=*/ false,
config.cli_auth_credentials_store_mode,
);
auth_manager.set_forced_chatgpt_workspace_id(config.forced_chatgpt_workspace_id.clone());
@@ -1394,8 +1394,8 @@ async fn resolve_resume_path(
};
match codex_core::RolloutRecorder::find_latest_thread_path(
config,
1,
None,
/*page_size=*/ 1,
/*cursor=*/ None,
codex_core::ThreadSortKey::UpdatedAt,
&[],
Some(default_provider_filter.as_slice()),